You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by huaxingao <gi...@git.apache.org> on 2018/08/24 21:14:48 UTC

[GitHub] spark pull request #22228: [SPARK-25124][ML]VectorSizeHint setSize and getSi...

GitHub user huaxingao opened a pull request:

    https://github.com/apache/spark/pull/22228

    [SPARK-25124][ML]VectorSizeHint setSize and getSize don't return values backport to 2.3

    ## What changes were proposed in this pull request?
    In feature.py, VectorSizeHint setSize and getSize don't return value. Add return.
    
    (Please fill in changes proposed in this fix)
    
    ## How was this patch tested?
    
    Unit Test added

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/huaxingao/spark spark-25124-2.3

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/22228.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #22228
    
----
commit 35092f0b829dea4520014eb980e31bb3511c9e7f
Author: Huaxin Gao <hu...@...>
Date:   2018-08-24T21:10:05Z

    [SPARK-25124][ML]VectorSizeHint setSize and getSize don't return values backport to 2.3

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22228: [SPARK-25124][ML]VectorSizeHint setSize and getSize don'...

Posted by huaxingao <gi...@git.apache.org>.

Github user huaxingao commented on the issue:

    https://github.com/apache/spark/pull/22228
  
    @jkbradley  backport to 2.3. 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22228: [SPARK-25124][ML]VectorSizeHint setSize and getSize don'...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22228
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22228: [SPARK-25124][ML]VectorSizeHint setSize and getSize don'...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22228
  
    **[Test build #95230 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95230/testReport)** for PR 22228 at commit [`35092f0`](https://github.com/apache/spark/commit/35092f0b829dea4520014eb980e31bb3511c9e7f).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22228: [SPARK-25124][ML]VectorSizeHint setSize and getSize don'...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22228
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95230/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22228: [SPARK-25124][ML]VectorSizeHint setSize and getSize don'...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22228
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2542/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22228: [SPARK-25124][ML]VectorSizeHint setSize and getSize don'...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22228
  
    **[Test build #95230 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95230/testReport)** for PR 22228 at commit [`35092f0`](https://github.com/apache/spark/commit/35092f0b829dea4520014eb980e31bb3511c9e7f).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22228: [SPARK-25124][ML]VectorSizeHint setSize and getSize don'...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22228
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org