You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/10/13 08:48:51 UTC
[GitHub] [spark] AngersZhuuuu commented on pull request #34271: [WIP][SPARK-36995][SQL] Add SQLFileCommitProtocol
AngersZhuuuu commented on pull request #34271:
URL: https://github.com/apache/spark/pull/34271#issuecomment-942075035
One solution is we can just add below API in FileCommitProtocol
```
def getOutputPath(): Path = null
def getWorkPath(): Path = null
def hasOutputPath(): Boolean = {
return getOutputPath() != null;
}
```
then we can complicate history customized FileCommitProtocol and also can implement more function.
WDYT @dongjoon-hyun @HyukjinKwon @viirya @cloud-fan @maropu @Ngone51
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org