You are viewing a plain text version of this content. The canonical link for it is here.
Posted to fop-dev@xmlgraphics.apache.org by bu...@apache.org on 2011/09/30 15:41:00 UTC
DO NOT REPLY [Bug 51928] New: [PATCH] Upgrade to JUnit4
https://issues.apache.org/bugzilla/show_bug.cgi?id=51928
Bug #: 51928
Summary: [PATCH] Upgrade to JUnit4
Product: Fop
Version: 1.0
Platform: PC
OS/Version: Linux
Status: NEW
Severity: normal
Priority: P2
Component: general
AssignedTo: fop-dev@xmlgraphics.apache.org
ReportedBy: med1985@gmail.com
Classification: Unclassified
Created attachment 27649
--> https://issues.apache.org/bugzilla/attachment.cgi?id=27649
Update unit tests to JUnit4
This is the eagerly anticipated upgrade of FOPs JUnit tests to JUnit4. There
are a few notable differences:
1) Tests can now be parameterized (I'll discuss this later).
2) The test outputs have less meaningful names when parameterized, the layout
engine tests used to be instantiated with the names of set as the name of the
FO used in the test. Because these have been changed to be parameterized tests,
the output is less useful. I haven't found a suitable way of changing the name
of the test for a parameterized test short of overriding the
org.junit.runners.Parameterized.
I've tried to touch as little as possible with the layout engine tests, in
terms of their reliance on the system properties being injected in. I wish to
change that in a future commit, but I think it's a logically separate issue and
I will create a separate patch for that.
The layout engine tests do need a little TLC, there seems to be a fair amount
of code duplication in that area. I'll address these at the same time as the
patch above.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
DO NOT REPLY [Bug 51928] [PATCH] Upgrade to JUnit4
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51928
Mehdi Houshmand <me...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #27649|0 |1
is obsolete| |
--- Comment #2 from Mehdi Houshmand <me...@gmail.com> 2011-10-03 14:46:34 UTC ---
Created attachment 27677
--> https://issues.apache.org/bugzilla/attachment.cgi?id=27677
patch with LayoutEngineTestUtils
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
DO NOT REPLY [Bug 51928] [PATCH] Upgrade to JUnit4
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51928
Mehdi Houshmand <me...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |CLOSED
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
DO NOT REPLY [Bug 51928] [PATCH] Upgrade to JUnit4
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51928
Vincent Hennebert <vh...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
--- Comment #3 from Vincent Hennebert <vh...@gmail.com> 2011-10-04 10:13:25 UTC ---
Patch applied in rev. 1178747:
http://svn.apache.org/viewvc?rev=1178747&view=rev
I made some minor modifications relating to cosmetics and a few elements lost
in the conversion.
Some things could be improved in the FO Tree, Layout and Area Tree tests but
since you mentioned that you will be working on them in a separate patch, I
committed them as they are.
Thanks!
Vincent
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
DO NOT REPLY [Bug 51928] [PATCH] Upgrade to JUnit4
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51928
--- Comment #1 from Vincent Hennebert <vh...@gmail.com> 2011-10-03 14:38:47 UTC ---
Hi Mehdi,
The patch is missing a new LayoutEngineTestUtils class. Can you please add it
to this bug report?
In the future, you can include new classes directly to patches by 'svn add'ing
them before creating the patch.
Thanks,
Vincent
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.