You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Robert Levas <rl...@hortonworks.com> on 2016/11/30 22:03:16 UTC
Review Request 54231: Deployment failing at creating principal
[addendum]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54231/
-----------------------------------------------------------
Review request for Ambari, Jonathan Hurley, Nate Cole, and Sumit Mohanty.
Bugs: AMBARI-18755
https://issues.apache.org/jira/browse/AMBARI-18755
Repository: ambari
Description
-------
Cluster deployment via blueprint failed at creating principals
Diffs
-----
ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 4ba371a
Diff: https://reviews.apache.org/r/54231/diff/
Testing
-------
Manually tested
Thanks,
Robert Levas
Re: Review Request 54231: Deployment failing at creating principal
[addendum]
Posted by Robert Levas <rl...@hortonworks.com>.
> On Nov. 30, 2016, 5:57 p.m., Mahadev Konar wrote:
> > /home/crashtua/dev/ambari-work/usr/lib/python2.6/site-packages/ambari_server/setupAgent.py` | this looks wrong no?
That must be a factor of the index.md file creation routine. I will fix this.
- Robert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54231/#review157490
-----------------------------------------------------------
On Nov. 30, 2016, 5:04 p.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54231/
> -----------------------------------------------------------
>
> (Updated Nov. 30, 2016, 5:04 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley, Nate Cole, and Sumit Mohanty.
>
>
> Bugs: AMBARI-18755
> https://issues.apache.org/jira/browse/AMBARI-18755
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Cluster deployment via blueprint failed at creating principals
>
>
> Diffs
> -----
>
> ambari-server/docs/configuration/index.md 77d3a4d
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 9be8751
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandler.java 2f756fb
> ambari-server/src/main/java/org/apache/ambari/server/utils/ShellCommandUtil.java 99f47c5
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandlerTest.java 4c40a5d
> ambari-server/src/test/java/org/apache/ambari/server/utils/TestShellCommandUtil.java 34ac91f
>
> Diff: https://reviews.apache.org/r/54231/diff/
>
>
> Testing
> -------
>
> Manually tested
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 54231: Deployment failing at creating principal
[addendum]
Posted by Mahadev Konar <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54231/#review157490
-----------------------------------------------------------
/home/crashtua/dev/ambari-work/usr/lib/python2.6/site-packages/ambari_server/setupAgent.py` | this looks wrong no?
- Mahadev Konar
On Nov. 30, 2016, 10:04 p.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54231/
> -----------------------------------------------------------
>
> (Updated Nov. 30, 2016, 10:04 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley, Nate Cole, and Sumit Mohanty.
>
>
> Bugs: AMBARI-18755
> https://issues.apache.org/jira/browse/AMBARI-18755
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Cluster deployment via blueprint failed at creating principals
>
>
> Diffs
> -----
>
> ambari-server/docs/configuration/index.md 77d3a4d
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 9be8751
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandler.java 2f756fb
> ambari-server/src/main/java/org/apache/ambari/server/utils/ShellCommandUtil.java 99f47c5
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandlerTest.java 4c40a5d
> ambari-server/src/test/java/org/apache/ambari/server/utils/TestShellCommandUtil.java 34ac91f
>
> Diff: https://reviews.apache.org/r/54231/diff/
>
>
> Testing
> -------
>
> Manually tested
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 54231: Deployment failing at creating principal
[addendum]
Posted by Robert Nettleton <rn...@hortonworks.com>.
> On Nov. 30, 2016, 10:05 p.m., Robert Nettleton wrote:
> > Ship It!
Sorry, my "Ship It" was based on the SQL patch.
- Robert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54231/#review157480
-----------------------------------------------------------
On Nov. 30, 2016, 10:04 p.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54231/
> -----------------------------------------------------------
>
> (Updated Nov. 30, 2016, 10:04 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley, Nate Cole, and Sumit Mohanty.
>
>
> Bugs: AMBARI-18755
> https://issues.apache.org/jira/browse/AMBARI-18755
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Cluster deployment via blueprint failed at creating principals
>
>
> Diffs
> -----
>
> ambari-server/docs/configuration/index.md 77d3a4d
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 9be8751
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandler.java 2f756fb
> ambari-server/src/main/java/org/apache/ambari/server/utils/ShellCommandUtil.java 99f47c5
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandlerTest.java 4c40a5d
> ambari-server/src/test/java/org/apache/ambari/server/utils/TestShellCommandUtil.java 34ac91f
>
> Diff: https://reviews.apache.org/r/54231/diff/
>
>
> Testing
> -------
>
> Manually tested
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 54231: Deployment failing at creating principal
[addendum]
Posted by Robert Levas <rl...@hortonworks.com>.
> On Nov. 30, 2016, 5:05 p.m., Robert Nettleton wrote:
> > Ship It!
>
> Robert Nettleton wrote:
> Sorry, my "Ship It" was based on the SQL patch.
doh... thanks for the quick response though... it was just too quick. ;)
- Robert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54231/#review157480
-----------------------------------------------------------
On Nov. 30, 2016, 5:04 p.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54231/
> -----------------------------------------------------------
>
> (Updated Nov. 30, 2016, 5:04 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley, Nate Cole, and Sumit Mohanty.
>
>
> Bugs: AMBARI-18755
> https://issues.apache.org/jira/browse/AMBARI-18755
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Cluster deployment via blueprint failed at creating principals
>
>
> Diffs
> -----
>
> ambari-server/docs/configuration/index.md 77d3a4d
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 9be8751
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandler.java 2f756fb
> ambari-server/src/main/java/org/apache/ambari/server/utils/ShellCommandUtil.java 99f47c5
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandlerTest.java 4c40a5d
> ambari-server/src/test/java/org/apache/ambari/server/utils/TestShellCommandUtil.java 34ac91f
>
> Diff: https://reviews.apache.org/r/54231/diff/
>
>
> Testing
> -------
>
> Manually tested
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 54231: Deployment failing at creating principal
[addendum]
Posted by Robert Nettleton <rn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54231/#review157480
-----------------------------------------------------------
Ship it!
Ship It!
- Robert Nettleton
On Nov. 30, 2016, 10:04 p.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54231/
> -----------------------------------------------------------
>
> (Updated Nov. 30, 2016, 10:04 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley, Nate Cole, and Sumit Mohanty.
>
>
> Bugs: AMBARI-18755
> https://issues.apache.org/jira/browse/AMBARI-18755
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Cluster deployment via blueprint failed at creating principals
>
>
> Diffs
> -----
>
> ambari-server/docs/configuration/index.md 77d3a4d
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 9be8751
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandler.java 2f756fb
> ambari-server/src/main/java/org/apache/ambari/server/utils/ShellCommandUtil.java 99f47c5
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandlerTest.java 4c40a5d
> ambari-server/src/test/java/org/apache/ambari/server/utils/TestShellCommandUtil.java 34ac91f
>
> Diff: https://reviews.apache.org/r/54231/diff/
>
>
> Testing
> -------
>
> Manually tested
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 54231: Deployment failing at creating principal
[addendum]
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54231/#review157537
-----------------------------------------------------------
Ship it!
Ship It!
- Jonathan Hurley
On Nov. 30, 2016, 6:32 p.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54231/
> -----------------------------------------------------------
>
> (Updated Nov. 30, 2016, 6:32 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley, Nate Cole, and Sumit Mohanty.
>
>
> Bugs: AMBARI-18755
> https://issues.apache.org/jira/browse/AMBARI-18755
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Cluster deployment via blueprint failed at creating principals
>
>
> Diffs
> -----
>
> ambari-server/docs/configuration/index.md 77d3a4d
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 9be8751
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandler.java 2f756fb
> ambari-server/src/main/java/org/apache/ambari/server/utils/ShellCommandUtil.java 99f47c5
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandlerTest.java 4c40a5d
> ambari-server/src/test/java/org/apache/ambari/server/utils/TestShellCommandUtil.java 34ac91f
>
> Diff: https://reviews.apache.org/r/54231/diff/
>
>
> Testing
> -------
>
> Manually tested
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 54231: Deployment failing at creating principal
[addendum]
Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54231/#review157496
-----------------------------------------------------------
Ship it!
Ship It!
- Sumit Mohanty
On Nov. 30, 2016, 11:32 p.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54231/
> -----------------------------------------------------------
>
> (Updated Nov. 30, 2016, 11:32 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley, Nate Cole, and Sumit Mohanty.
>
>
> Bugs: AMBARI-18755
> https://issues.apache.org/jira/browse/AMBARI-18755
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Cluster deployment via blueprint failed at creating principals
>
>
> Diffs
> -----
>
> ambari-server/docs/configuration/index.md 77d3a4d
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 9be8751
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandler.java 2f756fb
> ambari-server/src/main/java/org/apache/ambari/server/utils/ShellCommandUtil.java 99f47c5
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandlerTest.java 4c40a5d
> ambari-server/src/test/java/org/apache/ambari/server/utils/TestShellCommandUtil.java 34ac91f
>
> Diff: https://reviews.apache.org/r/54231/diff/
>
>
> Testing
> -------
>
> Manually tested
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 54231: Deployment failing at creating principal
[addendum]
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54231/
-----------------------------------------------------------
(Updated Nov. 30, 2016, 6:32 p.m.)
Review request for Ambari, Jonathan Hurley, Nate Cole, and Sumit Mohanty.
Changes
-------
Fixed index.md example strings, changed default retry wait time from 30 seconds to 10 seconds.
Bugs: AMBARI-18755
https://issues.apache.org/jira/browse/AMBARI-18755
Repository: ambari
Description
-------
Cluster deployment via blueprint failed at creating principals
Diffs (updated)
-----
ambari-server/docs/configuration/index.md 77d3a4d
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 9be8751
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandler.java 2f756fb
ambari-server/src/main/java/org/apache/ambari/server/utils/ShellCommandUtil.java 99f47c5
ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandlerTest.java 4c40a5d
ambari-server/src/test/java/org/apache/ambari/server/utils/TestShellCommandUtil.java 34ac91f
Diff: https://reviews.apache.org/r/54231/diff/
Testing
-------
Manually tested
Thanks,
Robert Levas
Re: Review Request 54231: Deployment failing at creating principal
[addendum]
Posted by Robert Levas <rl...@hortonworks.com>.
> On Nov. 30, 2016, 5:57 p.m., Sumit Mohanty wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandler.java, line 476
> > <https://reviews.apache.org/r/54231/diff/2/?file=1573307#file1573307line476>
> >
> > It appears we increased the timeout from 3 seconds to 30 seconds. Intentional?
Yes this was intential.. and now configurable. Should the default be something more like 10 seconds?
- Robert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54231/#review157489
-----------------------------------------------------------
On Nov. 30, 2016, 5:04 p.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54231/
> -----------------------------------------------------------
>
> (Updated Nov. 30, 2016, 5:04 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley, Nate Cole, and Sumit Mohanty.
>
>
> Bugs: AMBARI-18755
> https://issues.apache.org/jira/browse/AMBARI-18755
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Cluster deployment via blueprint failed at creating principals
>
>
> Diffs
> -----
>
> ambari-server/docs/configuration/index.md 77d3a4d
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 9be8751
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandler.java 2f756fb
> ambari-server/src/main/java/org/apache/ambari/server/utils/ShellCommandUtil.java 99f47c5
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandlerTest.java 4c40a5d
> ambari-server/src/test/java/org/apache/ambari/server/utils/TestShellCommandUtil.java 34ac91f
>
> Diff: https://reviews.apache.org/r/54231/diff/
>
>
> Testing
> -------
>
> Manually tested
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 54231: Deployment failing at creating principal
[addendum]
Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54231/#review157489
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandler.java (line 476)
<https://reviews.apache.org/r/54231/#comment228093>
It appears we increased the timeout from 3 seconds to 30 seconds. Intentional?
- Sumit Mohanty
On Nov. 30, 2016, 10:04 p.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54231/
> -----------------------------------------------------------
>
> (Updated Nov. 30, 2016, 10:04 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley, Nate Cole, and Sumit Mohanty.
>
>
> Bugs: AMBARI-18755
> https://issues.apache.org/jira/browse/AMBARI-18755
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Cluster deployment via blueprint failed at creating principals
>
>
> Diffs
> -----
>
> ambari-server/docs/configuration/index.md 77d3a4d
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 9be8751
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandler.java 2f756fb
> ambari-server/src/main/java/org/apache/ambari/server/utils/ShellCommandUtil.java 99f47c5
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandlerTest.java 4c40a5d
> ambari-server/src/test/java/org/apache/ambari/server/utils/TestShellCommandUtil.java 34ac91f
>
> Diff: https://reviews.apache.org/r/54231/diff/
>
>
> Testing
> -------
>
> Manually tested
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 54231: Deployment failing at creating principal
[addendum]
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54231/
-----------------------------------------------------------
(Updated Nov. 30, 2016, 5:04 p.m.)
Review request for Ambari, Jonathan Hurley, Nate Cole, and Sumit Mohanty.
Changes
-------
Originally uploaded wrong patch... this is the correct patch.
Bugs: AMBARI-18755
https://issues.apache.org/jira/browse/AMBARI-18755
Repository: ambari
Description
-------
Cluster deployment via blueprint failed at creating principals
Diffs (updated)
-----
ambari-server/docs/configuration/index.md 77d3a4d
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 9be8751
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandler.java 2f756fb
ambari-server/src/main/java/org/apache/ambari/server/utils/ShellCommandUtil.java 99f47c5
ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandlerTest.java 4c40a5d
ambari-server/src/test/java/org/apache/ambari/server/utils/TestShellCommandUtil.java 34ac91f
Diff: https://reviews.apache.org/r/54231/diff/
Testing
-------
Manually tested
Thanks,
Robert Levas