You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/06/29 19:31:21 UTC
[GitHub] [airflow] maxcountryman opened a new pull request #16719: ensure task is skipped if missing sla
maxcountryman opened a new pull request #16719:
URL: https://github.com/apache/airflow/pull/16719
This protects against missing SLAs.
For instance, if a task does not have an SLA then it's possible this will result in an error like so:
TypeError: unsupported operand type(s) for +: 'DateTime' and 'NoneType'
File "airflow/jobs/scheduler_job.py", line 565, in execute_callbacks
self.manage_slas(dagbag.dags.get(request.dag_id))
File "airflow/utils/session.py", line 70, in wrapper
return func(*args, session=session, **kwargs)
File "airflow/jobs/scheduler_job.py", line 433, in manage_slas
if following_schedule + task.sla < timezone.utcnow():
Here we simply skip tasks which do not have SLAs and avoid raising the exception in subsequent logic.
Co-authored-by: Travis Jefferson <tr...@pathstream.com>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] maxcountryman commented on pull request #16719: ensure task is skipped if missing sla
Posted by GitBox <gi...@apache.org>.
maxcountryman commented on pull request #16719:
URL: https://github.com/apache/airflow/pull/16719#issuecomment-871599777
@potiuk static analysis appears to be passing now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #16719: ensure task is skipped if missing sla
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #16719:
URL: https://github.com/apache/airflow/pull/16719
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #16719: ensure task is skipped if missing sla
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #16719:
URL: https://github.com/apache/airflow/pull/16719#issuecomment-872231261
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #16719: ensure task is skipped if missing sla
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #16719:
URL: https://github.com/apache/airflow/pull/16719#issuecomment-872231087
The other errors have been either (hopefully) fixed (timeout on helm) or are random errors. Merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #16719: ensure task is skipped if missing sla
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #16719:
URL: https://github.com/apache/airflow/pull/16719#issuecomment-870965285
Some static checks failing (I recommend installing pre-commit to auto-fix them)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org