You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/12/21 07:40:30 UTC

[GitHub] suez1224 commented on a change in pull request #7078: [FLINK-10848][YARN] properly remove YARN ContainerRequest upon container allocation success

suez1224 commented on a change in pull request #7078: [FLINK-10848][YARN] properly remove YARN ContainerRequest upon container allocation success
URL: https://github.com/apache/flink/pull/7078#discussion_r243507859
 
 

 ##########
 File path: flink-yarn/src/main/java/org/apache/flink/yarn/YarnFlinkResourceManager.java
 ##########
 @@ -438,6 +438,8 @@ private void containersAllocated(List<Container> containers) {
 			numPendingContainerRequests = Math.max(0, numPendingContainerRequests - 1);
 			LOG.info("Received new container: {} - Remaining pending container requests: {}",
 				container.getId(), numPendingContainerRequests);
+			resourceManagerClient.removeContainerRequest(new AMRMClient.ContainerRequest(
 
 Review comment:
   getMatchingRequests only filter on priority, resourceName, capability. However, ContainerRequest also contains racks, nodes information.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services