You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Xing Shi (JIRA)" <ji...@apache.org> on 2012/06/20 17:17:42 UTC
[jira] [Created] (HBASE-6244) Restful get and scan don't need to
add column
Xing Shi created HBASE-6244:
-------------------------------
Summary: Restful get and scan don't need to add column
Key: HBASE-6244
URL: https://issues.apache.org/jira/browse/HBASE-6244
Project: HBase
Issue Type: Improvement
Components: rest
Reporter: Xing Shi
Priority: Minor
Now, the RowResultGenerator and the ScanerResultGenerator will fit the column family if the request doesn't contain any column info.
{code}
if (rowspec.hasColumns()) {
//addColumn for get or scan
} else {
for (HColumnDescriptor family:
table.getTableDescriptor().getFamilies()) {
scan/get.addFamily(family.getName());
}
}
{code}
The table.getTableDescriptor() will cost 10+ milliseconds in our hbase cluster each request. We can remove these code because the server will auto add the columns.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (HBASE-6244) [REST] Result generators do
not need to query table schema
Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13397877#comment-13397877 ]
Andrew Purtell edited comment on HBASE-6244 at 6/20/12 9:17 PM:
----------------------------------------------------------------
Committed trivial patch to trunk, 0.94, and 0.92 branches. All unit tests pass locally for trunk. All REST unit tests pass locally for 0.94.
Many thanks for pointing out this issue, Xing!
Edit: ... and REST tests pass for 0.92.
was (Author: apurtell):
Committed trivial patch to trunk, 0.94, and 0.92 branches. All unit tests pass locally for trunk. All REST unit tests pass locally for 0.94.
Many thanks for pointing out this issue, Xing!
> [REST] Result generators do not need to query table schema
> ----------------------------------------------------------
>
> Key: HBASE-6244
> URL: https://issues.apache.org/jira/browse/HBASE-6244
> Project: HBase
> Issue Type: Improvement
> Components: rest
> Affects Versions: 0.92.2, 0.96.0, 0.94.1
> Reporter: Xing Shi
> Assignee: Andrew Purtell
> Priority: Minor
> Fix For: 0.92.2, 0.96.0, 0.94.1
>
> Attachments: 6244-0.94.patch, 6244.patch
>
>
> Now, the RowResultGenerator and the ScanerResultGenerator will fit the column family if the request doesn't contain any column info.
> {code}
> if (rowspec.hasColumns()) {
> //addColumn for get or scan
> } else {
> for (HColumnDescriptor family:
> table.getTableDescriptor().getFamilies()) {
> scan/get.addFamily(family.getName());
> }
> }
> {code}
> The table.getTableDescriptor() will cost 10+ milliseconds in our hbase cluster each request. We can remove these code because the server will auto add the columns.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6244) [REST] Result generators do not
need to query table schema
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13398013#comment-13398013 ]
Hudson commented on HBASE-6244:
-------------------------------
Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #61 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/61/])
HBASE-6244. [REST] Result generators do not need to query table schema (Revision 1352325)
Result = FAILURE
apurtell :
Files :
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/RowResultGenerator.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/ScannerResultGenerator.java
> [REST] Result generators do not need to query table schema
> ----------------------------------------------------------
>
> Key: HBASE-6244
> URL: https://issues.apache.org/jira/browse/HBASE-6244
> Project: HBase
> Issue Type: Improvement
> Components: rest
> Affects Versions: 0.92.2, 0.96.0, 0.94.1
> Reporter: Xing Shi
> Assignee: Andrew Purtell
> Priority: Minor
> Fix For: 0.92.2, 0.96.0, 0.94.1
>
> Attachments: 6244-0.94.patch, 6244.patch
>
>
> Now, the RowResultGenerator and the ScanerResultGenerator will fit the column family if the request doesn't contain any column info.
> {code}
> if (rowspec.hasColumns()) {
> //addColumn for get or scan
> } else {
> for (HColumnDescriptor family:
> table.getTableDescriptor().getFamilies()) {
> scan/get.addFamily(family.getName());
> }
> }
> {code}
> The table.getTableDescriptor() will cost 10+ milliseconds in our hbase cluster each request. We can remove these code because the server will auto add the columns.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (HBASE-6244) [REST] Result generators do not need
to query table schema
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Hofhansl closed HBASE-6244.
--------------------------------
> [REST] Result generators do not need to query table schema
> ----------------------------------------------------------
>
> Key: HBASE-6244
> URL: https://issues.apache.org/jira/browse/HBASE-6244
> Project: HBase
> Issue Type: Improvement
> Components: REST
> Affects Versions: 0.92.2, 0.94.1, 0.96.0
> Reporter: ShiXing
> Assignee: Andrew Purtell
> Priority: Minor
> Fix For: 0.92.2, 0.94.1, 0.96.0
>
> Attachments: 6244-0.94.patch, 6244.patch
>
>
> Now, the RowResultGenerator and the ScanerResultGenerator will fit the column family if the request doesn't contain any column info.
> {code}
> if (rowspec.hasColumns()) {
> //addColumn for get or scan
> } else {
> for (HColumnDescriptor family:
> table.getTableDescriptor().getFamilies()) {
> scan/get.addFamily(family.getName());
> }
> }
> {code}
> The table.getTableDescriptor() will cost 10+ milliseconds in our hbase cluster each request. We can remove these code because the server will auto add the columns.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6244) Restful get and scan don't need to
add columns if no column specified
Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Purtell updated HBASE-6244:
----------------------------------
Attachment: 6244-0.94.patch
6244.patch
> Restful get and scan don't need to add columns if no column specified
> ---------------------------------------------------------------------
>
> Key: HBASE-6244
> URL: https://issues.apache.org/jira/browse/HBASE-6244
> Project: HBase
> Issue Type: Improvement
> Components: rest
> Affects Versions: 0.92.2, 0.96.0, 0.94.1
> Reporter: Xing Shi
> Priority: Minor
> Attachments: 6244-0.94.patch, 6244.patch
>
>
> Now, the RowResultGenerator and the ScanerResultGenerator will fit the column family if the request doesn't contain any column info.
> {code}
> if (rowspec.hasColumns()) {
> //addColumn for get or scan
> } else {
> for (HColumnDescriptor family:
> table.getTableDescriptor().getFamilies()) {
> scan/get.addFamily(family.getName());
> }
> }
> {code}
> The table.getTableDescriptor() will cost 10+ milliseconds in our hbase cluster each request. We can remove these code because the server will auto add the columns.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6244) [REST] Result generators do not
need to query table schema
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13397944#comment-13397944 ]
Hudson commented on HBASE-6244:
-------------------------------
Integrated in HBase-0.94 #265 (See [https://builds.apache.org/job/HBase-0.94/265/])
HBASE-6244. [REST] Result generators do not need to query table schema (Revision 1352326)
Result = FAILURE
apurtell :
Files :
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/rest/RowResultGenerator.java
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/rest/ScannerResultGenerator.java
> [REST] Result generators do not need to query table schema
> ----------------------------------------------------------
>
> Key: HBASE-6244
> URL: https://issues.apache.org/jira/browse/HBASE-6244
> Project: HBase
> Issue Type: Improvement
> Components: rest
> Affects Versions: 0.92.2, 0.96.0, 0.94.1
> Reporter: Xing Shi
> Assignee: Andrew Purtell
> Priority: Minor
> Fix For: 0.92.2, 0.96.0, 0.94.1
>
> Attachments: 6244-0.94.patch, 6244.patch
>
>
> Now, the RowResultGenerator and the ScanerResultGenerator will fit the column family if the request doesn't contain any column info.
> {code}
> if (rowspec.hasColumns()) {
> //addColumn for get or scan
> } else {
> for (HColumnDescriptor family:
> table.getTableDescriptor().getFamilies()) {
> scan/get.addFamily(family.getName());
> }
> }
> {code}
> The table.getTableDescriptor() will cost 10+ milliseconds in our hbase cluster each request. We can remove these code because the server will auto add the columns.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6244) [REST] Result generators do not
need to query table schema
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13397991#comment-13397991 ]
Hudson commented on HBASE-6244:
-------------------------------
Integrated in HBase-0.92 #455 (See [https://builds.apache.org/job/HBase-0.92/455/])
HBASE-6244. [REST] Result generators do not need to query table schema (Revision 1352327)
Result = SUCCESS
apurtell :
Files :
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/rest/RowResultGenerator.java
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/rest/ScannerResultGenerator.java
> [REST] Result generators do not need to query table schema
> ----------------------------------------------------------
>
> Key: HBASE-6244
> URL: https://issues.apache.org/jira/browse/HBASE-6244
> Project: HBase
> Issue Type: Improvement
> Components: rest
> Affects Versions: 0.92.2, 0.96.0, 0.94.1
> Reporter: Xing Shi
> Assignee: Andrew Purtell
> Priority: Minor
> Fix For: 0.92.2, 0.96.0, 0.94.1
>
> Attachments: 6244-0.94.patch, 6244.patch
>
>
> Now, the RowResultGenerator and the ScanerResultGenerator will fit the column family if the request doesn't contain any column info.
> {code}
> if (rowspec.hasColumns()) {
> //addColumn for get or scan
> } else {
> for (HColumnDescriptor family:
> table.getTableDescriptor().getFamilies()) {
> scan/get.addFamily(family.getName());
> }
> }
> {code}
> The table.getTableDescriptor() will cost 10+ milliseconds in our hbase cluster each request. We can remove these code because the server will auto add the columns.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HBASE-6244) [REST] Result generators do not need
to query table schema
Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Purtell resolved HBASE-6244.
-----------------------------------
Resolution: Fixed
Fix Version/s: 0.94.1
0.96.0
0.92.2
Committed trivial patch to trunk, 0.94, and 0.92 branches. All unit tests pass locally for trunk. All REST unit tests pass locally for 0.94.
Many thanks for pointing out this issue, Xing!
> [REST] Result generators do not need to query table schema
> ----------------------------------------------------------
>
> Key: HBASE-6244
> URL: https://issues.apache.org/jira/browse/HBASE-6244
> Project: HBase
> Issue Type: Improvement
> Components: rest
> Affects Versions: 0.92.2, 0.96.0, 0.94.1
> Reporter: Xing Shi
> Assignee: Andrew Purtell
> Priority: Minor
> Fix For: 0.92.2, 0.96.0, 0.94.1
>
> Attachments: 6244-0.94.patch, 6244.patch
>
>
> Now, the RowResultGenerator and the ScanerResultGenerator will fit the column family if the request doesn't contain any column info.
> {code}
> if (rowspec.hasColumns()) {
> //addColumn for get or scan
> } else {
> for (HColumnDescriptor family:
> table.getTableDescriptor().getFamilies()) {
> scan/get.addFamily(family.getName());
> }
> }
> {code}
> The table.getTableDescriptor() will cost 10+ milliseconds in our hbase cluster each request. We can remove these code because the server will auto add the columns.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6244) [REST] Result generators do not
need to query table schema
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13397966#comment-13397966 ]
Hudson commented on HBASE-6244:
-------------------------------
Integrated in HBase-TRUNK #3051 (See [https://builds.apache.org/job/HBase-TRUNK/3051/])
HBASE-6244. [REST] Result generators do not need to query table schema (Revision 1352325)
Result = FAILURE
apurtell :
Files :
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/RowResultGenerator.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/ScannerResultGenerator.java
> [REST] Result generators do not need to query table schema
> ----------------------------------------------------------
>
> Key: HBASE-6244
> URL: https://issues.apache.org/jira/browse/HBASE-6244
> Project: HBase
> Issue Type: Improvement
> Components: rest
> Affects Versions: 0.92.2, 0.96.0, 0.94.1
> Reporter: Xing Shi
> Assignee: Andrew Purtell
> Priority: Minor
> Fix For: 0.92.2, 0.96.0, 0.94.1
>
> Attachments: 6244-0.94.patch, 6244.patch
>
>
> Now, the RowResultGenerator and the ScanerResultGenerator will fit the column family if the request doesn't contain any column info.
> {code}
> if (rowspec.hasColumns()) {
> //addColumn for get or scan
> } else {
> for (HColumnDescriptor family:
> table.getTableDescriptor().getFamilies()) {
> scan/get.addFamily(family.getName());
> }
> }
> {code}
> The table.getTableDescriptor() will cost 10+ milliseconds in our hbase cluster each request. We can remove these code because the server will auto add the columns.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6244) [REST] Result generators do not
need to query table schema
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400020#comment-13400020 ]
Hudson commented on HBASE-6244:
-------------------------------
Integrated in HBase-0.94-security #37 (See [https://builds.apache.org/job/HBase-0.94-security/37/])
HBASE-6244. [REST] Result generators do not need to query table schema (Revision 1352326)
Result = SUCCESS
apurtell :
Files :
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/rest/RowResultGenerator.java
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/rest/ScannerResultGenerator.java
> [REST] Result generators do not need to query table schema
> ----------------------------------------------------------
>
> Key: HBASE-6244
> URL: https://issues.apache.org/jira/browse/HBASE-6244
> Project: HBase
> Issue Type: Improvement
> Components: rest
> Affects Versions: 0.92.2, 0.96.0, 0.94.1
> Reporter: Xing Shi
> Assignee: Andrew Purtell
> Priority: Minor
> Fix For: 0.92.2, 0.96.0, 0.94.1
>
> Attachments: 6244-0.94.patch, 6244.patch
>
>
> Now, the RowResultGenerator and the ScanerResultGenerator will fit the column family if the request doesn't contain any column info.
> {code}
> if (rowspec.hasColumns()) {
> //addColumn for get or scan
> } else {
> for (HColumnDescriptor family:
> table.getTableDescriptor().getFamilies()) {
> scan/get.addFamily(family.getName());
> }
> }
> {code}
> The table.getTableDescriptor() will cost 10+ milliseconds in our hbase cluster each request. We can remove these code because the server will auto add the columns.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6244) [REST] Result generators do not need
to query table schema
Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Purtell updated HBASE-6244:
----------------------------------
Affects Version/s: 0.94.1
0.96.0
0.92.2
Assignee: Andrew Purtell
Summary: [REST] Result generators do not need to query table schema (was: Restful get and scan don't need to add columns if no column specified)
> [REST] Result generators do not need to query table schema
> ----------------------------------------------------------
>
> Key: HBASE-6244
> URL: https://issues.apache.org/jira/browse/HBASE-6244
> Project: HBase
> Issue Type: Improvement
> Components: rest
> Affects Versions: 0.92.2, 0.96.0, 0.94.1
> Reporter: Xing Shi
> Assignee: Andrew Purtell
> Priority: Minor
> Attachments: 6244-0.94.patch, 6244.patch
>
>
> Now, the RowResultGenerator and the ScanerResultGenerator will fit the column family if the request doesn't contain any column info.
> {code}
> if (rowspec.hasColumns()) {
> //addColumn for get or scan
> } else {
> for (HColumnDescriptor family:
> table.getTableDescriptor().getFamilies()) {
> scan/get.addFamily(family.getName());
> }
> }
> {code}
> The table.getTableDescriptor() will cost 10+ milliseconds in our hbase cluster each request. We can remove these code because the server will auto add the columns.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6244) Restful get and scan don't need to
add columns if no column specified
Posted by "Xing Shi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Xing Shi updated HBASE-6244:
----------------------------
Summary: Restful get and scan don't need to add columns if no column specified (was: Restful get and scan don't need to add column)
> Restful get and scan don't need to add columns if no column specified
> ---------------------------------------------------------------------
>
> Key: HBASE-6244
> URL: https://issues.apache.org/jira/browse/HBASE-6244
> Project: HBase
> Issue Type: Improvement
> Components: rest
> Reporter: Xing Shi
> Priority: Minor
>
> Now, the RowResultGenerator and the ScanerResultGenerator will fit the column family if the request doesn't contain any column info.
> {code}
> if (rowspec.hasColumns()) {
> //addColumn for get or scan
> } else {
> for (HColumnDescriptor family:
> table.getTableDescriptor().getFamilies()) {
> scan/get.addFamily(family.getName());
> }
> }
> {code}
> The table.getTableDescriptor() will cost 10+ milliseconds in our hbase cluster each request. We can remove these code because the server will auto add the columns.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira