You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by aparnard <gi...@git.apache.org> on 2016/06/29 01:20:42 UTC
[GitHub] incubator-geode pull request #177: GEODE-11: Index and AEQ stored in the sam...
GitHub user aparnard opened a pull request:
https://github.com/apache/incubator-geode/pull/177
GEODE-11: Index and AEQ stored in the same disk store as the region
The index and AEQ were stored in the default disk store. Changed the code to set the RegionAtrributes of the index and AEQ to use the same Disk Store Name as the region. Added a test to verify the disk store name.
Signed-off-by: Dan Smith <ds...@pivotal.io>
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aparnard/incubator-geode feature/GEODE-11-UseRegionDiskStore
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-geode/pull/177.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #177
----
commit 64a9f1cca00a79da8a8514c8feb9f4a6f94e77d7
Author: Aparna Dharmakkan <ad...@pivotal.io>
Date: 2016-06-29T01:10:40Z
GEODE-11: Index and AEQ stored in the same disk store as the region
The index and AEQ were stored in the default disk store. Changed the code to set the RegionAtrributes of
the index and AEQ to use the same Disk Store Name as the region. Added a test to verify the disk store name.
Signed-off-by: Dan Smith <ds...@pivotal.io>
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode issue #177: GEODE-11: Index and AEQ stored in the same disk ...
Posted by gesterzhou <gi...@git.apache.org>.
Github user gesterzhou commented on the issue:
https://github.com/apache/incubator-geode/pull/177
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode issue #177: GEODE-11: Index and AEQ stored in the same disk ...
Posted by nabarunnag <gi...@git.apache.org>.
Github user nabarunnag commented on the issue:
https://github.com/apache/incubator-geode/pull/177
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode issue #177: GEODE-11: Index and AEQ stored in the same disk ...
Posted by upthewaterspout <gi...@git.apache.org>.
Github user upthewaterspout commented on the issue:
https://github.com/apache/incubator-geode/pull/177
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode pull request #177: GEODE-11: Index and AEQ stored in the sam...
Posted by nabarunnag <gi...@git.apache.org>.
Github user nabarunnag commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/177#discussion_r69231478
--- Diff: geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexForPartitionedRegion.java ---
@@ -77,13 +77,13 @@ public void initialize() {
final String fileRegionName = createFileRegionName();
PartitionAttributes partitionAttributes = dataRegion.getPartitionAttributes();
if (!fileRegionExists(fileRegionName)) {
- fileRegion = createFileRegion(regionShortCut, fileRegionName, partitionAttributes);
+ fileRegion = createFileRegion(regionShortCut, fileRegionName, partitionAttributes, ra);
--- End diff --
Its a nitpicky stuff but can we rename ra as regionAttributes. Just to keep things uniform... all other variables have full explanation names like regionShortcut, fileRegionName but just "ra" is the extra short one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode pull request #177: GEODE-11: Index and AEQ stored in the sam...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-geode/pull/177
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---