You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "jiangy (via GitHub)" <gi...@apache.org> on 2023/06/09 07:16:31 UTC
[GitHub] [dubbo-go] jiangy opened a new issue, #2335: MetricConfig 无法设置 Enable 为 false
jiangy opened a new issue, #2335:
URL: https://github.com/apache/dubbo-go/issues/2335
### Environment
<!--
- Server: Dubbo-go, v3.0.5
- Client: Dubbo-go, v3.0.5
- Protocol: Triple
- Registry: Nacos, v2.0.0
-->
- Server: Dubbo-go, v3.0.5
- Client:
- Protocol:
- Registry:
### Issue description
这个 Enable 的默认值处理有问题，如果设置为 false 的话会当作 0 值被 defaults 设置为默认值 true，也就是说用户永远无法设置 false
<!-- Here is a brief description about the issue. -->
### Logs
<details><summary>Click me to check logs</summary>
```
Copy logs to here.
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] ev1lQuark commented on issue #2335: MetricConfig 无法设置 Enable 为 false
Posted by "ev1lQuark (via GitHub)" <gi...@apache.org>.
ev1lQuark commented on issue #2335:
URL: https://github.com/apache/dubbo-go/issues/2335#issuecomment-1585448804
This [PR](https://github.com/apache/dubbo-go/pull/2336) resolve the bug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [I] MetricConfig 无法设置 Enable 为 false [dubbo-go]
Posted by "baerwang (via GitHub)" <gi...@apache.org>.
baerwang closed issue #2335: MetricConfig 无法设置 Enable 为 false
URL: https://github.com/apache/dubbo-go/issues/2335
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] justxuewei commented on issue #2335: MetricConfig 无法设置 Enable 为 false
Posted by "justxuewei (via GitHub)" <gi...@apache.org>.
justxuewei commented on issue #2335:
URL: https://github.com/apache/dubbo-go/issues/2335#issuecomment-1598916003
@ev1lQuark Please backport the bugfixes to the main branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] ev1lQuark commented on issue #2335: MetricConfig 无法设置 Enable 为 false
Posted by "ev1lQuark (via GitHub)" <gi...@apache.org>.
ev1lQuark commented on issue #2335:
URL: https://github.com/apache/dubbo-go/issues/2335#issuecomment-1584125563
Thank you, this is the [PR](https://github.com/apache/dubbo-go/pull/2310/files#diff-b302e39f38f857c8e3d9d38c2b7329c70ab2408d249f82987790af3dfd9cfd35) that fixes the bug. But it hasn't been released yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [I] MetricConfig 无法设置 Enable 为 false [dubbo-go]
Posted by "baerwang (via GitHub)" <gi...@apache.org>.
baerwang commented on issue #2335:
URL: https://github.com/apache/dubbo-go/issues/2335#issuecomment-1851555895
use v3.1.1-rc1 version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org