You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2022/05/16 22:35:58 UTC

[GitHub] [geode] jinmeiliao opened a new pull request, #7698: GEODE-10115: fix javadoc

jinmeiliao opened a new pull request, #7698:
URL: https://github.com/apache/geode/pull/7698

   simple javadoc fix


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [geode] jinmeiliao commented on pull request #7698: GEODE-10115: fix javadoc

Posted by GitBox <gi...@apache.org>.
jinmeiliao commented on PR #7698:
URL: https://github.com/apache/geode/pull/7698#issuecomment-1130448553

   > I'm not sure if the new javadoc validation/enforcement will pass on this. If it complains try adding `throws AuthenticationFailedException` to the method signature even if it's an unchecked type.
   
   It just doesn't make sense to throw that exception in the `init()` method, any runtime exception should work.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [geode] jinmeiliao merged pull request #7698: GEODE-10115: fix javadoc

Posted by GitBox <gi...@apache.org>.
jinmeiliao merged PR #7698:
URL: https://github.com/apache/geode/pull/7698


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org