You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@sling.apache.org by ol...@apache.org on 2022/05/20 13:10:45 UTC
[sling-org-apache-sling-clam] 03/05: fix warning for rule java:S2629
This is an automated email from the ASF dual-hosted git repository.
olli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/sling-org-apache-sling-clam.git
commit d89fa158b737a576143fb3edf43f4f4d8fe0227d
Author: Oliver Lietz <ol...@apache.org>
AuthorDate: Fri May 20 15:09:56 2022 +0200
fix warning for rule java:S2629
---
.../sling/clam/job/internal/JcrPropertyScanJobConsumer.java | 8 ++++++--
.../sling/clam/oak/internal/NodeObservingJcrPropertyDigger.java | 8 ++++++--
2 files changed, 12 insertions(+), 4 deletions(-)
diff --git a/src/main/java/org/apache/sling/clam/job/internal/JcrPropertyScanJobConsumer.java b/src/main/java/org/apache/sling/clam/job/internal/JcrPropertyScanJobConsumer.java
index ee10dde..1df0c34 100644
--- a/src/main/java/org/apache/sling/clam/job/internal/JcrPropertyScanJobConsumer.java
+++ b/src/main/java/org/apache/sling/clam/job/internal/JcrPropertyScanJobConsumer.java
@@ -128,13 +128,17 @@ public final class JcrPropertyScanJobConsumer implements JobConsumer {
final Value[] values = property.getValues();
final Value value = values[index];
try (InputStream inputStream = getInputStream(value)) {
- logger.debug("scanning property of type {} at {} [{}]", PropertyType.nameFromValue(propertyType), path, index);
+ if (logger.isDebugEnabled()) {
+ logger.debug("scanning property of type {} at {} [{}]", PropertyType.nameFromValue(propertyType), path, index);
+ }
final ScanResult scanResult = clamService.scan(inputStream);
invokeScanResultHandlers(scanResult, path, index, propertyType, userId);
}
} else { // single property value
try (InputStream inputStream = getInputStream(property.getValue())) {
- logger.debug("scanning property of type {} at {}", PropertyType.nameFromValue(propertyType), path);
+ if (logger.isDebugEnabled()) {
+ logger.debug("scanning property of type {} at {}", PropertyType.nameFromValue(propertyType), path);
+ }
final ScanResult scanResult = clamService.scan(inputStream);
invokeScanResultHandlers(scanResult, path, null, propertyType, userId);
}
diff --git a/src/main/java/org/apache/sling/clam/oak/internal/NodeObservingJcrPropertyDigger.java b/src/main/java/org/apache/sling/clam/oak/internal/NodeObservingJcrPropertyDigger.java
index 41f6ecb..b487302 100644
--- a/src/main/java/org/apache/sling/clam/oak/internal/NodeObservingJcrPropertyDigger.java
+++ b/src/main/java/org/apache/sling/clam/oak/internal/NodeObservingJcrPropertyDigger.java
@@ -164,10 +164,14 @@ public final class NodeObservingJcrPropertyDigger extends NodeObserver {
for (final String name : names) {
final String p = String.format("%s/%s", path, name);
if (pattern.matcher(p).matches()) {
- logger.debug("path '{}' matches pattern '{}'", p, pattern.pattern());
+ if (logger.isDebugEnabled()) {
+ logger.debug("path '{}' matches pattern '{}'", p, pattern.pattern());
+ }
paths.add(p);
} else {
- logger.debug("path '{}' doesn't match pattern '{}'", p, pattern.pattern());
+ if (logger.isDebugEnabled()) {
+ logger.debug("path '{}' doesn't match pattern '{}'", p, pattern.pattern());
+ }
}
}
return paths;