You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2026/09/17 20:57:28 UTC
[PR] Make WorkbookEvaluator.evaluateFormula(OperationEvaluationContext, Ptg[]) public [poi]
pjfanning opened a new pull request, #1273:
URL: https://github.com/apache/poi/pull/1273
`WorkbookEvaluator.evaluateFormula(OperationEvaluationContext, Ptg[])` is the low-level interpreter entry point: it evaluates parsed formula tokens without a formula cell, result cache or dependency tracking. It was package-private ("visibility raised for testing").
The rest of the evaluation SPI is already public — `EvaluationWorkbook`, `EvaluationSheet`, `EvaluationCell`, `FormulaParsingWorkbook`, `FormulaParser.parse(...)`, the `WorkbookEvaluator` and `OperationEvaluationContext` constructors — so this was the one missing hook for evaluating formulas against a custom in-memory `EvaluationWorkbook` without building a `Workbook`. That lets a "standalone formula engine" such as the one proposed in #1271 be built outside POI.
Kept `@Internal` to signal that it is a low-level hook, and added javadoc.
Extracted from #1271 (see discussion there).
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
Re: [PR] Make WorkbookEvaluator.evaluateFormula(OperationEvaluationContext, Ptg[]) public [poi]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #1273:
URL: https://github.com/apache/poi/pull/1273#issuecomment-5721348209
I reverted this because it seems quite incomplete.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
Re: [PR] Make WorkbookEvaluator.evaluateFormula(OperationEvaluationContext, Ptg[]) public [poi]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning merged PR #1273:
URL: https://github.com/apache/poi/pull/1273
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org