[GitHub] spark pull request: [SPARK-12044] [SparkR] Fix usage of isnan, isN...

[yanboliang <gi...@git.apache.org>]

Github user yanboliang commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10037#discussion_r46644003
  
    --- Diff: R/pkg/R/generics.R ---
    @@ -623,6 +623,10 @@ setGeneric("getItem", function(x, ...) { standardGeneric("getItem") })
     
     #' @rdname column
     #' @export
    +setGeneric("isNaN", function(x) { standardGeneric("isNaN") })
    --- End diff --
    
    ```isNull``` and ```isNotNull``` are still exported after this PR because they have been exist at Spark 1.5. ```isNull``` and ```isNotNull``` (with upper case) are functions of ```Column```, I consider  they are Spark specific functions so did not remove them. If we want to remove them, I can do it in a follow-up PR and they are breaking changes need to be explain in release note. @shivaram  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org