[GitHub] roadan commented on a change in pull request #6: Amaterasu 15

[GitBox <gi...@apache.org>]

roadan commented on a change in pull request #6: Amaterasu 15
URL: https://github.com/apache/incubator-amaterasu/pull/6#discussion_r167750250
 
 

 ##########
 File path: executor/src/main/scala/org/apache/amaterasu/executor/common/executors/ActiveNotifier.scala
 ##########
 @@ -0,0 +1,72 @@
+package org.apache.amaterasu.executor.common.executors
+
+import javax.jms.{DeliveryMode, MessageProducer, Session}
+
+
+import net.liftweb.json._
+import net.liftweb.json.Serialization.write
+import org.apache.activemq.ActiveMQConnectionFactory
+import org.apache.amaterasu.common.execution.actions.{Notification, NotificationLevel, NotificationType, Notifier}
+import org.apache.amaterasu.common.logging.Logging
+
+class ActiveNotifier extends Notifier with Logging {
 
 Review comment:
   Seems to belong to the Notification class rather the Notifier interface.
   Anyway I suggest this will be added as a new improvement card rather than change to AMATERASU-15

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services