You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by GitBox <gi...@apache.org> on 2022/06/12 13:10:31 UTC
[GitHub] [myfaces] melloware opened a new pull request, #271: MYFACE-4387: JSF to Faces in Javadoc
melloware opened a new pull request, #271:
URL: https://github.com/apache/myfaces/pull/271
@tandraschko this change is just Javadoc only i didn't touch any Java code or constants at all
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] melloware merged pull request #271: MYFACE-4387: JSF to Faces in Javadoc
Posted by GitBox <gi...@apache.org>.
melloware merged PR #271:
URL: https://github.com/apache/myfaces/pull/271
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] melloware commented on pull request #271: MYFACE-4387: JSF to Faces in Javadoc
Posted by GitBox <gi...@apache.org>.
melloware commented on PR #271:
URL: https://github.com/apache/myfaces/pull/271#issuecomment-1198010790
Thank you both changes made!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] melloware commented on pull request #271: MYFACE-4387: JSF to Faces in Javadoc
Posted by GitBox <gi...@apache.org>.
melloware commented on PR #271:
URL: https://github.com/apache/myfaces/pull/271#issuecomment-1227090416
Its good from mine end.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] tandraschko commented on pull request #271: MYFACE-4387: JSF to Faces in Javadoc
Posted by GitBox <gi...@apache.org>.
tandraschko commented on PR #271:
URL: https://github.com/apache/myfaces/pull/271#issuecomment-1226879284
Can we merge?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] lofwyr14 commented on a diff in pull request #271: MYFACE-4387: JSF to Faces in Javadoc
Posted by GitBox <gi...@apache.org>.
lofwyr14 commented on code in PR #271:
URL: https://github.com/apache/myfaces/pull/271#discussion_r931837138
##########
impl/src/main/java/org/apache/myfaces/view/facelets/tag/faces/html/DefaultTagDecorator.java:
##########
@@ -176,7 +176,7 @@ public Tag decorate(Tag tag)
return null;
}
- // One or many attributes has the JSF_NAMESPACE attribute set. Check empty or
+ // One or many attributes has the Faces_NAMESPACE attribute set. Check empty or
Review Comment:
Here JsfLibrary.NAMESPACE is correct. JSF_NAMESPACE was replaced.
##########
api/src/main/java/jakarta/faces/component/UIViewParameter.java:
##########
@@ -45,7 +45,7 @@
* TODO: documentation on jsp and pld are not the same. It appear two
* params: maxlength and for, but no property getter and setter founded here.
* If maxlength is used, we can put something like this:
- * JSFJspProperty(name = "maxlength", returnType = "java.lang.String")
Review Comment:
This is an annotation. AFAIK the class names will not be renamed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org