You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by GitBox <gi...@apache.org> on 2020/03/04 20:32:27 UTC

[GitHub] [samza] rmatharu commented on a change in pull request #1297: SAMZA-2379: Support Container Placements for job running in degraded state

rmatharu commented on a change in pull request #1297: SAMZA-2379: Support Container Placements for job running in degraded state 
URL: https://github.com/apache/samza/pull/1297#discussion_r387917740
 
 

 ##########
 File path: samza-core/src/test/java/org/apache/samza/clustermanager/MockClusterResourceManager.java
 ##########
 @@ -102,12 +102,17 @@ public void launchStreamProcessor(SamzaResource resource, CommandBuilder builder
 
   @Override
   public void stopStreamProcessor(SamzaResource resource) {
-    SamzaResourceStatus status = new SamzaResourceStatus(resource.getContainerId(), "diagnostics", SamzaResourceStatus.PREEMPTED);
+    stopStreamProcessor(resource, SamzaResourceStatus.PREEMPTED);
+  }
+
+  void stopStreamProcessor(SamzaResource resource, int exitCode) {
 
 Review comment:
   Is this required only for testing?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services