You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@thrift.apache.org by je...@apache.org on 2020/12/09 21:06:54 UTC

[thrift] branch master updated: THRIFT-5198 Fix certain Visual Studio hints in generated netstd code Client: netstd Patch: Jens Geyer

This is an automated email from the ASF dual-hosted git repository.

jensg pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/thrift.git


The following commit(s) were added to refs/heads/master by this push:
     new 494a845  THRIFT-5198 Fix certain Visual Studio hints in generated netstd code Client: netstd Patch: Jens Geyer
494a845 is described below

commit 494a845dd972fc0e68f6937e27ae74efd444b848
Author: Jens Geyer <je...@apache.org>
AuthorDate: Wed Dec 9 21:56:21 2020 +0100

    THRIFT-5198 Fix certain Visual Studio hints in generated netstd code
    Client: netstd
    Patch: Jens Geyer
---
 compiler/cpp/src/thrift/generate/t_netstd_generator.cc | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/compiler/cpp/src/thrift/generate/t_netstd_generator.cc b/compiler/cpp/src/thrift/generate/t_netstd_generator.cc
index ea47782..b90f71a 100644
--- a/compiler/cpp/src/thrift/generate/t_netstd_generator.cc
+++ b/compiler/cpp/src/thrift/generate/t_netstd_generator.cc
@@ -333,7 +333,10 @@ void t_netstd_generator::reset_indent() {
 
 void t_netstd_generator::start_netstd_namespace(ostream& out)
 {
-    out << "#pragma warning disable IDE1006  // parts of the code use IDL spelling" << endl;
+    out << "#pragma warning disable IDE0079  // remove unnecessary pragmas" << endl
+        << "#pragma warning disable IDE1006  // parts of the code use IDL spelling" << endl
+        << endl;
+
     if (!namespace_name_.empty())
     {
         out << "namespace " << namespace_name_ << endl;
@@ -347,7 +350,6 @@ void t_netstd_generator::end_netstd_namespace(ostream& out)
     {
         scope_down(out);
     }
-    out << "#pragma warning restore IDE1006" << endl;
 }
 
 string t_netstd_generator::netstd_type_usings() const