You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@skywalking.apache.org by 吴晟 Sheng Wu <wu...@foxmail.com> on 2018/08/29 13:58:59 UTC
[VOTE] Release Apache SkyWalking (incubating) version 5.0.0-RC
Hi All,
This is a call for vote to release Apache SkyWalking (Incubating) version 5.0.0-RC
Release notes:
* https://github.com/apache/incubator-skywalking/blob/master/CHANGES.md#500-rc
Release Candidate:
https://dist.apache.org/repos/dist/dev/incubator/skywalking/5.0.0-RC/
* sha512 checksums
- f3be05faa70e67f5d9a8ccaccda3fd9b7c2354ade39ead22f706c56379573afeae12ed048f20b6f0d010a721c2b606e460c5e1264ea620bbec4e62a72f67d367 apache-skywalking-apm-incubating-5.0.0-RC-src.tgz
- ea65b0f5b246254bc4fa0ce6e244e6c9aed751bd778a4c1c4a1e77e732a172fc829ca982e31f4412297a27064701ac4100620970b87f10355473a4e65460937f apache-skywalking-apm-incubating-5.0.0-RC.tar.gz
- b5ae9ff063d48adda44eafb47864af3f352665d74372120ea989163afc17db8c85747192ad3946ceaba82ab3287d07d37b147f302b3084fc08e6a4b476021fda apache-skywalking-apm-incubating-5.0.0-RC.zip
Maven 2 staging repository:
* https://repository.apache.org/content/repositories/orgapacheskywalking-1017/org/apache/skywalking/
Release Tag :
* (GitHub Tag) https://github.com/apache/incubator-skywalking/tree/v5.0.0-RC
Release CommitID :
* https://github.com/apache/incubator-skywalking/tree/52ac0628c96311ca0abbadd5dc8879e14168a1b3
* Git submodule
* skywalking-ui: https://github.com/apache/incubator-skywalking-ui/tree/ad3ee45dbadfae35d77238bdd7a1df593158f109
* apm-protocol/apm-network/src/main/proto: https://github.com/apache/incubator-skywalking-data-collect-protocol/tree/c02c12af12116121e25155d1f3fca0fadee5f2e9
Keys to verify the Release Candidate :
* https://dist.apache.org/repos/dist/release/incubator/skywalking/KEYS corresponding to wusheng@apache.org
Guide to build the release from source :
* https://github.com/apache/incubator-skywalking/blob/master/docs/en/How-to-build.md
Voting will start now (2018/8/29 date) and will remain open for at least 72 hours, Request all PPMC members to give their vote.
[ ] +1 Release this package.
[ ] +0 No opinion.
[ ] -1 Do not release this package because....
------------------
Sheng Wu
Apache SkyWalking
Re: [VOTE] Release Apache SkyWalking (incubating) version 5.0.0-RC
Posted by 吴晟 Sheng Wu <wu...@foxmail.com>.
Thanks very much for rechecking this. Now we can be sure, we are right.
Let me do the release again, and start a new vote. :)
I think this vote thread should stay in closed, the repo and tag have been released, source codes have been updated.
------------------
Sheng Wu
Apache SkyWalking
------------------ Original ------------------
From: "mck"<mc...@semb.wever.org>;
Date: Fri, Aug 31, 2018 08:51 PM
To: "dev"<de...@skywalking.apache.org>;
Subject: Re: [VOTE] Release Apache SkyWalking (incubating) version 5.0.0-RC
> And I read the pom release announcement[4] again, they said
> > It includes generating sha512 checksums for the source-release (not the
> artifacts going to maven central where sha1 and md5 are pretty built-in).
>
>
> I am not 100% sure about the meanings, but look like maven central
> requires sha1 and m5.
You are correct Sheng, my bad.
The release doc says
"For every artifact distributed to the public through Apache channels"
and that threw me.
But indeed maven does not yet support sha256 or sha512 checksums, and even if you do upload them will treat them incorrectly as separate artefacts in the repository. This is described a bit more in https://issues.apache.org/jira/browse/MPOM-205
I'm +1 on the release now.
regards,
Mick
Re: [VOTE] Release Apache SkyWalking (incubating) version 5.0.0-RC
Posted by mck <mc...@semb.wever.org>.
> And I read the pom release announcement[4] again, they said
> > It includes generating sha512 checksums for the source-release (not the
> artifacts going to maven central where sha1 and md5 are pretty built-in).
>
>
> I am not 100% sure about the meanings, but look like maven central
> requires sha1 and m5.
You are correct Sheng, my bad.
The release doc says
"For every artifact distributed to the public through Apache channels"
and that threw me.
But indeed maven does not yet support sha256 or sha512 checksums, and even if you do upload them will treat them incorrectly as separate artefacts in the repository. This is described a bit more in https://issues.apache.org/jira/browse/MPOM-205
I'm +1 on the release now.
regards,
Mick
Re: [VOTE] Release Apache SkyWalking (incubating) version 5.0.0-RC
Posted by 吴晟 Sheng Wu <wu...@foxmail.com>.
Hi Mick
I already closed the vote mail, because try apache 21 pom makes me have to delete existed tag, which may cause unknown issues about checked.
But after I upgraded the pom to 21[1], and did a release again[2]. Still no sha512 found in staging repo, such as our distribution package[3].
I think they haven't provided a way to do this.
And I read the pom release announcement[4] again, they said
> It includes generating sha512 checksums for the source-release (not the
artifacts going to maven central where sha1 and md5 are pretty built-in).
I am not 100% sure about the meanings, but look like maven central requires sha1 and m5.
So, any one have more opinions about this? Do I need to start a new vote?(Keep no sha512 in nexus repo)
[1] https://repository.apache.org/content/repositories/orgapacheskywalking-1018/org/apache/skywalking/apm/5.0.0-RC/apm-5.0.0-RC.pom
[2] https://repository.apache.org/content/repositories/orgapacheskywalking-1018
[3] https://repository.apache.org/content/repositories/orgapacheskywalking-1018/org/apache/skywalking/apache-skywalking-apm-incubating/5.0.0-RC/
[4] https://lists.apache.org/thread.html/ab0838d16033a54e039cf3dbe3344c7e63b340f0dbc14ad14211ff1d@%3Cannounce.maven.apache.org%3E
------------------
Sheng Wu
Apache SkyWalking
------------------ Original ------------------
From: "mck"<mc...@apache.org>;
Date: Fri, Aug 31, 2018 09:35 AM
To: "dev"<de...@skywalking.apache.org>;
Subject: Re: [VOTE] Release Apache SkyWalking (incubating) version 5.0.0-RC
> Voting will start now (2018/8/29 date) and will remain open for at least
> 72 hours, Request all PPMC members to give their vote.
> [ ] +1 Release this package.
> [ ] +0 No opinion.
> [ ] -1 Do not release this package because....
-1 The digests on the maven artefacts don't meet the new ASF release requirements.
The distribution artefacts are good, only asc signatures and sha512 digests, as seen in
https://dist.apache.org/repos/dist/dev/incubator/skywalking/5.0.0-RC/
But the artefacts in the maven staging repository don't have sha512 digests, and have the now forbidden md5 and sha1 digests.
As seen in
https://repository.apache.org/content/repositories/orgapacheskywalking-1017/org/apache/skywalking/agent-grpc-provider/5.0.0-RC/
The relevant ASF documentation is in
https://www.apache.org/dev/release-distribution#sigs-and-sums
specifically…
> For every artifact distributed to the public through Apache channels, the PMC
>
> - MUST supply a valid OpenPGP-compatible ASCII-armored detached signature file
> - MUST supply at least one checksum file
> - SHOULD supply a SHA-256 and/or SHA-512 checksum file
> - SHOULD NOT supply a MD5 or SHA-1 checksum file (because these are deprecated)
>
> For new releases, PMCs MUST supply SHA-256 and/or SHA-512; and SHOULD NOT supply MD5 or SHA-1. Existing releases do not need to be changed.
Upgrading to apache pom 21 should fix this.
https://lists.apache.org/thread.html/ab0838d16033a54e039cf3dbe3344c7e63b340f0dbc14ad14211ff1d@%3Cannounce.maven.apache.org%3E
regards,
Mick
[Cancel][VOTE] Release Apache SkyWalking (incubating) version 5.0.0-RC
Posted by 吴晟 Sheng Wu <wu...@foxmail.com>.
Thanks do much, Mick.
I will do a quick update and release again soon.
Now vote is closing.
Sheng Wu
Apache SkyWalking
From Wu Sheng 's phone.
------------------ Original ------------------
From: Mick Semb Wever <mc...@apache.org>
Date: Fri,Aug 31,2018 9:35 AM
To: dev <de...@skywalking.apache.org>
Subject: Re: [VOTE] Release Apache SkyWalking (incubating) version 5.0.0-RC
> Voting will start now (2018/8/29 date) and will remain open for at least
> 72 hours, Request all PPMC members to give their vote.
> [ ] +1 Release this package.
> [ ] +0 No opinion.
> [ ] -1 Do not release this package because....
-1 The digests on the maven artefacts don't meet the new ASF release requirements.
The distribution artefacts are good, only asc signatures and sha512 digests, as seen in
https://dist.apache.org/repos/dist/dev/incubator/skywalking/5.0.0-RC/
But the artefacts in the maven staging repository don't have sha512 digests, and have the now forbidden md5 and sha1 digests.
As seen in
https://repository.apache.org/content/repositories/orgapacheskywalking-1017/org/apache/skywalking/agent-grpc-provider/5.0.0-RC/
The relevant ASF documentation is in
https://www.apache.org/dev/release-distribution#sigs-and-sums
specifically…
> For every artifact distributed to the public through Apache channels, the PMC
>
> - MUST supply a valid OpenPGP-compatible ASCII-armored detached signature file
> - MUST supply at least one checksum file
> - SHOULD supply a SHA-256 and/or SHA-512 checksum file
> - SHOULD NOT supply a MD5 or SHA-1 checksum file (because these are deprecated)
>
> For new releases, PMCs MUST supply SHA-256 and/or SHA-512; and SHOULD NOT supply MD5 or SHA-1. Existing releases do not need to be changed.
Upgrading to apache pom 21 should fix this.
https://lists.apache.org/thread.html/ab0838d16033a54e039cf3dbe3344c7e63b340f0dbc14ad14211ff1d@%3Cannounce.maven.apache.org%3E
regards,
Mick
Re: [VOTE] Release Apache SkyWalking (incubating) version 5.0.0-RC
Posted by Mick Semb Wever <mc...@apache.org>.
> Voting will start now (2018/8/29 date) and will remain open for at least
> 72 hours, Request all PPMC members to give their vote.
> [ ] +1 Release this package.
> [ ] +0 No opinion.
> [ ] -1 Do not release this package because....
-1 The digests on the maven artefacts don't meet the new ASF release requirements.
The distribution artefacts are good, only asc signatures and sha512 digests, as seen in
https://dist.apache.org/repos/dist/dev/incubator/skywalking/5.0.0-RC/
But the artefacts in the maven staging repository don't have sha512 digests, and have the now forbidden md5 and sha1 digests.
As seen in
https://repository.apache.org/content/repositories/orgapacheskywalking-1017/org/apache/skywalking/agent-grpc-provider/5.0.0-RC/
The relevant ASF documentation is in
https://www.apache.org/dev/release-distribution#sigs-and-sums
specifically…
> For every artifact distributed to the public through Apache channels, the PMC
>
> - MUST supply a valid OpenPGP-compatible ASCII-armored detached signature file
> - MUST supply at least one checksum file
> - SHOULD supply a SHA-256 and/or SHA-512 checksum file
> - SHOULD NOT supply a MD5 or SHA-1 checksum file (because these are deprecated)
>
> For new releases, PMCs MUST supply SHA-256 and/or SHA-512; and SHOULD NOT supply MD5 or SHA-1. Existing releases do not need to be changed.
Upgrading to apache pom 21 should fix this.
https://lists.apache.org/thread.html/ab0838d16033a54e039cf3dbe3344c7e63b340f0dbc14ad14211ff1d@%3Cannounce.maven.apache.org%3E
regards,
Mick
Re: [VOTE] Release Apache SkyWalking (incubating) version 5.0.0-RC
Posted by xin zhang <nz...@gmail.com>.
Hi all:
+1 (binding)
Here is my check stuff:
1. all artifacts in staging repository are published with .asc, .md5 files
2. source code and distribution package are in https://dist.apache.prg/repos/dist/dev/incubator/skywalking
3. source code build successfully
4. LICENSE and NOTICE are in source code and distribution package
5. check .md5 and .sha512
6. DISCLAIMER existed
7. Apache RAT checked
Regards
Xin
> On Aug 29, 2018, at 21:58, 吴晟 Sheng Wu <wu...@foxmail.com> wrote:
>
> Hi All,
> This is a call for vote to release Apache SkyWalking (Incubating) version 5.0.0-RC
>
>
>
> Release notes:
>
>
> * https://github.com/apache/incubator-skywalking/blob/master/CHANGES.md#500-rc
>
>
> Release Candidate:
>
>
> https://dist.apache.org/repos/dist/dev/incubator/skywalking/5.0.0-RC/
>
> * sha512 checksums
> - f3be05faa70e67f5d9a8ccaccda3fd9b7c2354ade39ead22f706c56379573afeae12ed048f20b6f0d010a721c2b606e460c5e1264ea620bbec4e62a72f67d367 apache-skywalking-apm-incubating-5.0.0-RC-src.tgz
> - ea65b0f5b246254bc4fa0ce6e244e6c9aed751bd778a4c1c4a1e77e732a172fc829ca982e31f4412297a27064701ac4100620970b87f10355473a4e65460937f apache-skywalking-apm-incubating-5.0.0-RC.tar.gz
> - b5ae9ff063d48adda44eafb47864af3f352665d74372120ea989163afc17db8c85747192ad3946ceaba82ab3287d07d37b147f302b3084fc08e6a4b476021fda apache-skywalking-apm-incubating-5.0.0-RC.zip
>
>
> Maven 2 staging repository:
>
>
> * https://repository.apache.org/content/repositories/orgapacheskywalking-1017/org/apache/skywalking/
>
>
> Release Tag :
>
>
> * (GitHub Tag) https://github.com/apache/incubator-skywalking/tree/v5.0.0-RC
>
>
> Release CommitID :
>
>
> * https://github.com/apache/incubator-skywalking/tree/52ac0628c96311ca0abbadd5dc8879e14168a1b3
> * Git submodule
> * skywalking-ui: https://github.com/apache/incubator-skywalking-ui/tree/ad3ee45dbadfae35d77238bdd7a1df593158f109
> * apm-protocol/apm-network/src/main/proto: https://github.com/apache/incubator-skywalking-data-collect-protocol/tree/c02c12af12116121e25155d1f3fca0fadee5f2e9
>
>
> Keys to verify the Release Candidate :
>
>
> * https://dist.apache.org/repos/dist/release/incubator/skywalking/KEYS corresponding to wusheng@apache.org
>
>
> Guide to build the release from source :
>
>
> * https://github.com/apache/incubator-skywalking/blob/master/docs/en/How-to-build.md
>
>
> Voting will start now (2018/8/29 date) and will remain open for at least 72 hours, Request all PPMC members to give their vote.
> [ ] +1 Release this package.
> [ ] +0 No opinion.
> [ ] -1 Do not release this package because....
>
>
>
>
>
> ------------------
> Sheng Wu
> Apache SkyWalking