You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/02/05 00:33:58 UTC
[GitHub] [iceberg] aokolnychyi opened a new pull request #4044: Spark 3.2: Rename variables referring to RowLevelOperationTable
aokolnychyi opened a new pull request #4044:
URL: https://github.com/apache/iceberg/pull/4044
As mentioned [here](https://github.com/apache/iceberg/pull/3984/files#r798156043), certain `RowLevelOperationTable` usages are a bit confusing. This PR attempts to rename some vars to avoid the ambiguity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #4044: Spark 3.2: Rename variables referring to RowLevelOperationTable
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #4044:
URL: https://github.com/apache/iceberg/pull/4044#issuecomment-1030887468
Looks great. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue merged pull request #4044: Spark 3.2: Rename variables referring to RowLevelOperationTable
Posted by GitBox <gi...@apache.org>.
rdblue merged pull request #4044:
URL: https://github.com/apache/iceberg/pull/4044
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] aokolnychyi commented on a change in pull request #4044: Spark 3.2: Rename variables referring to RowLevelOperationTable
Posted by GitBox <gi...@apache.org>.
aokolnychyi commented on a change in pull request #4044:
URL: https://github.com/apache/iceberg/pull/4044#discussion_r799908040
##########
File path: spark/v3.2/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/RewriteDeleteFromTable.scala
##########
@@ -87,22 +87,22 @@ object RewriteDeleteFromTable extends RewriteRowLevelCommand {
val remainingRowsPlan = Filter(remainingRowsFilter, readRelation)
// build a plan to replace read groups in the table
- val writeRelation = relation.copy(table = table)
+ val writeRelation = relation.copy(table = operationTable)
Review comment:
@szehon-ho @rdblue, could you let me know if this is any better? I did not want to make the var name too long to stay within the line limit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org