You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2018/08/26 21:07:40 UTC
[GitHub] junichi11 commented on a change in pull request #793:
[NETBEANS-1190] Add more icon sizes to NetBeans' MainWindow
junichi11 commented on a change in pull request #793: [NETBEANS-1190] Add more icon sizes to NetBeans' MainWindow
URL: https://github.com/apache/incubator-netbeans/pull/793#discussion_r212839004
##########
File path: platform/core.windows/src/org/netbeans/core/windows/view/ui/MainWindow.java
##########
@@ -504,14 +504,20 @@ private static Border getDesktopBorder () {
private static final String ICON_16 = "org/netbeans/core/startup/frame.gif"; // NOI18N
private static final String ICON_32 = "org/netbeans/core/startup/frame32.gif"; // NOI18N
private static final String ICON_48 = "org/netbeans/core/startup/frame48.gif"; // NOI18N
+ private static final String ICON_256 = "org/netbeans/core/startup/frame256.png"; // NOI18N
+ private static final String ICON_512 = "org/netbeans/core/startup/frame512.png"; // NOI18N
+ private static final String ICON_1024 = "org/netbeans/core/startup/frame1024.png"; // NOI18N
static void initFrameIcons(Frame f) {
List<Image> currentIcons = f.getIconImages();
if( !currentIcons.isEmpty() )
return; //do not override icons if they have been already provided elsewhere (JDev)
f.setIconImages(Arrays.asList(
ImageUtilities.loadImage(ICON_16, true),
ImageUtilities.loadImage(ICON_32, true),
- ImageUtilities.loadImage(ICON_48, true)));
+ ImageUtilities.loadImage(ICON_48, true),
+ ImageUtilities.loadImage(ICON_256, true),
+ ImageUtilities.loadImage(ICON_512, true),
+ ImageUtilities.loadImage(ICON_1024, true)));
Review comment:
Wrong indentation spaces?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists