[jira] [Commented] (CASSANDRA-4049) Add generic way of adding SSTable components required custom compaction strategy

["Jonathan Ellis (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-4049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13244584#comment-13244584 ] 

Jonathan Ellis commented on CASSANDRA-4049:
-------------------------------------------

I'm a little nervous about this.  Having descriptors know about only some components feels fragile and likely to cause bugs at some point.

What if we added Custom1..Custom5 Type entries so that we're not just ignoring them?
                
> Add generic way of adding SSTable components required custom compaction strategy
> --------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-4049
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4049
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Core
>            Reporter: Piotr Kołaczkowski
>            Priority: Minor
>             Fix For: 1.0.10
>
>         Attachments: compaction_strategy_cleanup.patch, component_patch.diff
>
>
> CFS compaction strategy coming up in the next DSE release needs to store some important information in Tombstones.db and RemovedKeys.db files, one per sstable. However, currently Cassandra issues warnings when these files are found in the data directory. Additionally, when switched to SizeTieredCompactionStrategy, the files are left in the data directory after compaction.
> The attached patch adds new components to the Component class so Cassandra knows about those files.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira