svn commit: r1664674 - /subversion/trunk/subversion/tests/libsvn_ra/ra-test.c

[rh...@apache.org]

Author: rhuijben
Date: Fri Mar  6 16:17:04 2015
New Revision: 1664674

URL: http://svn.apache.org/r1664674
Log:
* subversion/tests/libsvn_ra/ra-test.c
  (base_revision_above_youngest): Following up on r1664672, add some comments.

Modified:
    subversion/trunk/subversion/tests/libsvn_ra/ra-test.c

Modified: subversion/trunk/subversion/tests/libsvn_ra/ra-test.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/tests/libsvn_ra/ra-test.c?rev=1664674&r1=1664673&r2=1664674&view=diff
==============================================================================
--- subversion/trunk/subversion/tests/libsvn_ra/ra-test.c (original)
+++ subversion/trunk/subversion/tests/libsvn_ra/ra-test.c Fri Mar  6 16:17:04 2015
@@ -673,21 +673,31 @@ base_revision_above_youngest(const svn_t
   void *edit_baton;
   void *root_baton;
   svn_error_t *err;
-  SVN_ERR(make_and_open_repos(&ra_session, "base_revision_above_youngest", opts, pool));
+  SVN_ERR(make_and_open_repos(&ra_session, "base_revision_above_youngest",
+                              opts, pool));
 
   SVN_ERR(svn_ra_get_commit_editor3(ra_session, &editor, &edit_baton,
                                     apr_hash_make(pool), NULL,
                                     NULL, NULL, FALSE, pool));
 
+  /* r1 doesn't exist, but we say we want to apply changes against this
+     revision to see how the ra layers behave.
+
+     Some will see an error directly on open_root, others in a later
+     state. */
+
+  /* ra-local and http pre-v2 will see the error here */
   err = editor->open_root(edit_baton, 1, pool, &root_baton);
 
   if (!err)
     err = editor->change_dir_prop(root_baton, "A",
                                   svn_string_create("B", pool), pool);
 
+  /* http v2 will notice it here (PROPPATCH) */
   if (!err)
     err = editor->close_directory(root_baton, pool);
 
+  /* ra svn only notes it at some later point. Typically here */
   if (!err)
     err = editor->close_edit(edit_baton, pool);