[GitHub] [iceberg] pvary commented on pull request #6175: Hive: Add UGI to the key in CachedClientPool

[GitBox <gi...@apache.org>]

pvary commented on PR #6175:
URL: https://github.com/apache/iceberg/pull/6175#issuecomment-1315286360

   @lirui-apache: I am not sure how the Key/UGI equals/hashCode works, this could create funny situations.
   
   Maybe we could add another test case where
   ```
       UserGroupInformation foo1 = UserGroupInformation.createProxyUser("foo", current);
       UserGroupInformation foo2 = UserGroupInformation.createProxyUser("foo", current);
   ```
   would return the same pool?
   
   Just to make sure that the cache is still working as expected, even if the UGIs are the same, but just a different instance?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org