You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "lordgamez (via GitHub)" <gi...@apache.org> on 2025/07/01 14:44:42 UTC
[PR] MINIFICPP-2232 Remove option to load SSL context from flow config [nifi-minifi-cpp]
lordgamez opened a new pull request, #1986:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1986
https://issues.apache.org/jira/browse/MINIFICPP-2232
--------------
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically main)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINIFICPP-2232 Remove option to load SSL context from flow config [nifi-minifi-cpp]
Posted by "fgerlits (via GitHub)" <gi...@apache.org>.
fgerlits commented on code in PR #1986:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1986#discussion_r2379810881
##########
libminifi/test/unit/GeneralUtilsTest.cpp:
##########
@@ -27,55 +27,55 @@
namespace org::apache::nifi::minifi::test {
// intdiv_ceil
-static_assert(0 == utils::intdiv_ceil(0, 1));
-static_assert(0 == utils::intdiv_ceil(0, 2));
-static_assert(1 == utils::intdiv_ceil(1, 2));
-static_assert(1 == utils::intdiv_ceil(1, 3));
-static_assert(1 == utils::intdiv_ceil(3, 3));
-static_assert(2 == utils::intdiv_ceil(4, 3));
-static_assert(2 == utils::intdiv_ceil(5, 3));
-static_assert(0 == utils::intdiv_ceil(-1, 3));
-static_assert(-1 == utils::intdiv_ceil(-3, 3));
-static_assert(-1 == utils::intdiv_ceil(-4, 3));
-static_assert(2 == utils::intdiv_ceil(-4, -3));
-static_assert(2 == utils::intdiv_ceil(-5, -3));
-static_assert(0 == utils::intdiv_ceil(1, -3));
-static_assert(-1 == utils::intdiv_ceil(5, -3));
-static_assert(3 == utils::intdiv_ceil(6, 2));
-static_assert(-3 == utils::intdiv_ceil(-6, 2));
-static_assert(-3 == utils::intdiv_ceil(6, -2));
-static_assert(3 == utils::intdiv_ceil(-6, -2));
-static_assert(0 == utils::intdiv_ceil(0, -10));
+static_assert(0 == minifi::utils::intdiv_ceil(0, 1));
+static_assert(0 == minifi::utils::intdiv_ceil(0, 2));
+static_assert(1 == minifi::utils::intdiv_ceil(1, 2));
+static_assert(1 == minifi::utils::intdiv_ceil(1, 3));
+static_assert(1 == minifi::utils::intdiv_ceil(3, 3));
+static_assert(2 == minifi::utils::intdiv_ceil(4, 3));
+static_assert(2 == minifi::utils::intdiv_ceil(5, 3));
+static_assert(0 == minifi::utils::intdiv_ceil(-1, 3));
+static_assert(-1 == minifi::utils::intdiv_ceil(-3, 3));
+static_assert(-1 == minifi::utils::intdiv_ceil(-4, 3));
+static_assert(2 == minifi::utils::intdiv_ceil(-4, -3));
+static_assert(2 == minifi::utils::intdiv_ceil(-5, -3));
+static_assert(0 == minifi::utils::intdiv_ceil(1, -3));
+static_assert(-1 == minifi::utils::intdiv_ceil(5, -3));
+static_assert(3 == minifi::utils::intdiv_ceil(6, 2));
+static_assert(-3 == minifi::utils::intdiv_ceil(-6, 2));
+static_assert(-3 == minifi::utils::intdiv_ceil(6, -2));
+static_assert(3 == minifi::utils::intdiv_ceil(-6, -2));
+static_assert(0 == minifi::utils::intdiv_ceil(0, -10));
template<int N, int D, typename = void>
struct does_compile : std::false_type {};
template<int N, int D>
struct does_compile<N, D,
Review Comment:
this is a bit misleading: `intdiv_ceil(123, 0)` does compile, it just doesn't compile as a constant expression (because it throws)
```suggestion
struct compiles_as_a_constant_expression<N, D,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINIFICPP-2232 Remove option to load SSL context from flow config [nifi-minifi-cpp]
Posted by "szaszm (via GitHub)" <gi...@apache.org>.
szaszm closed pull request #1986: MINIFICPP-2232 Remove option to load SSL context from flow config
URL: https://github.com/apache/nifi-minifi-cpp/pull/1986
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINIFICPP-2232 Remove option to load SSL context from flow config [nifi-minifi-cpp]
Posted by "lordgamez (via GitHub)" <gi...@apache.org>.
lordgamez commented on code in PR #1986:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1986#discussion_r2387292373
##########
libminifi/test/unit/GeneralUtilsTest.cpp:
##########
@@ -27,55 +27,55 @@
namespace org::apache::nifi::minifi::test {
// intdiv_ceil
-static_assert(0 == utils::intdiv_ceil(0, 1));
-static_assert(0 == utils::intdiv_ceil(0, 2));
-static_assert(1 == utils::intdiv_ceil(1, 2));
-static_assert(1 == utils::intdiv_ceil(1, 3));
-static_assert(1 == utils::intdiv_ceil(3, 3));
-static_assert(2 == utils::intdiv_ceil(4, 3));
-static_assert(2 == utils::intdiv_ceil(5, 3));
-static_assert(0 == utils::intdiv_ceil(-1, 3));
-static_assert(-1 == utils::intdiv_ceil(-3, 3));
-static_assert(-1 == utils::intdiv_ceil(-4, 3));
-static_assert(2 == utils::intdiv_ceil(-4, -3));
-static_assert(2 == utils::intdiv_ceil(-5, -3));
-static_assert(0 == utils::intdiv_ceil(1, -3));
-static_assert(-1 == utils::intdiv_ceil(5, -3));
-static_assert(3 == utils::intdiv_ceil(6, 2));
-static_assert(-3 == utils::intdiv_ceil(-6, 2));
-static_assert(-3 == utils::intdiv_ceil(6, -2));
-static_assert(3 == utils::intdiv_ceil(-6, -2));
-static_assert(0 == utils::intdiv_ceil(0, -10));
+static_assert(0 == minifi::utils::intdiv_ceil(0, 1));
+static_assert(0 == minifi::utils::intdiv_ceil(0, 2));
+static_assert(1 == minifi::utils::intdiv_ceil(1, 2));
+static_assert(1 == minifi::utils::intdiv_ceil(1, 3));
+static_assert(1 == minifi::utils::intdiv_ceil(3, 3));
+static_assert(2 == minifi::utils::intdiv_ceil(4, 3));
+static_assert(2 == minifi::utils::intdiv_ceil(5, 3));
+static_assert(0 == minifi::utils::intdiv_ceil(-1, 3));
+static_assert(-1 == minifi::utils::intdiv_ceil(-3, 3));
+static_assert(-1 == minifi::utils::intdiv_ceil(-4, 3));
+static_assert(2 == minifi::utils::intdiv_ceil(-4, -3));
+static_assert(2 == minifi::utils::intdiv_ceil(-5, -3));
+static_assert(0 == minifi::utils::intdiv_ceil(1, -3));
+static_assert(-1 == minifi::utils::intdiv_ceil(5, -3));
+static_assert(3 == minifi::utils::intdiv_ceil(6, 2));
+static_assert(-3 == minifi::utils::intdiv_ceil(-6, 2));
+static_assert(-3 == minifi::utils::intdiv_ceil(6, -2));
+static_assert(3 == minifi::utils::intdiv_ceil(-6, -2));
+static_assert(0 == minifi::utils::intdiv_ceil(0, -10));
template<int N, int D, typename = void>
struct does_compile : std::false_type {};
template<int N, int D>
struct does_compile<N, D,
Review Comment:
I think the suggested naming is more explicit, updated in https://github.com/apache/nifi-minifi-cpp/pull/1986/commits/68cd493925f83232bd843496eaecf9b472db3bb4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINIFICPP-2232 Remove option to load SSL context from flow config [nifi-minifi-cpp]
Posted by "szaszm (via GitHub)" <gi...@apache.org>.
szaszm commented on code in PR #1986:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1986#discussion_r2379880066
##########
libminifi/test/unit/GeneralUtilsTest.cpp:
##########
Review Comment:
What changed that made the `minifi::` prefix necessary? If it's not necessary, I prefer not adding the extra namespace prefix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINIFICPP-2232 Remove option to load SSL context from flow config [nifi-minifi-cpp]
Posted by "lordgamez (via GitHub)" <gi...@apache.org>.
lordgamez commented on code in PR #1986:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1986#discussion_r2425732239
##########
libminifi/test/unit/GeneralUtilsTest.cpp:
##########
@@ -27,55 +27,55 @@
namespace org::apache::nifi::minifi::test {
// intdiv_ceil
-static_assert(0 == utils::intdiv_ceil(0, 1));
-static_assert(0 == utils::intdiv_ceil(0, 2));
-static_assert(1 == utils::intdiv_ceil(1, 2));
-static_assert(1 == utils::intdiv_ceil(1, 3));
-static_assert(1 == utils::intdiv_ceil(3, 3));
-static_assert(2 == utils::intdiv_ceil(4, 3));
-static_assert(2 == utils::intdiv_ceil(5, 3));
-static_assert(0 == utils::intdiv_ceil(-1, 3));
-static_assert(-1 == utils::intdiv_ceil(-3, 3));
-static_assert(-1 == utils::intdiv_ceil(-4, 3));
-static_assert(2 == utils::intdiv_ceil(-4, -3));
-static_assert(2 == utils::intdiv_ceil(-5, -3));
-static_assert(0 == utils::intdiv_ceil(1, -3));
-static_assert(-1 == utils::intdiv_ceil(5, -3));
-static_assert(3 == utils::intdiv_ceil(6, 2));
-static_assert(-3 == utils::intdiv_ceil(-6, 2));
-static_assert(-3 == utils::intdiv_ceil(6, -2));
-static_assert(3 == utils::intdiv_ceil(-6, -2));
-static_assert(0 == utils::intdiv_ceil(0, -10));
+static_assert(0 == minifi::utils::intdiv_ceil(0, 1));
+static_assert(0 == minifi::utils::intdiv_ceil(0, 2));
+static_assert(1 == minifi::utils::intdiv_ceil(1, 2));
+static_assert(1 == minifi::utils::intdiv_ceil(1, 3));
+static_assert(1 == minifi::utils::intdiv_ceil(3, 3));
+static_assert(2 == minifi::utils::intdiv_ceil(4, 3));
+static_assert(2 == minifi::utils::intdiv_ceil(5, 3));
+static_assert(0 == minifi::utils::intdiv_ceil(-1, 3));
+static_assert(-1 == minifi::utils::intdiv_ceil(-3, 3));
+static_assert(-1 == minifi::utils::intdiv_ceil(-4, 3));
+static_assert(2 == minifi::utils::intdiv_ceil(-4, -3));
+static_assert(2 == minifi::utils::intdiv_ceil(-5, -3));
+static_assert(0 == minifi::utils::intdiv_ceil(1, -3));
+static_assert(-1 == minifi::utils::intdiv_ceil(5, -3));
+static_assert(3 == minifi::utils::intdiv_ceil(6, 2));
+static_assert(-3 == minifi::utils::intdiv_ceil(-6, 2));
+static_assert(-3 == minifi::utils::intdiv_ceil(6, -2));
+static_assert(3 == minifi::utils::intdiv_ceil(-6, -2));
+static_assert(0 == minifi::utils::intdiv_ceil(0, -10));
template<int N, int D, typename = void>
-struct does_compile : std::false_type {};
+struct compiles_as_a_constant_expression : std::false_type {};
template<int N, int D>
-struct does_compile<N, D,
+struct compiles_as_a_constant_expression<N, D,
// we must force evaluation so decltype won't do
- typename std::enable_if<(utils::intdiv_ceil(N, D), true)>::type> : std::true_type {};
+ std::enable_if_t<(minifi::utils::intdiv_ceil(N, D), true)>> : std::true_type {};
-static_assert(does_compile<2, 3>::value, "does_compile should work");
-static_assert(!does_compile<1, 0>::value, "constexpr division by zero shouldn't compile");
+static_assert(compiles_as_a_constant_expression<2, 3>::value, "compiles_as_a_constant_expression should work");
+static_assert(!compiles_as_a_constant_expression<1, 0>::value, "constexpr division by zero shouldn't compile");
-TEST_CASE("GeneralUtils::dereference", "[dereference]") {
+TEST_CASE("Generalminifi::utils::dereference", "[dereference]") {
const int a = 42;
const auto pa = gsl::make_not_null(&a);
- REQUIRE(42 == utils::dereference(pa));
- REQUIRE(&a == &utils::dereference(pa));
+ REQUIRE(42 == minifi::utils::dereference(pa));
+ REQUIRE(&a == &minifi::utils::dereference(pa));
const auto uniq_a = gsl::make_not_null(std::make_unique<int>(99));
- REQUIRE(99 == utils::dereference(uniq_a));
+ REQUIRE(99 == minifi::utils::dereference(uniq_a));
}
-TEST_CASE("GeneralUtils::unsafe_dereference", "[unsafe_dereference]") {
+TEST_CASE("Generalminifi::utils::unsafe_dereference", "[unsafe_dereference]") {
Review Comment:
Good catch, fixed in https://github.com/apache/nifi-minifi-cpp/pull/1986/commits/638d8001a9db6642b9f80d0f78d77931d41c4a39
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINIFICPP-2232 Remove option to load SSL context from flow config [nifi-minifi-cpp]
Posted by "adamdebreceni (via GitHub)" <gi...@apache.org>.
adamdebreceni commented on code in PR #1986:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1986#discussion_r2425718662
##########
libminifi/test/unit/GeneralUtilsTest.cpp:
##########
@@ -27,55 +27,55 @@
namespace org::apache::nifi::minifi::test {
// intdiv_ceil
-static_assert(0 == utils::intdiv_ceil(0, 1));
-static_assert(0 == utils::intdiv_ceil(0, 2));
-static_assert(1 == utils::intdiv_ceil(1, 2));
-static_assert(1 == utils::intdiv_ceil(1, 3));
-static_assert(1 == utils::intdiv_ceil(3, 3));
-static_assert(2 == utils::intdiv_ceil(4, 3));
-static_assert(2 == utils::intdiv_ceil(5, 3));
-static_assert(0 == utils::intdiv_ceil(-1, 3));
-static_assert(-1 == utils::intdiv_ceil(-3, 3));
-static_assert(-1 == utils::intdiv_ceil(-4, 3));
-static_assert(2 == utils::intdiv_ceil(-4, -3));
-static_assert(2 == utils::intdiv_ceil(-5, -3));
-static_assert(0 == utils::intdiv_ceil(1, -3));
-static_assert(-1 == utils::intdiv_ceil(5, -3));
-static_assert(3 == utils::intdiv_ceil(6, 2));
-static_assert(-3 == utils::intdiv_ceil(-6, 2));
-static_assert(-3 == utils::intdiv_ceil(6, -2));
-static_assert(3 == utils::intdiv_ceil(-6, -2));
-static_assert(0 == utils::intdiv_ceil(0, -10));
+static_assert(0 == minifi::utils::intdiv_ceil(0, 1));
+static_assert(0 == minifi::utils::intdiv_ceil(0, 2));
+static_assert(1 == minifi::utils::intdiv_ceil(1, 2));
+static_assert(1 == minifi::utils::intdiv_ceil(1, 3));
+static_assert(1 == minifi::utils::intdiv_ceil(3, 3));
+static_assert(2 == minifi::utils::intdiv_ceil(4, 3));
+static_assert(2 == minifi::utils::intdiv_ceil(5, 3));
+static_assert(0 == minifi::utils::intdiv_ceil(-1, 3));
+static_assert(-1 == minifi::utils::intdiv_ceil(-3, 3));
+static_assert(-1 == minifi::utils::intdiv_ceil(-4, 3));
+static_assert(2 == minifi::utils::intdiv_ceil(-4, -3));
+static_assert(2 == minifi::utils::intdiv_ceil(-5, -3));
+static_assert(0 == minifi::utils::intdiv_ceil(1, -3));
+static_assert(-1 == minifi::utils::intdiv_ceil(5, -3));
+static_assert(3 == minifi::utils::intdiv_ceil(6, 2));
+static_assert(-3 == minifi::utils::intdiv_ceil(-6, 2));
+static_assert(-3 == minifi::utils::intdiv_ceil(6, -2));
+static_assert(3 == minifi::utils::intdiv_ceil(-6, -2));
+static_assert(0 == minifi::utils::intdiv_ceil(0, -10));
template<int N, int D, typename = void>
-struct does_compile : std::false_type {};
+struct compiles_as_a_constant_expression : std::false_type {};
template<int N, int D>
-struct does_compile<N, D,
+struct compiles_as_a_constant_expression<N, D,
// we must force evaluation so decltype won't do
- typename std::enable_if<(utils::intdiv_ceil(N, D), true)>::type> : std::true_type {};
+ std::enable_if_t<(minifi::utils::intdiv_ceil(N, D), true)>> : std::true_type {};
-static_assert(does_compile<2, 3>::value, "does_compile should work");
-static_assert(!does_compile<1, 0>::value, "constexpr division by zero shouldn't compile");
+static_assert(compiles_as_a_constant_expression<2, 3>::value, "compiles_as_a_constant_expression should work");
+static_assert(!compiles_as_a_constant_expression<1, 0>::value, "constexpr division by zero shouldn't compile");
-TEST_CASE("GeneralUtils::dereference", "[dereference]") {
+TEST_CASE("Generalminifi::utils::dereference", "[dereference]") {
const int a = 42;
const auto pa = gsl::make_not_null(&a);
- REQUIRE(42 == utils::dereference(pa));
- REQUIRE(&a == &utils::dereference(pa));
+ REQUIRE(42 == minifi::utils::dereference(pa));
+ REQUIRE(&a == &minifi::utils::dereference(pa));
const auto uniq_a = gsl::make_not_null(std::make_unique<int>(99));
- REQUIRE(99 == utils::dereference(uniq_a));
+ REQUIRE(99 == minifi::utils::dereference(uniq_a));
}
-TEST_CASE("GeneralUtils::unsafe_dereference", "[unsafe_dereference]") {
+TEST_CASE("Generalminifi::utils::unsafe_dereference", "[unsafe_dereference]") {
Review Comment:
these test names got accidentally got
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINIFICPP-2232 Remove option to load SSL context from flow config [nifi-minifi-cpp]
Posted by "lordgamez (via GitHub)" <gi...@apache.org>.
lordgamez commented on PR #1986:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1986#issuecomment-3027914439
With the removed dependencies the order of the includes changed and it caused an issue with the Windows DELETE macro being undefined due to the conflicting HttpRequestMethod::DELETE enum. It seemed to be better to avoid the issue by renaming the method enum values in https://github.com/apache/nifi-minifi-cpp/pull/1986/commits/a05a882d6119eaa851fe5ce1a855e5bc7a1b4cba
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINIFICPP-2232 Remove option to load SSL context from flow config [nifi-minifi-cpp]
Posted by "szaszm (via GitHub)" <gi...@apache.org>.
szaszm commented on code in PR #1986:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1986#discussion_r2379877605
##########
libminifi/test/unit/GeneralUtilsTest.cpp:
##########
@@ -27,55 +27,55 @@
namespace org::apache::nifi::minifi::test {
// intdiv_ceil
-static_assert(0 == utils::intdiv_ceil(0, 1));
-static_assert(0 == utils::intdiv_ceil(0, 2));
-static_assert(1 == utils::intdiv_ceil(1, 2));
-static_assert(1 == utils::intdiv_ceil(1, 3));
-static_assert(1 == utils::intdiv_ceil(3, 3));
-static_assert(2 == utils::intdiv_ceil(4, 3));
-static_assert(2 == utils::intdiv_ceil(5, 3));
-static_assert(0 == utils::intdiv_ceil(-1, 3));
-static_assert(-1 == utils::intdiv_ceil(-3, 3));
-static_assert(-1 == utils::intdiv_ceil(-4, 3));
-static_assert(2 == utils::intdiv_ceil(-4, -3));
-static_assert(2 == utils::intdiv_ceil(-5, -3));
-static_assert(0 == utils::intdiv_ceil(1, -3));
-static_assert(-1 == utils::intdiv_ceil(5, -3));
-static_assert(3 == utils::intdiv_ceil(6, 2));
-static_assert(-3 == utils::intdiv_ceil(-6, 2));
-static_assert(-3 == utils::intdiv_ceil(6, -2));
-static_assert(3 == utils::intdiv_ceil(-6, -2));
-static_assert(0 == utils::intdiv_ceil(0, -10));
+static_assert(0 == minifi::utils::intdiv_ceil(0, 1));
+static_assert(0 == minifi::utils::intdiv_ceil(0, 2));
+static_assert(1 == minifi::utils::intdiv_ceil(1, 2));
+static_assert(1 == minifi::utils::intdiv_ceil(1, 3));
+static_assert(1 == minifi::utils::intdiv_ceil(3, 3));
+static_assert(2 == minifi::utils::intdiv_ceil(4, 3));
+static_assert(2 == minifi::utils::intdiv_ceil(5, 3));
+static_assert(0 == minifi::utils::intdiv_ceil(-1, 3));
+static_assert(-1 == minifi::utils::intdiv_ceil(-3, 3));
+static_assert(-1 == minifi::utils::intdiv_ceil(-4, 3));
+static_assert(2 == minifi::utils::intdiv_ceil(-4, -3));
+static_assert(2 == minifi::utils::intdiv_ceil(-5, -3));
+static_assert(0 == minifi::utils::intdiv_ceil(1, -3));
+static_assert(-1 == minifi::utils::intdiv_ceil(5, -3));
+static_assert(3 == minifi::utils::intdiv_ceil(6, 2));
+static_assert(-3 == minifi::utils::intdiv_ceil(-6, 2));
+static_assert(-3 == minifi::utils::intdiv_ceil(6, -2));
+static_assert(3 == minifi::utils::intdiv_ceil(-6, -2));
+static_assert(0 == minifi::utils::intdiv_ceil(0, -10));
template<int N, int D, typename = void>
struct does_compile : std::false_type {};
template<int N, int D>
struct does_compile<N, D,
Review Comment:
I wrote this a few years ago, and that was intentional. It's only used for the test below, in forced constexpr context, as mentioned in the assert message too. I don't mind changing it if you think that would make it better, but I think in the context it's clear: it's only used in constexpr context.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINIFICPP-2232 Remove option to load SSL context from flow config [nifi-minifi-cpp]
Posted by "lordgamez (via GitHub)" <gi...@apache.org>.
lordgamez commented on code in PR #1986:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1986#discussion_r2387298955
##########
libminifi/test/unit/GeneralUtilsTest.cpp:
##########
Review Comment:
I think some transitive header includes changed and it does not compile now without it. It's only needed for the `utils` namespace, otherwise if `minifi::` is not stated explicitly, the compiler looks for the function in the `minifi::test::utils` namespace instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINIFICPP-2232 Remove option to load SSL context from flow config [nifi-minifi-cpp]
Posted by "fgerlits (via GitHub)" <gi...@apache.org>.
fgerlits commented on code in PR #1986:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1986#discussion_r2381448847
##########
libminifi/test/unit/GeneralUtilsTest.cpp:
##########
@@ -27,55 +27,55 @@
namespace org::apache::nifi::minifi::test {
// intdiv_ceil
-static_assert(0 == utils::intdiv_ceil(0, 1));
-static_assert(0 == utils::intdiv_ceil(0, 2));
-static_assert(1 == utils::intdiv_ceil(1, 2));
-static_assert(1 == utils::intdiv_ceil(1, 3));
-static_assert(1 == utils::intdiv_ceil(3, 3));
-static_assert(2 == utils::intdiv_ceil(4, 3));
-static_assert(2 == utils::intdiv_ceil(5, 3));
-static_assert(0 == utils::intdiv_ceil(-1, 3));
-static_assert(-1 == utils::intdiv_ceil(-3, 3));
-static_assert(-1 == utils::intdiv_ceil(-4, 3));
-static_assert(2 == utils::intdiv_ceil(-4, -3));
-static_assert(2 == utils::intdiv_ceil(-5, -3));
-static_assert(0 == utils::intdiv_ceil(1, -3));
-static_assert(-1 == utils::intdiv_ceil(5, -3));
-static_assert(3 == utils::intdiv_ceil(6, 2));
-static_assert(-3 == utils::intdiv_ceil(-6, 2));
-static_assert(-3 == utils::intdiv_ceil(6, -2));
-static_assert(3 == utils::intdiv_ceil(-6, -2));
-static_assert(0 == utils::intdiv_ceil(0, -10));
+static_assert(0 == minifi::utils::intdiv_ceil(0, 1));
+static_assert(0 == minifi::utils::intdiv_ceil(0, 2));
+static_assert(1 == minifi::utils::intdiv_ceil(1, 2));
+static_assert(1 == minifi::utils::intdiv_ceil(1, 3));
+static_assert(1 == minifi::utils::intdiv_ceil(3, 3));
+static_assert(2 == minifi::utils::intdiv_ceil(4, 3));
+static_assert(2 == minifi::utils::intdiv_ceil(5, 3));
+static_assert(0 == minifi::utils::intdiv_ceil(-1, 3));
+static_assert(-1 == minifi::utils::intdiv_ceil(-3, 3));
+static_assert(-1 == minifi::utils::intdiv_ceil(-4, 3));
+static_assert(2 == minifi::utils::intdiv_ceil(-4, -3));
+static_assert(2 == minifi::utils::intdiv_ceil(-5, -3));
+static_assert(0 == minifi::utils::intdiv_ceil(1, -3));
+static_assert(-1 == minifi::utils::intdiv_ceil(5, -3));
+static_assert(3 == minifi::utils::intdiv_ceil(6, 2));
+static_assert(-3 == minifi::utils::intdiv_ceil(-6, 2));
+static_assert(-3 == minifi::utils::intdiv_ceil(6, -2));
+static_assert(3 == minifi::utils::intdiv_ceil(-6, -2));
+static_assert(0 == minifi::utils::intdiv_ceil(0, -10));
template<int N, int D, typename = void>
struct does_compile : std::false_type {};
template<int N, int D>
struct does_compile<N, D,
Review Comment:
I think the name I suggested would be better, but obviously this has nothing to do with the current change, so I don't mind if it stays as it is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org