You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@asterixdb.apache.org by "abdullah alamoudi (Code Review)" <do...@asterixdb.incubator.apache.org> on 2016/05/20 04:57:08 UTC

Change in asterixdb[master]: Fix Input Handler Test

abdullah alamoudi has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/872

Change subject: Fix Input Handler Test
......................................................................

Fix Input Handler Test

The test was checking that the data was fully consumed before it closes
the input handler. The test was fixed to close it before it checks.

Change-Id: I6e0e8f130a8250d9cddeb9077f9c4b79491f6fd9
---
M asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/feed/test/InputHandlerTest.java
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/72/872/1

diff --git a/asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/feed/test/InputHandlerTest.java b/asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/feed/test/InputHandlerTest.java
index 705d5e3..1312721 100644
--- a/asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/feed/test/InputHandlerTest.java
+++ b/asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/feed/test/InputHandlerTest.java
@@ -714,6 +714,7 @@
             Assert.assertEquals(1, handler.framesOnDisk());
             writer.unfreeze();
             result.get();
+            handler.close();
             Assert.assertEquals(0, handler.framesOnDisk());
         } catch (Throwable th) {
             th.printStackTrace();

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/872
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6e0e8f130a8250d9cddeb9077f9c4b79491f6fd9
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>

Change in asterixdb[master]: Fix Input Handler Test

Posted by "abdullah alamoudi (Code Review)" <do...@asterixdb.incubator.apache.org>.
abdullah alamoudi has submitted this change and it was merged.

Change subject: Fix Input Handler Test
......................................................................


Fix Input Handler Test

The test was checking that the data was fully consumed before it closes
the input handler. The test was fixed to close it before it checks.

Change-Id: I6e0e8f130a8250d9cddeb9077f9c4b79491f6fd9
Reviewed-on: https://asterix-gerrit.ics.uci.edu/872
Reviewed-by: Michael Blow <mi...@couchbase.com>
Reviewed-by: Jenkins <je...@fulliautomatix.ics.uci.edu>
Tested-by: Jenkins <je...@fulliautomatix.ics.uci.edu>
---
M asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/feed/test/InputHandlerTest.java
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Michael Blow: Looks good to me, approved
  Jenkins: Looks good to me, but someone else must approve; Verified



diff --git a/asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/feed/test/InputHandlerTest.java b/asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/feed/test/InputHandlerTest.java
index 705d5e3..1312721 100644
--- a/asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/feed/test/InputHandlerTest.java
+++ b/asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/feed/test/InputHandlerTest.java
@@ -714,6 +714,7 @@
             Assert.assertEquals(1, handler.framesOnDisk());
             writer.unfreeze();
             result.get();
+            handler.close();
             Assert.assertEquals(0, handler.framesOnDisk());
         } catch (Throwable th) {
             th.printStackTrace();

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/872
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6e0e8f130a8250d9cddeb9077f9c4b79491f6fd9
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mi...@couchbase.com>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>

Change in asterixdb[master]: Fix Input Handler Test

Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.

Change subject: Fix Input Handler Test
......................................................................


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1425/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/872
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6e0e8f130a8250d9cddeb9077f9c4b79491f6fd9
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No

Change in asterixdb[master]: Fix Input Handler Test

Posted by "Michael Blow (Code Review)" <do...@asterixdb.incubator.apache.org>.
Michael Blow has posted comments on this change.

Change subject: Fix Input Handler Test
......................................................................


Patch Set 1: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/872
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6e0e8f130a8250d9cddeb9077f9c4b79491f6fd9
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mi...@couchbase.com>
Gerrit-HasComments: No