Re: [PR] fix(mixed chart): respect truncate_metric setting for series names (#38190) [superset]

["rusackas (via GitHub)" <gi...@apache.org>]

rusackas commented on PR #38451:
URL: https://github.com/apache/superset/pull/38451#issuecomment-4753107157

   @MelikHajlawi this needs some touch-ups before it's mergeable. 
   
   There's a `console.log('truncateMetric'...)` (and one for full `formData`) left in `transformProps.ts` around line 228 that has to come out. 
   
   The two `rawSeriesA/B.forEach` blocks also got de-indented to column 0 in this diff. That won't survive prettier/eslint. 
   
   Once that's cleaned up and rebased, can you confirm it passes against the failing test from #40146 so we know it actually closes #38190?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org