You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/10/18 19:31:47 UTC
[GitHub] [arrow-nanoarrow] paleolimbot opened a new pull request, #60: C++ helpers
paleolimbot opened a new pull request, #60:
URL: https://github.com/apache/arrow-nanoarrow/pull/60
Fixes #48.
Basically, the scope of these helpers is just to manage allocating and moving the data structures in the `nanoarrow.h` API that require cleaning up:
- [x] ArrowSchema -> UniqueSchema
- [x] ArrowArray -> UniqueArray
- [x] ArrowArrayStream -> UniqueArrayStream
- [ ] ArrowBuffer
- [ ] ArrowBitmap
- [ ] ArrowArrayView
- [ ] Deallocator (maybe)
Without these, it's (unnecessarily) annoying to use nanoarrow in C++ so that you can do stuff like return early or throw an exception (i.e., nanoarrow shouldn't force C idioms on C++ clients).
In order to test array streams properly, we also need to be able to create them (users of nanoarrow probably also want to be able to test array streams properly). This PR also adds a simple array stream class backed by a `std::vector<UniqueArray>`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-nanoarrow] codecov-commenter commented on pull request #60: C++ helpers
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #60:
URL: https://github.com/apache/arrow-nanoarrow/pull/60#issuecomment-1282920167
# [Codecov](https://codecov.io/gh/apache/arrow-nanoarrow/pull/60?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#60](https://codecov.io/gh/apache/arrow-nanoarrow/pull/60?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9762749) into [main](https://codecov.io/gh/apache/arrow-nanoarrow/commit/e93e6fd0fdf4c9baab10587ba3570620892c0d2a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e93e6fd) will **not change** coverage.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## main #60 +/- ##
=======================================
Coverage 91.98% 91.98%
=======================================
Files 6 6
Lines 1497 1497
Branches 48 48
=======================================
Hits 1377 1377
Misses 87 87
Partials 33 33
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-nanoarrow/pull/60?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [src/nanoarrow/nanoarrow\_types.h](https://codecov.io/gh/apache/arrow-nanoarrow/pull/60/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL25hbm9hcnJvdy9uYW5vYXJyb3dfdHlwZXMuaA==) | `91.83% <ø> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-nanoarrow] paleolimbot merged pull request #60: C++ helpers
Posted by GitBox <gi...@apache.org>.
paleolimbot merged PR #60:
URL: https://github.com/apache/arrow-nanoarrow/pull/60
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org