You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@mynewt.apache.org by "Christopher Collins (JIRA)" <ji...@apache.org> on 2017/06/22 19:32:00 UTC
[jira] [Updated] (MYNEWT-791) syscfg - Only apply conditional
overrides if condition is true
[ https://issues.apache.org/jira/browse/MYNEWT-791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Christopher Collins updated MYNEWT-791:
---------------------------------------
Fix Version/s: (was: v1_0_0_beta1)
v1_1_0_rel
Description:
(Pull request: https://github.com/apache/incubator-mynewt-newt/pull/73)
This commit fixes a bug involving conditional overrides of syscfg values. In the following syscfg listing:
{noformat}
syscfg.vals.MY_SETTING:
LOG_LEVEL: 255
{noformat}
LOG_LEVEL should only get set to 255 if MY_SETTING is defined with a true value (nonzero and non-empty-string). However, the actual behavior is that LOG_LEVEL gets overridden if MY_SETTING is defined at all, regardless of its value.
The fix is to only apply the override if the condition is true.
was:
(Pull request: https://github.com/apache/incubator-mynewt-newt/pull/73)
This commit fixes a bug involving conditional overrides of syscfg
values. In the following syscfg listing:
{noformat}
syscfg.vals.MY_SETTING:
LOG_LEVEL: 255
{noformat}
LOG_LEVEL should only get set to 255 if MY_SETTING is defined with a
true value (nonzero and non-empty-string). However, the actual behavior
is that LOG_LEVEL gets overridden if MY_SETTING is defined at all,
regardless of its value.
The fix is to only apply the override if the condition is true.
> syscfg - Only apply conditional overrides if condition is true
> --------------------------------------------------------------
>
> Key: MYNEWT-791
> URL: https://issues.apache.org/jira/browse/MYNEWT-791
> Project: Mynewt
> Issue Type: Bug
> Security Level: Public(Viewable by anyone)
> Components: Newt
> Reporter: Christopher Collins
> Assignee: Christopher Collins
> Fix For: v1_1_0_rel
>
>
> (Pull request: https://github.com/apache/incubator-mynewt-newt/pull/73)
> This commit fixes a bug involving conditional overrides of syscfg values. In the following syscfg listing:
> {noformat}
> syscfg.vals.MY_SETTING:
> LOG_LEVEL: 255
> {noformat}
> LOG_LEVEL should only get set to 255 if MY_SETTING is defined with a true value (nonzero and non-empty-string). However, the actual behavior is that LOG_LEVEL gets overridden if MY_SETTING is defined at all, regardless of its value.
> The fix is to only apply the override if the condition is true.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)