You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/03/12 02:27:32 UTC
[GitHub] [ozone] xiaoyuyao commented on a change in pull request #2000: HDDS-4915. [SCM HA Security] Integrate CertClient.
xiaoyuyao commented on a change in pull request #2000:
URL: https://github.com/apache/ozone/pull/2000#discussion_r592726011
##########
File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/ozoneimpl/OzoneContainer.java
##########
@@ -167,8 +168,16 @@ public OzoneContainer(
blockDeletingService =
new BlockDeletingService(this, svcInterval.toMillis(), serviceTimeout,
TimeUnit.MILLISECONDS, config);
+
+ List<X509Certificate> x509Certificates = new ArrayList<>();
+ if (certClient != null) {
+ x509Certificates.add(certClient.getCACertificate());
+ if (certClient.getRootCACertificate() != null) {
Review comment:
we should avoid making the same RPC call getRootCACertificate twice.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org