You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ant.apache.org by Antoine Levy-Lambert <an...@gmx.de> on 2006/10/26 03:41:31 UTC

next release steps

Hi,
I have got the feeling that we are pretty close to releasing 1.7.0.
However I wonder whether we need a beta4 before, particularly due to the
change of refid handling since beta3.

I could free a slot for a next concrete release step on Sunday, November
5th.

Thoughts ?

Antoine

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Re: next release steps

Posted by Kevin Jackson <fo...@gmail.com>.
I'm +1 on this (as in I want to help out after a fairly long awol
period) - let me know if you want me to do anything to lighten the
load Antoine

oh and rc label for this one sounds good too

Kev

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Re: next release steps

Posted by Antoine Levy-Lambert <an...@gmx.de>.
Hi,

After the different discussions, I propose to build a distribution on
Sunday, November 5th.
The version returned by ant -version would be 1.7.0RC1 and the tag in
Subversion ANT_170_RC1.
After having built the distribution, I will upload it to my account on
people.apache.org and start a release vote. Since votes are open one
week, this will set the actual release date to Sunday, November 12th.

I see just a small problem : I will check in modified HTML pages
(including index.html, ...) announcing the release on Sunday, November 12th.
So we should not make any web site update during the time between the
build and the official release.
I have to modify the HTML pages because otherwise the users will
complain (like in some releases of Ant 1.6 IIRC) that the index.html
talks about the previous version when they download the package.
The real clean solution would be to not only tag but first branch Ant on
Sunday, November 5th, but this is a lot of overhead. If we do this, then
the HTML (and corresponding XML) can be edited on the branch,
then merged to HEAD on the actual release date, so that there is no
danger of premature site update.

Regards,
Antoine

Peter Reilly wrote:
> On 10/26/06, Antoine Levy-Lambert <an...@gmx.de> wrote:
>
>
>> I could free a slot for a next concrete release step on Sunday, November
>> 5th.
>
> +1 Perhaps call it RC1
>
> Peter
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Re: AbstractFileSet/ bug 40722

Posted by Stefan Bodewig <bo...@apache.org>.
On Sun, 29 Oct 2006, Antoine Levy-Lambert <an...@gmx.de> wrote:

> at this occasion we should add a Clone() method to DataType and to
> ProjectComponent.

In order to have a proper implementation of clone in any datatype we
need to implement it there, true.  DataTypes that don't want to or
can't implement clone will have to override the method as well, though
- so we should allow it to throw a CloneNotSupported exception.

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


AbstractFileSet/ bug 40722 [was : next release steps ]

Posted by Antoine Levy-Lambert <an...@gmx.de>.
Hi,

the best solution would be to revert my changes in
AbstractFileSet#setupDirectoryScanner(FileScanner, Project),
and change this in mergePatterns :
        PatternSet ps = new PatternSet();
        ps.append(defaultPatterns, p);
to
       ps = defaultPatterns.clone();

the fact that PatternSet#append removes the include/exclude patterns
which are not valid due to if or unless clauses made us lose the
information that
there was an include pattern, leading to "<include if="property"> logic
changed for <javac> since ant 1.6.5"

at this occasion we should add a Clone() method to DataType and to
ProjectComponent.

What do you think ?

Regards,

Antoine

[1] http://issues.apache.org/bugzilla/show_bug.cgi?id=40722.

Antoine Levy-Lambert wrote:
> Hi,
>
> I am pretty sure that Matt will rework my changes.
> AbstractFileset#mergePatterns is called from Sync#removeOrphans, so I
> could not remove it without changing sync.
>
> Regards,
>
> Antoine
>
>   


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Re: next release steps

Posted by Antoine Levy-Lambert <an...@gmx.de>.
Hi,

I am pretty sure that Matt will rework my changes.
AbstractFileset#mergePatterns is called from Sync#removeOrphans, so I
could not remove it without changing sync.

Regards,

Antoine

Stefan Bodewig wrote:
> On Sat, 28 Oct 2006, Antoine Levy-Lambert <an...@gmx.de> wrote:
>
>   
>> Do we want to keep this method in AbstractFileSet :
>> public synchronized PatternSet mergePatterns(Project p)
>> Maybe there is something useful in it ?
>>     
>
> If it has been added after 1.6.5, we can savely remove it.  Any code
> would still be available from svn history.
>
> Stefan
>
>   


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Re: next release steps

Posted by Stefan Bodewig <bo...@apache.org>.
On Sat, 28 Oct 2006, Antoine Levy-Lambert <an...@gmx.de> wrote:

> Do we want to keep this method in AbstractFileSet :
> public synchronized PatternSet mergePatterns(Project p)
> Maybe there is something useful in it ?

If it has been added after 1.6.5, we can savely remove it.  Any code
would still be available from svn history.

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Re: next release steps

Posted by Antoine Levy-Lambert <an...@gmx.de>.
Hello,



Peter Reilly wrote:
>
> I have some pending work on classpaths in <script>,
> there is a number of problems with the current implementation.
>
> 1) It does not work for language engines contained in the BSF jar.
>    This is  due to usual classloading delegation issues. This effects
>    the  languages javascript (rhino), tcl (jacl), jython and rexx.
>
> 2) It is not implemented for <scriptmapper>, <scriptcondition> etc.
>
> 3) It is not implemented for <scriptdef>
>
> 4) One cannot have bsf.jar in the classpath element.
>
> I have fixes for 1,2 and 4. 3) should not be too hard.
>
I have no clue about these issues, but fixes are always welcome ...
>
> Other things that need to be done before ant 1.7.0 final:
> Fix some regressions.
> bugzilla:
>
> http://issues.apache.org/bugzilla/show_bug.cgi?id=40313
> <delete> doesnt delete when defaultexcludes="false" and no includes is
> set
>
> http://issues.apache.org/bugzilla/show_bug.cgi?id=40722
> <include if="property"> logic changed for <javac> since ant 1.6.5
>
I have done something to fix these 2 issues.
Do we want to keep this method in AbstractFileSet :
public synchronized PatternSet mergePatterns(Project p)
Maybe there is something useful in it ?
>> I could free a slot for a next concrete release step on Sunday, November
>> 5th.
>
> +1 Perhaps call it RC1
>
> Peter
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Re: next release steps

Posted by Peter Reilly <pe...@gmail.com>.
On 10/26/06, Antoine Levy-Lambert <an...@gmx.de> wrote:
> Hi,
> I have got the feeling that we are pretty close to releasing 1.7.0.
> However I wonder whether we need a beta4 before, particularly due to the
> change of refid handling since beta3.

I have some pending work on classpaths in <script>,
there is a number of problems with the current implementation.

1) It does not work for language engines contained in the BSF jar.
    This is  due to usual classloading delegation issues. This effects
    the  languages javascript (rhino), tcl (jacl), jython and rexx.

2) It is not implemented for <scriptmapper>, <scriptcondition> etc.

3) It is not implemented for <scriptdef>

4) One cannot have bsf.jar in the classpath element.

I have fixes for 1,2 and 4. 3) should not be too hard.


Other things that need to be done before ant 1.7.0 final:
Fix some regressions.
bugzilla:

http://issues.apache.org/bugzilla/show_bug.cgi?id=40313
<delete> doesnt delete when defaultexcludes="false" and no includes is set

http://issues.apache.org/bugzilla/show_bug.cgi?id=40722
<include if="property"> logic changed for <javac> since ant 1.6.5

> I could free a slot for a next concrete release step on Sunday, November
> 5th.

+1 Perhaps call it RC1

Peter

>
> Thoughts ?
>
> Antoine
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
> For additional commands, e-mail: dev-help@ant.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Re: next release steps

Posted by Steve Loughran <st...@apache.org>.
Antoine Levy-Lambert wrote:
> Hi,
> I have got the feeling that we are pretty close to releasing 1.7.0.
> However I wonder whether we need a beta4 before, particularly due to the
> change of refid handling since beta3.
> 
> I could free a slot for a next concrete release step on Sunday, November
> 5th.
> 

1. I think changes to references do merit another release

2. I need to get my laptop building and then do the patches to WAR/EAR 
tasks.

-steve

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Re: next release steps

Posted by Kevin Jackson <fo...@gmail.com>.
> Thoughts ?

I think there have been enough changes since Beta3 to justify a Beta4.
 I know users won't pick it up until it's out of beta officially, but
the changes could affect some things and we don't want to have 1.7.1
out a month later

Kev

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org