You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Thomas Marshall (Code Review)" <ge...@cloudera.org> on 2018/06/01 20:58:48 UTC

[Impala-ASF-CR] IMPALA-7089: reenable test kudu dml reporting

Thomas Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10577


Change subject: IMPALA-7089: reenable test_kudu_dml_reporting
......................................................................

IMPALA-7089: reenable test_kudu_dml_reporting

This test was zfailed because it was broken. The change that broke it
(IMPALA-2751 - bdad189469a463fbefde932ca6255fa4b26380ae) was reverted
(84b55c6148dd4e756359717cca30a8eea71cb62a) so we can reenable the
test.

Change-Id: Ib5716f30458eb6db08f735bcbd2f79d205334930
---
M tests/shell/test_shell_commandline.py
1 file changed, 0 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/77/10577/1
-- 
To view, visit http://gerrit.cloudera.org:8080/10577
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib5716f30458eb6db08f735bcbd2f79d205334930
Gerrit-Change-Number: 10577
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>

[Impala-ASF-CR] IMPALA-7089: reenable test kudu dml reporting

Posted by "Dan Hecht (Code Review)" <ge...@cloudera.org>.
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10577 )

Change subject: IMPALA-7089: reenable test_kudu_dml_reporting
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/10577
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5716f30458eb6db08f735bcbd2f79d205334930
Gerrit-Change-Number: 10577
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Comment-Date: Fri, 01 Jun 2018 21:00:14 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7089: reenable test kudu dml reporting

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10577 )

Change subject: IMPALA-7089: reenable test_kudu_dml_reporting
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2606/


-- 
To view, visit http://gerrit.cloudera.org:8080/10577
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5716f30458eb6db08f735bcbd2f79d205334930
Gerrit-Change-Number: 10577
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 06 Jun 2018 03:45:14 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7089: reenable test kudu dml reporting

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10577 )

Change subject: IMPALA-7089: reenable test_kudu_dml_reporting
......................................................................


Patch Set 2: Code-Review+2

Let's get this test coverage back now that we've fixed the root cause.


-- 
To view, visit http://gerrit.cloudera.org:8080/10577
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5716f30458eb6db08f735bcbd2f79d205334930
Gerrit-Change-Number: 10577
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 06 Jun 2018 03:45:06 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7089: reenable test kudu dml reporting

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10577 )

Change subject: IMPALA-7089: reenable test_kudu_dml_reporting
......................................................................


Patch Set 2: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/10577
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5716f30458eb6db08f735bcbd2f79d205334930
Gerrit-Change-Number: 10577
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 06 Jun 2018 07:12:18 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7089: reenable test kudu dml reporting

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10577 )

Change subject: IMPALA-7089: reenable test_kudu_dml_reporting
......................................................................

IMPALA-7089: reenable test_kudu_dml_reporting

This test was zfailed because it was broken. The change that broke it
(IMPALA-2751 - bdad189469a463fbefde932ca6255fa4b26380ae) was reverted
(84b55c6148dd4e756359717cca30a8eea71cb62a) so we can reenable the
test.

Change-Id: Ib5716f30458eb6db08f735bcbd2f79d205334930
Reviewed-on: http://gerrit.cloudera.org:8080/10577
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/shell/test_shell_commandline.py
1 file changed, 0 insertions(+), 1 deletion(-)

Approvals:
  Tim Armstrong: Looks good to me, approved
  Impala Public Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/10577
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib5716f30458eb6db08f735bcbd2f79d205334930
Gerrit-Change-Number: 10577
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>