You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/08/31 18:19:58 UTC

[GitHub] [pulsar] gaoran10 opened a new pull request #7944: [Transaction] TransactionBuffer index snapshot

gaoran10 opened a new pull request #7944:
URL: https://github.com/apache/pulsar/pull/7944


   Fixes https://github.com/streamnative/pulsar/issues/1310
   
   ### Motivation
   
   Currently, the PersistentTransactionBuffer doesn't have the snapshot, the recover task must read all logs, this is low efficient. We could make a snapshot for TransactionBuffer termly.
   
   ### Modifications
   
   Add snapshot for PersistentTransactionBuffer.
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   This change added tests and can be verified as follows:
   
   - *org.apache.pulsar.broker.transaction.TransactionProduceTest#transactionBufferSnapshotTest*
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API: (no)
     - The schema: (no)
     - The default values of configurations: (no)
     - The wire protocol: (no)
     - The rest endpoints: (no)
     - The admin cli options: (no)
     - Anything that affects deployment: (no)
   
   ### Documentation
   
     - Does this pull request introduce a new feature? (yes / no)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] gaoran10 closed pull request #7944: [Transaction] TransactionBuffer index snapshot

Posted by GitBox <gi...@apache.org>.
gaoran10 closed pull request #7944:
URL: https://github.com/apache/pulsar/pull/7944


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] gaoran10 commented on pull request #7944: [Transaction] TransactionBuffer index snapshot

Posted by GitBox <gi...@apache.org>.
gaoran10 commented on pull request #7944:
URL: https://github.com/apache/pulsar/pull/7944#issuecomment-720624578


   This transaction buffer design had been changed, I closed this PR.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] gaoran10 edited a comment on pull request #7944: [Transaction] TransactionBuffer index snapshot

Posted by GitBox <gi...@apache.org>.
gaoran10 edited a comment on pull request #7944:
URL: https://github.com/apache/pulsar/pull/7944#issuecomment-720624578


   The transaction buffer design had been changed, I closed this PR.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org