[GitHub] [curator] Randgalt edited a comment on issue #355: [CURATOR-464] attach orignal artifacts with classifier original

[GitBox <gi...@apache.org>]

Randgalt edited a comment on issue #355: [CURATOR-464] attach orignal artifacts with classifier original
URL: https://github.com/apache/curator/pull/355#issuecomment-615951286
 
 
   A few things:
   
   - Why do we need ant and build helper plugins. Can't `install-file` from the install plugin be used?
   - If I understand the need correctly this only needs to be done on the `curator-client` module right? That's where the shading happens. Or is that you need versions of the other modules that don't refer to the shaded Guava? Will that actually work? That code is all compiled assuming a particular version of Guava. I guess if OSGI-Curator users use the right version of Guava it would work.
   - I'm not convinced that `original` is the right prefix for the unshaded JAR. Is there a standard prefix for these things? I'd appreciate it if you'd search around and show some other projects that are doing this and show what prefixes they use. 
   - We should update the website docs (see <root>/src/site) to detail these additional JARs. That should be part of this PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services