You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2022/08/20 14:01:54 UTC
[GitHub] [bookkeeper] StevenLuMT opened a new pull request, #3453: .asf.yaml details are determined
StevenLuMT opened a new pull request, #3453:
URL: https://github.com/apache/bookkeeper/pull/3453
Descriptions of the changes in this PR:
### Motivation
Now Bookkeeper is using [.asf.yaml](https://cwiki.apache.org/confluence/display/INFRA/Git+-+.asf.yaml+features#Git.asf.yamlfeatures-Branchprotection) to configure the project,
.asf.yaml details are determined
1) Whether checks are enough,
now these checks are required:
```
contexts:
- PR Validation
- Backward compatibility tests
- Bookie Tests
- Build with macos on JDK 11
- Build with windows on JDK 11
- Client Tests
- Compatibility Check Java11
- Compatibility Check Java17
- Compatibility Check Java8
- Integration Tests
- Remaining Tests
- Replication Tests
- StreamStorage Tests
- TLS Tests
```
Do we need to add others, such as: OWASP Dependency Check?
2) required_approving_review_count:
2.1) is there a need for a limit
2.2) or is the value more reasonable, 1 or 2?
### Changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] hangc0276 commented on pull request #3453: .asf.yaml details are determined
Posted by GitBox <gi...@apache.org>.
hangc0276 commented on PR #3453:
URL: https://github.com/apache/bookkeeper/pull/3453#issuecomment-1223464957
Please update the PR context, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #3453: .asf.yaml details are determined
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on PR #3453:
URL: https://github.com/apache/bookkeeper/pull/3453#issuecomment-1221437071
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli merged pull request #3453: Confirm content and update .asf.yaml
Posted by GitBox <gi...@apache.org>.
eolivelli merged PR #3453:
URL: https://github.com/apache/bookkeeper/pull/3453
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org