You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by "alisdair sullivan (JIRA)" <ji...@apache.org> on 2009/02/11 05:11:00 UTC
[jira] Created: (COUCHDB-245) Couch uses the erlang stdlib module
regexp, which is deprecated and set to be removed. It should use the module
re instead.
Couch uses the erlang stdlib module regexp, which is deprecated and set to be removed. It should use the module re instead.
---------------------------------------------------------------------------------------------------------------------------
Key: COUCHDB-245
URL: https://issues.apache.org/jira/browse/COUCHDB-245
Project: CouchDB
Issue Type: Bug
Components: Infrastructure
Affects Versions: 0.7.2, 0.8, 0.8.1
Environment: regexp is set to be removed from stdlib when R15 is released.
Reporter: alisdair sullivan
Couch uses the erlang stdlib module regexp, which is deprecated and set to be removed. It should use the module re instead. re is not a drop in replacement for regexp, it operates on and returns binary strings instead of native strings.
Affects files couch_config.erl, couch_config_writer.erl, couch_httpd.erl, couch_httpd_server.erl, couch_log.erl and couch_server.erl.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (COUCHDB-245) Couch uses the erlang stdlib
module regexp, which is deprecated and set to be removed. It should use the
module re instead.
Posted by Kerr Rainey <ke...@gmail.com>.
2009/2/11 Kerr Rainey <ke...@gmail.com>:
> Just a word of warning, people should be aware that the mochiweb
> google group seems to have a big porn add with explicit pictures on
> the home page.
Looks like it's been fixed now. Bob Ippolito edited the description
field, just opening it to edit and saving it. He never saw the
problem. The Erlang Questions group seems to have the same problem
(Different ad, same style. Warning May Contain Porn).
http://groups.google.com/group/erlang-questions
I think the evidence points to some form of hack rather than an
exploit of client machines, but there is obviously some reason that
only some users see it.
--
Kerr
Re: [jira] Commented: (COUCHDB-245) Couch uses the erlang stdlib
module regexp, which is deprecated and set to be removed. It should use the
module re instead.
Posted by Kerr Rainey <ke...@gmail.com>.
> I agree on upstream: http://code.google.com/p/mochiweb/
Just a word of warning, people should be aware that the mochiweb
google group seems to have a big porn add with explicit pictures on
the home page. I just wandered over there and had to do a quick
scramble to close the window since that sort of thing will get me into
trouble at work.
--
Kerr
[jira] Updated: (COUCHDB-245) Couch uses the erlang stdlib module
regexp, which is deprecated and set to be removed. It should use the module
re instead.
Posted by "Adam Kocoloski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adam Kocoloski updated COUCHDB-245:
-----------------------------------
Priority: Minor (was: Major)
Fix Version/s: 0.10
Thanks for the updated patch, Gordon. I think we should try to get it applied before 0.10 so that our next release builds without warnings.
> Couch uses the erlang stdlib module regexp, which is deprecated and set to be removed. It should use the module re instead.
> ---------------------------------------------------------------------------------------------------------------------------
>
> Key: COUCHDB-245
> URL: https://issues.apache.org/jira/browse/COUCHDB-245
> Project: CouchDB
> Issue Type: Bug
> Components: Infrastructure
> Affects Versions: 0.7.2, 0.8, 0.8.1, 0.9
> Environment: regexp is set to be removed from stdlib when R15 is released.
> Reporter: alisdair sullivan
> Priority: Minor
> Fix For: 0.10
>
> Attachments: couch_mochi_re_patch, couch_re_patch, couch_re_patch_2
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> Couch uses the erlang stdlib module regexp, which is deprecated and set to be removed. It should use the module re instead. re is not a drop in replacement for regexp, it operates on and returns binary strings instead of native strings.
> Affects files couch_config.erl, couch_config_writer.erl, couch_httpd.erl, couch_httpd_server.erl, couch_log.erl and couch_server.erl.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (COUCHDB-245) Couch uses the erlang stdlib module
regexp, which is deprecated and set to be removed. It should use the module
re instead.
Posted by "Antony Blakey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12672597#action_12672597 ]
Antony Blakey commented on COUCHDB-245:
---------------------------------------
Should patches to mochiweb instead be made upstream?
> Couch uses the erlang stdlib module regexp, which is deprecated and set to be removed. It should use the module re instead.
> ---------------------------------------------------------------------------------------------------------------------------
>
> Key: COUCHDB-245
> URL: https://issues.apache.org/jira/browse/COUCHDB-245
> Project: CouchDB
> Issue Type: Bug
> Components: Infrastructure
> Affects Versions: 0.7.2, 0.8, 0.8.1, 0.9
> Environment: regexp is set to be removed from stdlib when R15 is released.
> Reporter: alisdair sullivan
> Attachments: couch_mochi_re_patch, couch_re_patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> Couch uses the erlang stdlib module regexp, which is deprecated and set to be removed. It should use the module re instead. re is not a drop in replacement for regexp, it operates on and returns binary strings instead of native strings.
> Affects files couch_config.erl, couch_config_writer.erl, couch_httpd.erl, couch_httpd_server.erl, couch_log.erl and couch_server.erl.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (COUCHDB-245) Couch uses the erlang stdlib module
regexp, which is deprecated and set to be removed. It should use the module
re instead.
Posted by "Jan Lehnardt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12672601#action_12672601 ]
Jan Lehnardt commented on COUCHDB-245:
--------------------------------------
I agree on upstream: http://code.google.com/p/mochiweb/
Also, as I believe the re module was introduced in R12B, we must not make sure that CouchDB refuses to build with any earlier Erlang version. Noah?
> Couch uses the erlang stdlib module regexp, which is deprecated and set to be removed. It should use the module re instead.
> ---------------------------------------------------------------------------------------------------------------------------
>
> Key: COUCHDB-245
> URL: https://issues.apache.org/jira/browse/COUCHDB-245
> Project: CouchDB
> Issue Type: Bug
> Components: Infrastructure
> Affects Versions: 0.7.2, 0.8, 0.8.1, 0.9
> Environment: regexp is set to be removed from stdlib when R15 is released.
> Reporter: alisdair sullivan
> Attachments: couch_mochi_re_patch, couch_re_patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> Couch uses the erlang stdlib module regexp, which is deprecated and set to be removed. It should use the module re instead. re is not a drop in replacement for regexp, it operates on and returns binary strings instead of native strings.
> Affects files couch_config.erl, couch_config_writer.erl, couch_httpd.erl, couch_httpd_server.erl, couch_log.erl and couch_server.erl.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (COUCHDB-245) Couch uses the erlang stdlib module
regexp, which is deprecated and set to be removed. It should use the module
re instead.
Posted by "Gordon Stratton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gordon Stratton updated COUCHDB-245:
------------------------------------
Attachment: couch_re_patch_2
It looks like couch_rep_changes_feed.erl is now using re instead of regexp. Given that, maybe we should revisit this issue? I've attached an updated patch that applies against r800186 and passes the Futon test suite.
The re module's behavior seems to be to throw exceptions instead of doing {error, Reason}-style returns. There were a couple places in couch_config_writer.erl that looked like they could benefit from removal of arguably unnecessary error handling code (the regexp should never fail to be compiled, things should crash if it does), but I could be way off track with that. This is my first Erlang and CouchDB patch, so it's probably going to need some more work.
> Couch uses the erlang stdlib module regexp, which is deprecated and set to be removed. It should use the module re instead.
> ---------------------------------------------------------------------------------------------------------------------------
>
> Key: COUCHDB-245
> URL: https://issues.apache.org/jira/browse/COUCHDB-245
> Project: CouchDB
> Issue Type: Bug
> Components: Infrastructure
> Affects Versions: 0.7.2, 0.8, 0.8.1, 0.9
> Environment: regexp is set to be removed from stdlib when R15 is released.
> Reporter: alisdair sullivan
> Attachments: couch_mochi_re_patch, couch_re_patch, couch_re_patch_2
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> Couch uses the erlang stdlib module regexp, which is deprecated and set to be removed. It should use the module re instead. re is not a drop in replacement for regexp, it operates on and returns binary strings instead of native strings.
> Affects files couch_config.erl, couch_config_writer.erl, couch_httpd.erl, couch_httpd_server.erl, couch_log.erl and couch_server.erl.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (COUCHDB-245) Couch uses the erlang stdlib module
regexp, which is deprecated and set to be removed. It should use the module
re instead.
Posted by "alisdair sullivan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12672692#action_12672692 ]
alisdair sullivan commented on COUCHDB-245:
-------------------------------------------
The use of regexp in mochiweb is just in the app skeleton, as far as I can tell it's not actually used anywhere by couch. It doesn't hurt to report it upstream though.
I'd thought couch was targetting R12B-5 and above, but if it needs to run on previous versions, we should provide a module that wraps re and regexp and uses the appropriate module on the appropriate runtime version.
> Couch uses the erlang stdlib module regexp, which is deprecated and set to be removed. It should use the module re instead.
> ---------------------------------------------------------------------------------------------------------------------------
>
> Key: COUCHDB-245
> URL: https://issues.apache.org/jira/browse/COUCHDB-245
> Project: CouchDB
> Issue Type: Bug
> Components: Infrastructure
> Affects Versions: 0.7.2, 0.8, 0.8.1, 0.9
> Environment: regexp is set to be removed from stdlib when R15 is released.
> Reporter: alisdair sullivan
> Attachments: couch_mochi_re_patch, couch_re_patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> Couch uses the erlang stdlib module regexp, which is deprecated and set to be removed. It should use the module re instead. re is not a drop in replacement for regexp, it operates on and returns binary strings instead of native strings.
> Affects files couch_config.erl, couch_config_writer.erl, couch_httpd.erl, couch_httpd_server.erl, couch_log.erl and couch_server.erl.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (COUCHDB-245) Couch uses the erlang stdlib module
regexp, which is deprecated and set to be removed. It should use the module
re instead.
Posted by "Jan Lehnardt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jan Lehnardt reassigned COUCHDB-245:
------------------------------------
Assignee: Adam Kocoloski
> Couch uses the erlang stdlib module regexp, which is deprecated and set to be removed. It should use the module re instead.
> ---------------------------------------------------------------------------------------------------------------------------
>
> Key: COUCHDB-245
> URL: https://issues.apache.org/jira/browse/COUCHDB-245
> Project: CouchDB
> Issue Type: Bug
> Components: Infrastructure
> Affects Versions: 0.7.2, 0.8, 0.8.1, 0.9
> Environment: regexp is set to be removed from stdlib when R15 is released.
> Reporter: alisdair sullivan
> Assignee: Adam Kocoloski
> Priority: Blocker
> Fix For: 0.10
>
> Attachments: couch_mochi_re_patch, couch_re_patch, couch_re_patch_2
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> Couch uses the erlang stdlib module regexp, which is deprecated and set to be removed. It should use the module re instead. re is not a drop in replacement for regexp, it operates on and returns binary strings instead of native strings.
> Affects files couch_config.erl, couch_config_writer.erl, couch_httpd.erl, couch_httpd_server.erl, couch_log.erl and couch_server.erl.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (COUCHDB-245) Couch uses the erlang stdlib module
regexp, which is deprecated and set to be removed. It should use the module
re instead.
Posted by "Kim Shrier (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kim Shrier updated COUCHDB-245:
-------------------------------
Attachment: couch_mochi_re_patch
There are 2 uses of the regexp module in the mochiweb source. This patch replaces them with functions from the re module. File mochiweb_skel.erl is modified.
> Couch uses the erlang stdlib module regexp, which is deprecated and set to be removed. It should use the module re instead.
> ---------------------------------------------------------------------------------------------------------------------------
>
> Key: COUCHDB-245
> URL: https://issues.apache.org/jira/browse/COUCHDB-245
> Project: CouchDB
> Issue Type: Bug
> Components: Infrastructure
> Affects Versions: 0.7.2, 0.8, 0.8.1, 0.9
> Environment: regexp is set to be removed from stdlib when R15 is released.
> Reporter: alisdair sullivan
> Attachments: couch_mochi_re_patch, couch_re_patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> Couch uses the erlang stdlib module regexp, which is deprecated and set to be removed. It should use the module re instead. re is not a drop in replacement for regexp, it operates on and returns binary strings instead of native strings.
> Affects files couch_config.erl, couch_config_writer.erl, couch_httpd.erl, couch_httpd_server.erl, couch_log.erl and couch_server.erl.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Updated: (COUCHDB-245) Couch uses the erlang stdlib module regexp, which is deprecated and set to be removed. It should use the module re instead.
Posted by Adam Kocoloski <ko...@apache.org>.
I believe re.erl changes rapidly from 12B-3 to 12B-5. I haven't
compared 12B-5 and 13B.
Adam
On Aug 4, 2009, at 7:15 AM, Paul Davis wrote:
> It pops in around 3 I think. Pretty sure we require 12B-0 and that
> doesn't have it.
>
> I looked once and judged from documentation we'd have to bump a couple
> minor revisions in our Erlang dependency.
>
> Paul
>
> On Mon, Aug 3, 2009 at 3:50 PM, Gordon Stratton<ts...@gmail.com>
> wrote:
>> Are we talking about its inclusion or whether it is stable in R12B?
>> Here
>> is my Debian Lenny system with stock erlang (R12B-3):
>>
>> --
>>
>> Erlang (BEAM) emulator version 5.6.3 [source] [64-bit] [smp:4]
>> [async-threads:0] [kernel-poll:false]
>>
>> Eshell V5.6.3 (abort with ^G)
>> 1> Foo = "Hello World! 122.42".
>> "Hello World! 122.42"
>> 2> re:compile("[0-9].[0-9]").
>> {ok,{re_pattern,0,0,
>> <<69,82,67,80,122,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,
>> ...>>}}
>> 3>
>>
>> --
>>
>> In the readme[1] for the version I'm running, OTP-7181 indicates it
>> is
>> introduced (experimentally at least?) in that version.
>>
>> [1] http://www.erlang.org/download/otp_src_R12B-3.readme
>>
>> Adam Kocoloski wrote:
>>> Wow, I didn't realize re.erl was only really available in R13B. I
>>> figured for new code I ought to not be using the regexp module,
>>> but this
>>> gives me pause.
>>>
>>> Adam
>>>
>>> On Aug 3, 2009, at 3:29 PM, Damien Katz wrote:
>>>
>>>> Switching from regexp to re mean we can't support Erlang R12, but
>>>> I'm
>>>> not sure if we do right now anyway.
>>>>
>>>> -Damien
>>>>
>>>> On Aug 3, 2009, at 1:41 PM, Jan Lehnardt (JIRA) wrote:
>>>>
>>>>>
>>>>> [
>>>>> https://issues.apache.org/jira/browse/COUCHDB-245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
>>>>> ]
>>>>>
>>>>> Jan Lehnardt updated COUCHDB-245:
>>>>> ---------------------------------
>>>>>
>>>>> Priority: Blocker (was: Minor)
>>>>>
>>>>>> Couch uses the erlang stdlib module regexp, which is deprecated
>>>>>> and set to be removed. It should use the module re instead.
>>>>>> ---------------------------------------------------------------------------------------------------------------------------
>>>>>>
>>>>>> Key: COUCHDB-245
>>>>>> URL: https://issues.apache.org/jira/browse/COUCHDB-245
>>>>>> Project: CouchDB
>>>>>> Issue Type: Bug
>>>>>> Components: Infrastructure
>>>>>> Affects Versions: 0.7.2, 0.8, 0.8.1, 0.9
>>>>>> Environment: regexp is set to be removed from stdlib when
>>>>>> R15 is released.
>>>>>> Reporter: alisdair sullivan
>>>>>> Priority: Blocker
>>>>>> Fix For: 0.10
>>>>>>
>>>>>> Attachments: couch_mochi_re_patch, couch_re_patch,
>>>>>> couch_re_patch_2
>>>>>>
>>>>>> Original Estimate: 2h
>>>>>> Remaining Estimate: 2h
>>>>>>
>>>>>> Couch uses the erlang stdlib module regexp, which is deprecated
>>>>>> and set to be removed. It should use the module re instead. re is
>>>>>> not a drop in replacement for regexp, it operates on and returns
>>>>>> binary strings instead of native strings.
>>>>>> Affects files couch_config.erl, couch_config_writer.erl,
>>>>>> couch_httpd.erl, couch_httpd_server.erl, couch_log.erl and
>>>>>> couch_server.erl.
>>>>>
>>>>> --
>>>>> This message is automatically generated by JIRA.
>>>>> -
>>>>> You can reply to this email to add a comment to the issue online.
>>>>>
>>>>
>>
Re: [jira] Updated: (COUCHDB-245) Couch uses the erlang stdlib module
regexp, which is deprecated and set to be removed. It should use the module
re instead.
Posted by Paul Davis <pa...@gmail.com>.
It pops in around 3 I think. Pretty sure we require 12B-0 and that
doesn't have it.
I looked once and judged from documentation we'd have to bump a couple
minor revisions in our Erlang dependency.
Paul
On Mon, Aug 3, 2009 at 3:50 PM, Gordon Stratton<ts...@gmail.com> wrote:
> Are we talking about its inclusion or whether it is stable in R12B? Here
> is my Debian Lenny system with stock erlang (R12B-3):
>
> --
>
> Erlang (BEAM) emulator version 5.6.3 [source] [64-bit] [smp:4] [async-threads:0] [kernel-poll:false]
>
> Eshell V5.6.3 (abort with ^G)
> 1> Foo = "Hello World! 122.42".
> "Hello World! 122.42"
> 2> re:compile("[0-9].[0-9]").
> {ok,{re_pattern,0,0,
> <<69,82,67,80,122,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,
> ...>>}}
> 3>
>
> --
>
> In the readme[1] for the version I'm running, OTP-7181 indicates it is
> introduced (experimentally at least?) in that version.
>
> [1] http://www.erlang.org/download/otp_src_R12B-3.readme
>
> Adam Kocoloski wrote:
>> Wow, I didn't realize re.erl was only really available in R13B. I
>> figured for new code I ought to not be using the regexp module, but this
>> gives me pause.
>>
>> Adam
>>
>> On Aug 3, 2009, at 3:29 PM, Damien Katz wrote:
>>
>>> Switching from regexp to re mean we can't support Erlang R12, but I'm
>>> not sure if we do right now anyway.
>>>
>>> -Damien
>>>
>>> On Aug 3, 2009, at 1:41 PM, Jan Lehnardt (JIRA) wrote:
>>>
>>>>
>>>> [
>>>> https://issues.apache.org/jira/browse/COUCHDB-245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
>>>> ]
>>>>
>>>> Jan Lehnardt updated COUCHDB-245:
>>>> ---------------------------------
>>>>
>>>> Priority: Blocker (was: Minor)
>>>>
>>>>> Couch uses the erlang stdlib module regexp, which is deprecated
>>>>> and set to be removed. It should use the module re instead.
>>>>> ---------------------------------------------------------------------------------------------------------------------------
>>>>>
>>>>> Key: COUCHDB-245
>>>>> URL: https://issues.apache.org/jira/browse/COUCHDB-245
>>>>> Project: CouchDB
>>>>> Issue Type: Bug
>>>>> Components: Infrastructure
>>>>> Affects Versions: 0.7.2, 0.8, 0.8.1, 0.9
>>>>> Environment: regexp is set to be removed from stdlib when
>>>>> R15 is released.
>>>>> Reporter: alisdair sullivan
>>>>> Priority: Blocker
>>>>> Fix For: 0.10
>>>>>
>>>>> Attachments: couch_mochi_re_patch, couch_re_patch,
>>>>> couch_re_patch_2
>>>>>
>>>>> Original Estimate: 2h
>>>>> Remaining Estimate: 2h
>>>>>
>>>>> Couch uses the erlang stdlib module regexp, which is deprecated
>>>>> and set to be removed. It should use the module re instead. re is
>>>>> not a drop in replacement for regexp, it operates on and returns
>>>>> binary strings instead of native strings.
>>>>> Affects files couch_config.erl, couch_config_writer.erl,
>>>>> couch_httpd.erl, couch_httpd_server.erl, couch_log.erl and
>>>>> couch_server.erl.
>>>>
>>>> --
>>>> This message is automatically generated by JIRA.
>>>> -
>>>> You can reply to this email to add a comment to the issue online.
>>>>
>>>
>
Re: [jira] Updated: (COUCHDB-245) Couch uses the erlang stdlib
module regexp, which is deprecated and set to be removed. It should
use the module re instead.
Posted by Gordon Stratton <ts...@gmail.com>.
Are we talking about its inclusion or whether it is stable in R12B? Here
is my Debian Lenny system with stock erlang (R12B-3):
--
Erlang (BEAM) emulator version 5.6.3 [source] [64-bit] [smp:4] [async-threads:0] [kernel-poll:false]
Eshell V5.6.3 (abort with ^G)
1> Foo = "Hello World! 122.42".
"Hello World! 122.42"
2> re:compile("[0-9].[0-9]").
{ok,{re_pattern,0,0,
<<69,82,67,80,122,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,
...>>}}
3>
--
In the readme[1] for the version I'm running, OTP-7181 indicates it is
introduced (experimentally at least?) in that version.
[1] http://www.erlang.org/download/otp_src_R12B-3.readme
Adam Kocoloski wrote:
> Wow, I didn't realize re.erl was only really available in R13B. I
> figured for new code I ought to not be using the regexp module, but this
> gives me pause.
>
> Adam
>
> On Aug 3, 2009, at 3:29 PM, Damien Katz wrote:
>
>> Switching from regexp to re mean we can't support Erlang R12, but I'm
>> not sure if we do right now anyway.
>>
>> -Damien
>>
>> On Aug 3, 2009, at 1:41 PM, Jan Lehnardt (JIRA) wrote:
>>
>>>
>>> [
>>> https://issues.apache.org/jira/browse/COUCHDB-245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
>>> ]
>>>
>>> Jan Lehnardt updated COUCHDB-245:
>>> ---------------------------------
>>>
>>> Priority: Blocker (was: Minor)
>>>
>>>> Couch uses the erlang stdlib module regexp, which is deprecated
>>>> and set to be removed. It should use the module re instead.
>>>> ---------------------------------------------------------------------------------------------------------------------------
>>>>
>>>> Key: COUCHDB-245
>>>> URL: https://issues.apache.org/jira/browse/COUCHDB-245
>>>> Project: CouchDB
>>>> Issue Type: Bug
>>>> Components: Infrastructure
>>>> Affects Versions: 0.7.2, 0.8, 0.8.1, 0.9
>>>> Environment: regexp is set to be removed from stdlib when
>>>> R15 is released.
>>>> Reporter: alisdair sullivan
>>>> Priority: Blocker
>>>> Fix For: 0.10
>>>>
>>>> Attachments: couch_mochi_re_patch, couch_re_patch,
>>>> couch_re_patch_2
>>>>
>>>> Original Estimate: 2h
>>>> Remaining Estimate: 2h
>>>>
>>>> Couch uses the erlang stdlib module regexp, which is deprecated
>>>> and set to be removed. It should use the module re instead. re is
>>>> not a drop in replacement for regexp, it operates on and returns
>>>> binary strings instead of native strings.
>>>> Affects files couch_config.erl, couch_config_writer.erl,
>>>> couch_httpd.erl, couch_httpd_server.erl, couch_log.erl and
>>>> couch_server.erl.
>>>
>>> --
>>> This message is automatically generated by JIRA.
>>> -
>>> You can reply to this email to add a comment to the issue online.
>>>
>>
Re: [jira] Updated: (COUCHDB-245) Couch uses the erlang stdlib module regexp, which is deprecated and set to be removed. It should use the module re instead.
Posted by Jan Lehnardt <ja...@apache.org>.
re.erl is in R12B-5:
http://erlang.org/documentation/doc-5.6.5/lib/stdlib-1.15.5/doc/html/re.html
Cheers
Jan
--
On 3 Aug 2009, at 21:40, Adam Kocoloski wrote:
> Wow, I didn't realize re.erl was only really available in R13B. I
> figured for new code I ought to not be using the regexp module, but
> this gives me pause.
>
> Adam
>
> On Aug 3, 2009, at 3:29 PM, Damien Katz wrote:
>
>> Switching from regexp to re mean we can't support Erlang R12, but
>> I'm not sure if we do right now anyway.
>>
>> -Damien
>>
>> On Aug 3, 2009, at 1:41 PM, Jan Lehnardt (JIRA) wrote:
>>
>>>
>>> [ https://issues.apache.org/jira/browse/COUCHDB-245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
>>> ]
>>>
>>> Jan Lehnardt updated COUCHDB-245:
>>> ---------------------------------
>>>
>>> Priority: Blocker (was: Minor)
>>>
>>>> Couch uses the erlang stdlib module regexp, which is deprecated
>>>> and set to be removed. It should use the module re instead.
>>>> ---------------------------------------------------------------------------------------------------------------------------
>>>>
>>>> Key: COUCHDB-245
>>>> URL: https://issues.apache.org/jira/browse/COUCHDB-245
>>>> Project: CouchDB
>>>> Issue Type: Bug
>>>> Components: Infrastructure
>>>> Affects Versions: 0.7.2, 0.8, 0.8.1, 0.9
>>>> Environment: regexp is set to be removed from stdlib when
>>>> R15 is released.
>>>> Reporter: alisdair sullivan
>>>> Priority: Blocker
>>>> Fix For: 0.10
>>>>
>>>> Attachments: couch_mochi_re_patch, couch_re_patch,
>>>> couch_re_patch_2
>>>>
>>>> Original Estimate: 2h
>>>> Remaining Estimate: 2h
>>>>
>>>> Couch uses the erlang stdlib module regexp, which is deprecated
>>>> and set to be removed. It should use the module re instead. re is
>>>> not a drop in replacement for regexp, it operates on and returns
>>>> binary strings instead of native strings.
>>>> Affects files couch_config.erl, couch_config_writer.erl,
>>>> couch_httpd.erl, couch_httpd_server.erl, couch_log.erl and
>>>> couch_server.erl.
>>>
>>> --
>>> This message is automatically generated by JIRA.
>>> -
>>> You can reply to this email to add a comment to the issue online.
>>>
>>
>
Re: [jira] Updated: (COUCHDB-245) Couch uses the erlang stdlib module regexp, which is deprecated and set to be removed. It should use the module re instead.
Posted by Adam Kocoloski <ad...@gmail.com>.
Wow, I didn't realize re.erl was only really available in R13B. I
figured for new code I ought to not be using the regexp module, but
this gives me pause.
Adam
On Aug 3, 2009, at 3:29 PM, Damien Katz wrote:
> Switching from regexp to re mean we can't support Erlang R12, but
> I'm not sure if we do right now anyway.
>
> -Damien
>
> On Aug 3, 2009, at 1:41 PM, Jan Lehnardt (JIRA) wrote:
>
>>
>> [ https://issues.apache.org/jira/browse/COUCHDB-245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
>> ]
>>
>> Jan Lehnardt updated COUCHDB-245:
>> ---------------------------------
>>
>> Priority: Blocker (was: Minor)
>>
>>> Couch uses the erlang stdlib module regexp, which is deprecated
>>> and set to be removed. It should use the module re instead.
>>> ---------------------------------------------------------------------------------------------------------------------------
>>>
>>> Key: COUCHDB-245
>>> URL: https://issues.apache.org/jira/browse/COUCHDB-245
>>> Project: CouchDB
>>> Issue Type: Bug
>>> Components: Infrastructure
>>> Affects Versions: 0.7.2, 0.8, 0.8.1, 0.9
>>> Environment: regexp is set to be removed from stdlib when
>>> R15 is released.
>>> Reporter: alisdair sullivan
>>> Priority: Blocker
>>> Fix For: 0.10
>>>
>>> Attachments: couch_mochi_re_patch, couch_re_patch,
>>> couch_re_patch_2
>>>
>>> Original Estimate: 2h
>>> Remaining Estimate: 2h
>>>
>>> Couch uses the erlang stdlib module regexp, which is deprecated
>>> and set to be removed. It should use the module re instead. re is
>>> not a drop in replacement for regexp, it operates on and returns
>>> binary strings instead of native strings.
>>> Affects files couch_config.erl, couch_config_writer.erl,
>>> couch_httpd.erl, couch_httpd_server.erl, couch_log.erl and
>>> couch_server.erl.
>>
>> --
>> This message is automatically generated by JIRA.
>> -
>> You can reply to this email to add a comment to the issue online.
>>
>
Re: [jira] Updated: (COUCHDB-245) Couch uses the erlang stdlib module regexp, which is deprecated and set to be removed. It should use the module re instead.
Posted by Damien Katz <da...@apache.org>.
Switching from regexp to re mean we can't support Erlang R12, but I'm
not sure if we do right now anyway.
-Damien
On Aug 3, 2009, at 1:41 PM, Jan Lehnardt (JIRA) wrote:
>
> [ https://issues.apache.org/jira/browse/COUCHDB-245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
> ]
>
> Jan Lehnardt updated COUCHDB-245:
> ---------------------------------
>
> Priority: Blocker (was: Minor)
>
>> Couch uses the erlang stdlib module regexp, which is deprecated and
>> set to be removed. It should use the module re instead.
>> ---------------------------------------------------------------------------------------------------------------------------
>>
>> Key: COUCHDB-245
>> URL: https://issues.apache.org/jira/browse/COUCHDB-245
>> Project: CouchDB
>> Issue Type: Bug
>> Components: Infrastructure
>> Affects Versions: 0.7.2, 0.8, 0.8.1, 0.9
>> Environment: regexp is set to be removed from stdlib when
>> R15 is released.
>> Reporter: alisdair sullivan
>> Priority: Blocker
>> Fix For: 0.10
>>
>> Attachments: couch_mochi_re_patch, couch_re_patch,
>> couch_re_patch_2
>>
>> Original Estimate: 2h
>> Remaining Estimate: 2h
>>
>> Couch uses the erlang stdlib module regexp, which is deprecated and
>> set to be removed. It should use the module re instead. re is not a
>> drop in replacement for regexp, it operates on and returns binary
>> strings instead of native strings.
>> Affects files couch_config.erl, couch_config_writer.erl,
>> couch_httpd.erl, couch_httpd_server.erl, couch_log.erl and
>> couch_server.erl.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
[jira] Updated: (COUCHDB-245) Couch uses the erlang stdlib module
regexp, which is deprecated and set to be removed. It should use the module
re instead.
Posted by "Jan Lehnardt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jan Lehnardt updated COUCHDB-245:
---------------------------------
Priority: Blocker (was: Minor)
> Couch uses the erlang stdlib module regexp, which is deprecated and set to be removed. It should use the module re instead.
> ---------------------------------------------------------------------------------------------------------------------------
>
> Key: COUCHDB-245
> URL: https://issues.apache.org/jira/browse/COUCHDB-245
> Project: CouchDB
> Issue Type: Bug
> Components: Infrastructure
> Affects Versions: 0.7.2, 0.8, 0.8.1, 0.9
> Environment: regexp is set to be removed from stdlib when R15 is released.
> Reporter: alisdair sullivan
> Priority: Blocker
> Fix For: 0.10
>
> Attachments: couch_mochi_re_patch, couch_re_patch, couch_re_patch_2
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> Couch uses the erlang stdlib module regexp, which is deprecated and set to be removed. It should use the module re instead. re is not a drop in replacement for regexp, it operates on and returns binary strings instead of native strings.
> Affects files couch_config.erl, couch_config_writer.erl, couch_httpd.erl, couch_httpd_server.erl, couch_log.erl and couch_server.erl.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (COUCHDB-245) Couch uses the erlang stdlib module
regexp, which is deprecated and set to be removed. It should use the module
re instead.
Posted by "alisdair sullivan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
alisdair sullivan updated COUCHDB-245:
--------------------------------------
Affects Version/s: 0.9
> Couch uses the erlang stdlib module regexp, which is deprecated and set to be removed. It should use the module re instead.
> ---------------------------------------------------------------------------------------------------------------------------
>
> Key: COUCHDB-245
> URL: https://issues.apache.org/jira/browse/COUCHDB-245
> Project: CouchDB
> Issue Type: Bug
> Components: Infrastructure
> Affects Versions: 0.7.2, 0.8, 0.8.1, 0.9
> Environment: regexp is set to be removed from stdlib when R15 is released.
> Reporter: alisdair sullivan
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> Couch uses the erlang stdlib module regexp, which is deprecated and set to be removed. It should use the module re instead. re is not a drop in replacement for regexp, it operates on and returns binary strings instead of native strings.
> Affects files couch_config.erl, couch_config_writer.erl, couch_httpd.erl, couch_httpd_server.erl, couch_log.erl and couch_server.erl.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (COUCHDB-245) Couch uses the erlang stdlib module
regexp, which is deprecated and set to be removed. It should use the module
re instead.
Posted by "Kim Shrier (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kim Shrier updated COUCHDB-245:
-------------------------------
Attachment: couch_re_patch
This file contains a patch to replace the use of the regexp module with the re module. It modifies files couch_config.erl, couch_config_writer.erl, couch_log.erl, couch_httpd.erl, couch_httpd_db.erl, and couch_server.erl
> Couch uses the erlang stdlib module regexp, which is deprecated and set to be removed. It should use the module re instead.
> ---------------------------------------------------------------------------------------------------------------------------
>
> Key: COUCHDB-245
> URL: https://issues.apache.org/jira/browse/COUCHDB-245
> Project: CouchDB
> Issue Type: Bug
> Components: Infrastructure
> Affects Versions: 0.7.2, 0.8, 0.8.1, 0.9
> Environment: regexp is set to be removed from stdlib when R15 is released.
> Reporter: alisdair sullivan
> Attachments: couch_re_patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> Couch uses the erlang stdlib module regexp, which is deprecated and set to be removed. It should use the module re instead. re is not a drop in replacement for regexp, it operates on and returns binary strings instead of native strings.
> Affects files couch_config.erl, couch_config_writer.erl, couch_httpd.erl, couch_httpd_server.erl, couch_log.erl and couch_server.erl.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (COUCHDB-245) Couch uses the erlang stdlib module
regexp, which is deprecated and set to be removed. It should use the module
re instead.
Posted by "Adam Kocoloski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adam Kocoloski closed COUCHDB-245.
----------------------------------
Resolution: Fixed
thanks Gordon and Kim for the patches. We're now using re instead of regexp, which means that R12B-5 or higher is a requirement.
> Couch uses the erlang stdlib module regexp, which is deprecated and set to be removed. It should use the module re instead.
> ---------------------------------------------------------------------------------------------------------------------------
>
> Key: COUCHDB-245
> URL: https://issues.apache.org/jira/browse/COUCHDB-245
> Project: CouchDB
> Issue Type: Bug
> Components: Infrastructure
> Affects Versions: 0.7.2, 0.8, 0.8.1, 0.9
> Environment: regexp is set to be removed from stdlib when R15 is released.
> Reporter: alisdair sullivan
> Assignee: Adam Kocoloski
> Priority: Blocker
> Fix For: 0.10
>
> Attachments: couch_mochi_re_patch, couch_re_patch, couch_re_patch_2
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> Couch uses the erlang stdlib module regexp, which is deprecated and set to be removed. It should use the module re instead. re is not a drop in replacement for regexp, it operates on and returns binary strings instead of native strings.
> Affects files couch_config.erl, couch_config_writer.erl, couch_httpd.erl, couch_httpd_server.erl, couch_log.erl and couch_server.erl.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (COUCHDB-245) Couch uses the erlang stdlib module
regexp, which is deprecated and set to be removed. It should use the module
re instead.
Posted by "Jan Lehnardt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12672693#action_12672693 ]
Jan Lehnardt commented on COUCHDB-245:
--------------------------------------
I think bumping the required version is just fine and adding a module to handle this is overkill.
> Couch uses the erlang stdlib module regexp, which is deprecated and set to be removed. It should use the module re instead.
> ---------------------------------------------------------------------------------------------------------------------------
>
> Key: COUCHDB-245
> URL: https://issues.apache.org/jira/browse/COUCHDB-245
> Project: CouchDB
> Issue Type: Bug
> Components: Infrastructure
> Affects Versions: 0.7.2, 0.8, 0.8.1, 0.9
> Environment: regexp is set to be removed from stdlib when R15 is released.
> Reporter: alisdair sullivan
> Attachments: couch_mochi_re_patch, couch_re_patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> Couch uses the erlang stdlib module regexp, which is deprecated and set to be removed. It should use the module re instead. re is not a drop in replacement for regexp, it operates on and returns binary strings instead of native strings.
> Affects files couch_config.erl, couch_config_writer.erl, couch_httpd.erl, couch_httpd_server.erl, couch_log.erl and couch_server.erl.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (COUCHDB-245) Couch uses the erlang stdlib module
regexp, which is deprecated and set to be removed. It should use the module
re instead.
Posted by "Curt Arnold (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12744567#action_12744567 ]
Curt Arnold commented on COUCHDB-245:
-------------------------------------
The regexp calls in Mochweb were replaced with re calls on June 25, 2009, rev 102. Should the bundled mochiweb be updated to remove all the deprecation warnings?
> Couch uses the erlang stdlib module regexp, which is deprecated and set to be removed. It should use the module re instead.
> ---------------------------------------------------------------------------------------------------------------------------
>
> Key: COUCHDB-245
> URL: https://issues.apache.org/jira/browse/COUCHDB-245
> Project: CouchDB
> Issue Type: Bug
> Components: Infrastructure
> Affects Versions: 0.7.2, 0.8, 0.8.1, 0.9
> Environment: regexp is set to be removed from stdlib when R15 is released.
> Reporter: alisdair sullivan
> Assignee: Adam Kocoloski
> Priority: Blocker
> Fix For: 0.10
>
> Attachments: couch_mochi_re_patch, couch_re_patch, couch_re_patch_2
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> Couch uses the erlang stdlib module regexp, which is deprecated and set to be removed. It should use the module re instead. re is not a drop in replacement for regexp, it operates on and returns binary strings instead of native strings.
> Affects files couch_config.erl, couch_config_writer.erl, couch_httpd.erl, couch_httpd_server.erl, couch_log.erl and couch_server.erl.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.