Binary data

[Brian Candler <B....@pobox.com>]

> > On Fri, Jan 15, 2010 at 09:32:34AM -0800, Chris Anderson wrote:
> >> list and show should be able to return base64 data, to be decoded to
> >> binary before sending to the client. I know there is a test that _show
> >> can serve a favicon.ico file.
> >
> > Thank you for pointing that out, I found the _show test.
> >
> > I had already grepped the source for base64, and found only one relevant
> > instance in couch_httpd_external.erl. Now I see that gets called from
> > couch_httpd_show.erl too.
> >
> > I can't see how _list calls it though?
> 
> that's worth writing a test for. written tests rock. -- move to dev@?

Moved to dev.

I've done the test for _update (and it already passes):
https://issues.apache.org/jira/browse/COUCHDB-626

However I'm not sure what you want to do with _list. At the moment you emit
chunks of plain strings. Do you want something like
    send({base64:"..."})
?

Or do you want to put a tag in the header which says all the chunks are
base64? (like a Content-Transfer-Encoding: base64 which is stripped)

Re: Binary data

[Chris Anderson <jc...@apache.org>]

On Mon, Jan 18, 2010 at 6:39 AM, Brian Candler <B....@pobox.com> wrote:
>> > On Fri, Jan 15, 2010 at 09:32:34AM -0800, Chris Anderson wrote:
>> >> list and show should be able to return base64 data, to be decoded to
>> >> binary before sending to the client. I know there is a test that _show
>> >> can serve a favicon.ico file.
>> >
>> > Thank you for pointing that out, I found the _show test.
>> >
>> > I had already grepped the source for base64, and found only one relevant
>> > instance in couch_httpd_external.erl. Now I see that gets called from
>> > couch_httpd_show.erl too.
>> >
>> > I can't see how _list calls it though?
>>
>> that's worth writing a test for. written tests rock. -- move to dev@?
>
> Moved to dev.
>
> I've done the test for _update (and it already passes):
> https://issues.apache.org/jira/browse/COUCHDB-626
>
> However I'm not sure what you want to do with _list. At the moment you emit
> chunks of plain strings. Do you want something like
>    send({base64:"..."})
> ?

I think the send({base64:"..."}) option is easier to understand and
probably less burden on implementors.

Thanks,
Chris

>
> Or do you want to put a tag in the header which says all the chunks are
> base64? (like a Content-Transfer-Encoding: base64 which is stripped)
>



-- 
Chris Anderson
http://jchrisa.net
http://couch.io