[GitHub] spark pull request #16361: [SPARK-18952] Regex strings not properly escaped ...

[JoshRosen <gi...@git.apache.org>]

Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16361#discussion_r94508116
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/RowBasedHashMapGenerator.scala ---
    @@ -43,28 +43,30 @@ class RowBasedHashMapGenerator(
       extends HashMapGenerator (ctx, aggregateExpressions, generatedClassName,
         groupingKeySchema, bufferSchema) {
     
    -  protected def initializeAggregateHashMap(): String = {
    +  override protected def initializeAggregateHashMap(): String = {
         val generatedKeySchema: String =
           s"new org.apache.spark.sql.types.StructType()" +
             groupingKeySchema.map { key =>
    +          val keyName = ctx.addReferenceObj(key.name)
    --- End diff --
    
    Looks like you now need to use `addReferenceMinorObj` after a conflicting change was merged. We'll need to use the current version of the patch when backporting into branch-2.1, though.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org