[GitHub] [nutch] madhawa-gunasekara commented on a change in pull request #543: NUTCH-2811 : Setup Github workflows for prs

[GitBox <gi...@apache.org>]

madhawa-gunasekara commented on a change in pull request #543:
URL: https://github.com/apache/nutch/pull/543#discussion_r463700541



##########
File path: .github/workflows/master-build.yml
##########
@@ -0,0 +1,36 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#      http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+name: master pr build
+
+on: [push, pull_request]

Review comment:
       Hi @balashashanka 
   Here you can see, I added workflows for both pull requests and direct pushes. so basically It will run 1 time for the pull request, and one time after the merge. (push). I haven't mentioned a specific branch for pushes. so this will enable for every branch. [In Gora](https://github.com/apache/gora/blob/master/.github/workflows/master-push-build.yml#L22), we have specified master branch for pushes. Let me know if we need to specify particular branches for pushes.

##########
File path: .github/workflows/master-build.yml
##########
@@ -0,0 +1,36 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#      http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+name: master pr build
+
+on: [push, pull_request]
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        java: [ '1.8' ]
+
+    steps:
+      - uses: actions/checkout@v2
+      - name: Set up JDK ${{ matrix.java }}
+        uses: actions/setup-java@v1
+        with:
+          java-version: ${{ matrix.java }}
+      - name: Build with Ant
+        run: ant clean nightly javadoc -buildfile build.xml

Review comment:
       I have taken these parameters from the [Jenkins configurations.](https://builds.apache.org/view/M-R/view/Nutch/job/Nutch-trunk/configure)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org