[GitHub] [spark] JoshRosen commented on a change in pull request #24693: [SPARK-27829][SQL] In Dataset.joinWith inner joins, don't nest data before shuffling

[GitBox <gi...@apache.org>]

JoshRosen commented on a change in pull request #24693: [SPARK-27829][SQL] In Dataset.joinWith inner joins, don't nest data before shuffling
URL: https://github.com/apache/spark/pull/24693#discussion_r287207443
 
 

 ##########
 File path: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala
 ##########
 @@ -485,6 +507,28 @@ class DatasetSuite extends QueryTest with SharedSQLContext {
     assert(e4.contains("Invalid join type in joinWith: " + LeftAnti.sql))
   }
 
+  test("joinWith left_outer") {
 
 Review comment:
   I realized there's an existing left join test, so I'll remove this new test case and fold in the schema checks into the existing case.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org