You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@orc.apache.org by "williamhyun (via GitHub)" <gi...@apache.org> on 2023/06/15 05:50:51 UTC
[GitHub] [orc] williamhyun opened a new pull request, #1536: ORC-1444: Enforce JDK Bytecode version
williamhyun opened a new pull request, #1536:
URL: https://github.com/apache/orc/pull/1536
### What changes were proposed in this pull request?
This PR aims to enforce the JDK Bytecode version.
At this moment it is enforced to 1.8, however, we will be able to move it up later.
### Why are the changes needed?
This feature helps us prevent accidental addition of a higher JDK library.
### How was this patch tested?
Pass the CIs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on a diff in pull request #1536: ORC-1444: Enforce JDK Bytecode version
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #1536:
URL: https://github.com/apache/orc/pull/1536#discussion_r1230479344
##########
java/pom.xml:
##########
@@ -628,6 +628,14 @@
<requireMavenVersion>
<version>${maven.version}</version>
</requireMavenVersion>
+ <enforceBytecodeVersion>
+ <maxJdkVersion>1.8</maxJdkVersion>
Review Comment:
Maybe, after merging #1535, shall we use `java.version`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] williamhyun commented on pull request #1536: ORC-1444: Enforce JDK Bytecode version
Posted by "williamhyun (via GitHub)" <gi...@apache.org>.
williamhyun commented on PR #1536:
URL: https://github.com/apache/orc/pull/1536#issuecomment-1592434649
Thank you, I addressed the comments and have rebased!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on a diff in pull request #1536: ORC-1444: Enforce JDK Bytecode version
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #1536:
URL: https://github.com/apache/orc/pull/1536#discussion_r1230480469
##########
java/pom.xml:
##########
@@ -641,6 +649,13 @@
</configuration>
</execution>
</executions>
+ <dependencies>
+ <dependency>
+ <groupId>org.codehaus.mojo</groupId>
+ <artifactId>extra-enforcer-rules</artifactId>
+ <version>1.7.0</version>
+ </dependency>
+ </dependencies>
Review Comment:
CI seems to complain at this due to the ordering too~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on a diff in pull request #1536: ORC-1444: Enforce JDK Bytecode version
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #1536:
URL: https://github.com/apache/orc/pull/1536#discussion_r1230494856
##########
java/pom.xml:
##########
@@ -632,6 +639,14 @@
<requireJavaVersion>
<version>${java.version}</version>
</requireJavaVersion>
+ <enforceBytecodeVersion>
+ <maxJdkVersion>${java.version}</maxJdkVersion>
+ <ignoredScopes>test</ignoredScopes>
+ <ignoredScopes>provided</ignoredScopes>
+ <excludes>
+ <exclude>org.threeten:threeten-extra</exclude>
Review Comment:
Yes, this was reported before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #1536: ORC-1444: Enforce JDK Bytecode version
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #1536:
URL: https://github.com/apache/orc/pull/1536#issuecomment-1593509726
Merged to main/1.9.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] williamhyun commented on pull request #1536: ORC-1444: Enforce JDK Bytecode version
Posted by "williamhyun (via GitHub)" <gi...@apache.org>.
williamhyun commented on PR #1536:
URL: https://github.com/apache/orc/pull/1536#issuecomment-1592411372
@dongjoon-hyun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun closed pull request #1536: ORC-1444: Enforce JDK Bytecode version
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #1536: ORC-1444: Enforce JDK Bytecode version
URL: https://github.com/apache/orc/pull/1536
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #1536: ORC-1444: Enforce JDK Bytecode version
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #1536:
URL: https://github.com/apache/orc/pull/1536#issuecomment-1593507888
Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org