[jira] [Comment Edited] (YUNIKORN-1028) move master branches to pseudo versions in go.mod

["Craig Condit (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YUNIKORN-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17487169#comment-17487169 ] 

Craig Condit edited comment on YUNIKORN-1028 at 2/4/22, 4:32 PM:
-----------------------------------------------------------------

We will need two PRs (in succession) for this, one for core, and one for k8shim (which will need to reference the new core version).


was (Author: ccondit):
We will need to PRs (in succession) for this, one for core, and one for k8shim (which will need to reference the new core version).

> move master branches to pseudo versions in go.mod
> -------------------------------------------------
>
>                 Key: YUNIKORN-1028
>                 URL: https://issues.apache.org/jira/browse/YUNIKORN-1028
>             Project: Apache YuniKorn
>          Issue Type: Improvement
>          Components: core - common, shim - kubernetes
>            Reporter: Wilfred Spiegelenburg
>            Assignee: Craig Condit
>            Priority: Major
>              Labels: pull-request-available
>
> The current go.mod for both the core and the k8shim point to a release tag of our own repositories. This is not correct.
> The master branches should not point to a release tag as they can move while we go through our development process. Go provides the option to use a pseudo version for this and we should stick to that for master as per this comment https://go.dev/ref/mod#pseudo-versions:
> {quote}Pseudo-versions may refer to revisions for which no [semantic version tags|https://go.dev/ref/mod#glos-semantic-version-tag] are available. They may be used to test commits before creating version tags, for example, on a development branch.
> {quote}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: issues-help@yunikorn.apache.org