You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Zhitao Li <zh...@gmail.com> on 2018/03/07 23:21:00 UTC
Review Request 65959: Added a test to make sure `slave/recovery_secs`
is reported in metrics.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65959/
-----------------------------------------------------------
Review request for mesos, Gilbert Song, Greg Mann, Jason Lai, and James Peach.
Bugs: MESOS-8609
https://issues.apache.org/jira/browse/MESOS-8609
Repository: mesos
Description
-------
Added a test to make sure `slave/recovery_secs` is reported in metrics.
Diffs
-----
src/tests/slave_tests.cpp e253317a67019302f18afe11e2a314e716cec226
Diff: https://reviews.apache.org/r/65959/diff/1/
Testing
-------
Thanks,
Zhitao Li
Re: Review Request 65959: Added a test to make sure
`slave/recovery_secs` is reported in metrics.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65959/#review198837
-----------------------------------------------------------
PASS: Mesos patch 65959 was successfully built and tested.
Reviews applied: `['65954', '65959']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65959
- Mesos Reviewbot Windows
On March 7, 2018, 11:21 p.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65959/
> -----------------------------------------------------------
>
> (Updated March 7, 2018, 11:21 p.m.)
>
>
> Review request for mesos, Gilbert Song, Greg Mann, Jason Lai, and James Peach.
>
>
> Bugs: MESOS-8609
> https://issues.apache.org/jira/browse/MESOS-8609
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test to make sure `slave/recovery_secs` is reported in metrics.
>
>
> Diffs
> -----
>
> src/tests/slave_tests.cpp e253317a67019302f18afe11e2a314e716cec226
>
>
> Diff: https://reviews.apache.org/r/65959/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zhitao Li
>
>
Re: Review Request 65959: Added a test to make sure
`slave/recovery_secs` is reported in metrics.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65959/#review198852
-----------------------------------------------------------
Patch looks great!
Reviews applied: [65954, 65959]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On March 7, 2018, 11:21 p.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65959/
> -----------------------------------------------------------
>
> (Updated March 7, 2018, 11:21 p.m.)
>
>
> Review request for mesos, Gilbert Song, Greg Mann, Jason Lai, and James Peach.
>
>
> Bugs: MESOS-8609
> https://issues.apache.org/jira/browse/MESOS-8609
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test to make sure `slave/recovery_secs` is reported in metrics.
>
>
> Diffs
> -----
>
> src/tests/slave_tests.cpp e253317a67019302f18afe11e2a314e716cec226
>
>
> Diff: https://reviews.apache.org/r/65959/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zhitao Li
>
>
Re: Review Request 65959: Added a test to make sure
`slave/recovery_time_secs` is reported.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65959/#review199196
-----------------------------------------------------------
src/tests/slave_tests.cpp
Lines 1377 (patched)
<https://reviews.apache.org/r/65959/#comment279490>
Nit:
```
// Make sure the agent finishes recovery.
```
- James Peach
On March 14, 2018, 6:03 p.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65959/
> -----------------------------------------------------------
>
> (Updated March 14, 2018, 6:03 p.m.)
>
>
> Review request for mesos, Gilbert Song, Greg Mann, Jason Lai, and James Peach.
>
>
> Bugs: MESOS-8609
> https://issues.apache.org/jira/browse/MESOS-8609
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test to make sure `slave/recovery_time_secs` is reported.
>
>
> Diffs
> -----
>
> src/tests/slave_tests.cpp c2afaa573039e25fb59496765e6717e7643a692f
>
>
> Diff: https://reviews.apache.org/r/65959/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zhitao Li
>
>
Re: Review Request 65959: Added a test to make sure
`slave/recovery_time_secs` is reported.
Posted by Zhitao Li <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65959/
-----------------------------------------------------------
(Updated March 14, 2018, 6:03 p.m.)
Review request for mesos, Gilbert Song, Greg Mann, Jason Lai, and James Peach.
Changes
-------
Updated metric name.
Summary (updated)
-----------------
Added a test to make sure `slave/recovery_time_secs` is reported.
Bugs: MESOS-8609
https://issues.apache.org/jira/browse/MESOS-8609
Repository: mesos
Description (updated)
-------
Added a test to make sure `slave/recovery_time_secs` is reported.
Diffs (updated)
-----
src/tests/slave_tests.cpp c2afaa573039e25fb59496765e6717e7643a692f
Diff: https://reviews.apache.org/r/65959/diff/2/
Changes: https://reviews.apache.org/r/65959/diff/1-2/
Testing
-------
Thanks,
Zhitao Li