You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@parquet.apache.org by "wgtmac (via GitHub)" <gi...@apache.org> on 2023/03/02 01:28:18 UTC

[GitHub] [parquet-format] wgtmac commented on a diff in pull request #190: Minor: add FIXED_LEN_BYTE_ARRAY under Types in doc

wgtmac commented on code in PR #190:
URL: https://github.com/apache/parquet-format/pull/190#discussion_r1122508344


##########
README.md:
##########
@@ -132,6 +132,7 @@ readers and writers for the format.  The types are:
   - FLOAT: IEEE 32-bit floating point values
   - DOUBLE: IEEE 64-bit floating point values
   - BYTE_ARRAY: arbitrarily long byte arrays.
+  - FIXED_LEN_BYTE_ARRAY: fixed length byte arrays.

Review Comment:
   Thanks for adding this!
   
   It is weird that only `BYTE_ARRAY` and `FIXED_LEN_BYTE_ARRAY` end with a period. Better to remove them off for consistency.
   
   Should we also mark INT96 as deprecated? cc @gszadovszky @shangxinli 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org