You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/04/04 12:06:48 UTC
[GitHub] [apisix-ingress-controller] joyyir opened a new issue, #948: feat: Support for 'discovery_type' in ApisixUpstream
joyyir opened a new issue, #948:
URL: https://github.com/apache/apisix-ingress-controller/issues/948
Hello,
When integrating with service discovery, `discovery_type` is specified in the upstream settings as described in the following article: https://apisix.apache.org/docs/apisix/discovery/#upstream-setting
However, there is no 'discovery_type' field in the 'ApisixUpstream' specification, so to use the service discovery integration I need to register upstream with the dashboard or Admin API.
So I propose to add 'discovery_type' in Apisix Upstream spec.
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] yujinchoi-94 commented on issue #948: feat: Support for 'discovery_type' in ApisixUpstream
Posted by "yujinchoi-94 (via GitHub)" <gi...@apache.org>.
yujinchoi-94 commented on issue #948:
URL: https://github.com/apache/apisix-ingress-controller/issues/948#issuecomment-1478807186
@tao12345666333
Hi,
`discovery` related fields seem missing in [ApisixUpstream reference](https://apisix.apache.org/docs/ingress-controller/references/apisix_upstream/)
It would be good if a spec for a `discovery` related fields are added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #948: feat: Support for 'discovery_type' in ApisixUpstream
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on issue #948:
URL: https://github.com/apache/apisix-ingress-controller/issues/948#issuecomment-1111689303
After thinking about it, we actually have a relatively simple way to achieve it.
* Configure multiple discovery types in APISIX
* Extend ApisixUpstream resource to allow configuration of discovery_type
* If the discovery_type is found in the ApisixUpstream resource, it will no longer be parsed, and the corresponding Upstream will be created in APISIX
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #948: feat: Support for 'discovery_type' in ApisixUpstream
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on issue #948:
URL: https://github.com/apache/apisix-ingress-controller/issues/948#issuecomment-1089590363
I understand your situation.
But the current APISIX Ingress controller is designed to automatically discover changes to resources in Kubernetes.
We need some discussion about this feature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 closed issue #948: feat: Support for 'discovery_type' in ApisixUpstream
Posted by GitBox <gi...@apache.org>.
tao12345666333 closed issue #948: feat: Support for 'discovery_type' in ApisixUpstream
URL: https://github.com/apache/apisix-ingress-controller/issues/948
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #948: feat: Support for 'discovery_type' in ApisixUpstream
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on issue #948:
URL: https://github.com/apache/apisix-ingress-controller/issues/948#issuecomment-1327914186
I've implemented that functionality in #1465 .
It will be available in v1.6 release.
thanks
e.g.
```
apiVersion: apisix.apache.org/v2
kind: ApisixUpstream
metadata:
name: foo
spec:
discovery:
type: dns #consul/nacos/ and others
serviceName: bar
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #948: feat: Support for 'discovery_type' in ApisixUpstream
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on issue #948:
URL: https://github.com/apache/apisix-ingress-controller/issues/948#issuecomment-1118360446
@Gallardot sorry for delay. Can you prepare a proposal first? Contains general implementation content, etc. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #948: feat: Support for 'discovery_type' in ApisixUpstream
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on issue #948:
URL: https://github.com/apache/apisix-ingress-controller/issues/948#issuecomment-1087635467
Can you describe your specific use case? I would like to know what service do you need to integrate with
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] joyyir commented on issue #948: feat: Support for 'discovery_type' in ApisixUpstream
Posted by GitBox <gi...@apache.org>.
joyyir commented on issue #948:
URL: https://github.com/apache/apisix-ingress-controller/issues/948#issuecomment-1088176135
I want to integrate with `Eureka`. I added the upstream setting by dashboard. I found that the upstream setting cannot be defined as `ApisixStream` because of `discovery_type`.
Here is the upstream setting:
```yaml
name: my-svc-upstream
type: ewma
scheme: http
discovery_type: eureka
pass_host: pass
service_name: MY-SVC
```
Here is the route setting:
```yaml
uri: /my-svc/*
name: my-svc-route
host: www.my-host.com
upstream_id: '401325612930696050'
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on issue #948: feat: Support for 'discovery_type' in ApisixUpstream
Posted by GitBox <gi...@apache.org>.
tokers commented on issue #948:
URL: https://github.com/apache/apisix-ingress-controller/issues/948#issuecomment-1090071185
Only support the discovery type in ApisixUpstream cannot satisfy your needs since APISIX Ingress Controller only watches service from Kubernetes, and ApisixUpstream will be in effective only if there is a Kubernetes serivce which name is same to the ApisixUpstream.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] Gallardot commented on issue #948: feat: Support for 'discovery_type' in ApisixUpstream
Posted by GitBox <gi...@apache.org>.
Gallardot commented on issue #948:
URL: https://github.com/apache/apisix-ingress-controller/issues/948#issuecomment-1111702630
The Integration service discovery registry in APISIX is a very attractive feature. Support for this feature will help expand the usage scenarios for apisix-ingress-controller.
I want to have a try.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org