You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/03/02 12:46:19 UTC
[GitHub] [hadoop-ozone] adoroszlai opened a new pull request #621:
HDDS-3106. Intermittent timeout in
TestOzoneManagerDoubleBufferWithOMResponse#testDoubleBuffer
adoroszlai opened a new pull request #621: HDDS-3106. Intermittent timeout in TestOzoneManagerDoubleBufferWithOMResponse#testDoubleBuffer
URL: https://github.com/apache/hadoop-ozone/pull/621
## What changes were proposed in this pull request?
Generate volume name using `UUID.randomUUID()` instead of a 5-char random alphabetic string.
Checked the output of some timed out executions of the test, and found that the number of volumes created is less than expected:
```
$ grep -c 'created volume' [fs]*
failed1:1054
failed2:1109
success:1114
```
I think this is due to conflicts in random names (ie. same name is generated twice).
https://issues.apache.org/jira/browse/HDDS-3106
## How was this patch tested?
Regular CI with all checks:
https://github.com/adoroszlai/hadoop-ozone/runs/479415494
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai commented on issue #621: HDDS-3106.
Intermittent timeout in
TestOzoneManagerDoubleBufferWithOMResponse#testDoubleBuffer
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on issue #621: HDDS-3106. Intermittent timeout in TestOzoneManagerDoubleBufferWithOMResponse#testDoubleBuffer
URL: https://github.com/apache/hadoop-ozone/pull/621#issuecomment-593524678
@bharatviswa504 I think there may be a real possibility of deadlock here, this patch just fixes the intermittent test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai commented on issue #621: HDDS-3106.
Intermittent timeout in
TestOzoneManagerDoubleBufferWithOMResponse#testDoubleBuffer
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on issue #621: HDDS-3106. Intermittent timeout in TestOzoneManagerDoubleBufferWithOMResponse#testDoubleBuffer
URL: https://github.com/apache/hadoop-ozone/pull/621#issuecomment-593650073
Thanks @bharatviswa504 for reviewing and merging it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai closed pull request #621: HDDS-3106.
Intermittent timeout in
TestOzoneManagerDoubleBufferWithOMResponse#testDoubleBuffer
Posted by GitBox <gi...@apache.org>.
adoroszlai closed pull request #621: HDDS-3106. Intermittent timeout in TestOzoneManagerDoubleBufferWithOMResponse#testDoubleBuffer
URL: https://github.com/apache/hadoop-ozone/pull/621
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] bharatviswa504 commented on issue #621: HDDS-3106.
Intermittent timeout in
TestOzoneManagerDoubleBufferWithOMResponse#testDoubleBuffer
Posted by GitBox <gi...@apache.org>.
bharatviswa504 commented on issue #621: HDDS-3106. Intermittent timeout in TestOzoneManagerDoubleBufferWithOMResponse#testDoubleBuffer
URL: https://github.com/apache/hadoop-ozone/pull/621#issuecomment-593528228
> Increase max. concurrency to 2x the number of volumes to be created, because OMVolumeCreateRequest requires 2 write locks: volume- and user-level.
But one question even if we have max. concurrency set to 1000, the thread will be blocked and when other thread releases the lock, it will acquire the lock. Not sure if I am missing something here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] bharatviswa504 edited a comment on issue #621:
HDDS-3106. Intermittent timeout in
TestOzoneManagerDoubleBufferWithOMResponse#testDoubleBuffer
Posted by GitBox <gi...@apache.org>.
bharatviswa504 edited a comment on issue #621: HDDS-3106. Intermittent timeout in TestOzoneManagerDoubleBufferWithOMResponse#testDoubleBuffer
URL: https://github.com/apache/hadoop-ozone/pull/621#issuecomment-593528228
Increase max. concurrency to 2x the number of volumes to be created, because OMVolumeCreateRequest requires 2 write locks: volume- and user-level.
But one question even if we have max. concurrency set to 1000, the thread will be blocked and when other thread releases the lock, it will acquire the lock. Not sure if I am missing something here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] bharatviswa504 edited a comment on issue #621:
HDDS-3106. Intermittent timeout in
TestOzoneManagerDoubleBufferWithOMResponse#testDoubleBuffer
Posted by GitBox <gi...@apache.org>.
bharatviswa504 edited a comment on issue #621: HDDS-3106. Intermittent timeout in TestOzoneManagerDoubleBufferWithOMResponse#testDoubleBuffer
URL: https://github.com/apache/hadoop-ozone/pull/621#issuecomment-593528228
> Increase max. concurrency to 2x the number of volumes to be created, because OMVolumeCreateRequest requires 2 write locks: volume- and user-level.
But one question even if we have max. concurrency set to 1000, the thread will be blocked and when other thread releases the lock, it will acquire the lock. Not sure if I am missing something here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] bharatviswa504 commented on issue #621: HDDS-3106.
Intermittent timeout in
TestOzoneManagerDoubleBufferWithOMResponse#testDoubleBuffer
Posted by GitBox <gi...@apache.org>.
bharatviswa504 commented on issue #621: HDDS-3106. Intermittent timeout in TestOzoneManagerDoubleBufferWithOMResponse#testDoubleBuffer
URL: https://github.com/apache/hadoop-ozone/pull/621#issuecomment-593525240
> @bharatviswa504 I think there may be a real possibility of deadlock here, this patch just fixes the intermittent test.
Thank You @adoroszlai. Deadlock in OM? Not sure what is referred here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai opened a new pull request #621:
HDDS-3106. Intermittent timeout in
TestOzoneManagerDoubleBufferWithOMResponse#testDoubleBuffer
Posted by GitBox <gi...@apache.org>.
adoroszlai opened a new pull request #621: HDDS-3106. Intermittent timeout in TestOzoneManagerDoubleBufferWithOMResponse#testDoubleBuffer
URL: https://github.com/apache/hadoop-ozone/pull/621
## What changes were proposed in this pull request?
Generate volume name using `UUID.randomUUID()` instead of a 5-char random alphabetic string.
Checked the output of some timed out executions of the test, and found that the number of volumes created is less than expected:
```
$ grep -c 'created volume' [fs]*
failed1:1054
failed2:1109
success:1114
```
I think this is due to conflicts in random names (ie. same name is generated twice).
https://issues.apache.org/jira/browse/HDDS-3106
## How was this patch tested?
Regular CI with all checks:
https://github.com/adoroszlai/hadoop-ozone/runs/479415494
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] bharatviswa504 merged pull request #621: HDDS-3106.
Intermittent timeout in
TestOzoneManagerDoubleBufferWithOMResponse#testDoubleBuffer
Posted by GitBox <gi...@apache.org>.
bharatviswa504 merged pull request #621: HDDS-3106. Intermittent timeout in TestOzoneManagerDoubleBufferWithOMResponse#testDoubleBuffer
URL: https://github.com/apache/hadoop-ozone/pull/621
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org