You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/22 01:04:14 UTC

[GitHub] [arrow-datafusion] xudong963 commented on pull request #4185: Add rule to reimplement `Eliminate cross join` and remove it in planner

xudong963 commented on PR #4185:
URL: https://github.com/apache/arrow-datafusion/pull/4185#issuecomment-1322861964

   > > > There is specific logic in `extract_possible_join_keys()` to handle and pull up common Exprs in the Or branches. But I
   > 
   > > Nice idea👍! It's a great future ticket.
   > 
   > I agree it would be a good idea for a future ticket. There is also https://github.com/apache/arrow-datafusion/blob/master/datafusion/optimizer/src/rewrite_disjunctive_predicate.rs which I think tries to do the same thing
   
   Yes, thanks for your mention :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org