You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "psteitz (via GitHub)" <gi...@apache.org> on 2023/07/06 20:42:39 UTC
[GitHub] [commons-pool] psteitz opened a new pull request, #228: POOL-391 fixes, docs
psteitz opened a new pull request, #228:
URL: https://github.com/apache/commons-pool/pull/228
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-pool] codecov-commenter commented on pull request #228: POOL-391 fixes, docs
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #228:
URL: https://github.com/apache/commons-pool/pull/228#issuecomment-1624292736
## [Codecov](https://app.codecov.io/gh/apache/commons-pool/pull/228?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#228](https://app.codecov.io/gh/apache/commons-pool/pull/228?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (a44ac33) into [master](https://app.codecov.io/gh/apache/commons-pool/commit/b336e2b2c306aab7e349abad79924532754e88f7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (b336e2b) will **increase** coverage by `0.10%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #228 +/- ##
============================================
+ Coverage 82.98% 83.08% +0.10%
- Complexity 784 786 +2
============================================
Files 42 42
Lines 3079 3080 +1
Branches 313 314 +1
============================================
+ Hits 2555 2559 +4
+ Misses 416 414 -2
+ Partials 108 107 -1
```
| [Impacted Files](https://app.codecov.io/gh/apache/commons-pool/pull/228?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...che/commons/pool2/impl/GenericKeyedObjectPool.java](https://app.codecov.io/gh/apache/commons-pool/pull/228?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvcG9vbDIvaW1wbC9HZW5lcmljS2V5ZWRPYmplY3RQb29sLmphdmE=) | `84.45% <100.00%> (+0.02%)` | :arrow_up: |
... and [1 file with indirect coverage changes](https://app.codecov.io/gh/apache/commons-pool/pull/228/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-pool] garydgregory commented on pull request #228: POOL-391 fixes, docs
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #228:
URL: https://github.com/apache/commons-pool/pull/228#issuecomment-1624529441
Capturing some sample failures for when the build logs age out:
```
[INFO] Running org.apache.commons.pool2.pool407.Pool407Test
Error: Exception in thread "pool-3-thread-4" java.lang.RuntimeException: java.lang.NullPointerException: Pool407NullObjectFactory.makeObject() = null
at org.apache.commons.pool2.pool407.Pool407Test$Pool407RoundtripRunnable.run(Pool407Test.java:51)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
at java.base/java.lang.Thread.run(Thread.java:833)
Caused by: java.lang.NullPointerException: Pool407NullObjectFactory.makeObject() = null
at org.apache.commons.pool2.impl.GenericObjectPool.create(GenericObjectPool.java:568)
at org.apache.commons.pool2.impl.GenericObjectPool.borrowObject(GenericObjectPool.java:299)
at org.apache.commons.pool2.impl.GenericObjectPool.borrowObject(GenericObjectPool.java:227)
at org.apache.commons.pool2.pool407.Pool407Test$Pool407RoundtripRunnable.run(Pool407Test.java:46)
... 3 more
Error: Exception in thread "pool-3-thread-1" java.lang.RuntimeException: java.lang.NullPointerException: Pool407NullObjectFactory.makeObject() = null
at org.apache.commons.pool2.pool407.Pool407Test$Pool407RoundtripRunnable.run(Pool407Test.java:51)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
at java.base/java.lang.Thread.run(Thread.java:833)
Caused by: java.lang.NullPointerException: Pool407NullObjectFactory.makeObject() = null
at org.apache.commons.pool2.impl.GenericObjectPool.create(GenericObjectPool.java:568)
at org.apache.commons.pool2.impl.GenericObjectPool.borrowObject(GenericObjectPool.java:299)
at org.apache.commons.pool2.impl.GenericObjectPool.borrowObject(GenericObjectPool.java:227)
at org.apache.commons.pool2.pool407.Pool407Test$Pool407RoundtripRunnable.run(Pool407Test.java:46)
... 3 more
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-pool] psteitz commented on pull request #228: POOL-391 fixes, docs
Posted by "psteitz (via GitHub)" <gi...@apache.org>.
psteitz commented on PR #228:
URL: https://github.com/apache/commons-pool/pull/228#issuecomment-1624547407
Yes, I think this is the same failure in POOL-411. Very rare, so good the CI caught it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-pool] psteitz merged pull request #228: POOL-391 fixes, docs
Posted by "psteitz (via GitHub)" <gi...@apache.org>.
psteitz merged PR #228:
URL: https://github.com/apache/commons-pool/pull/228
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org