[GitHub] [shardingsphere] LeeGuoPing commented on a change in pull request #14918: support expression in projection

[GitBox <gi...@apache.org>]

LeeGuoPing commented on a change in pull request #14918:
URL: https://github.com/apache/shardingsphere/pull/14918#discussion_r806439528



##########
File path: shardingsphere-test/shardingsphere-rewrite-test/src/test/resources/scenario/encrypt/case/select_for_query_with_cipher.xml
##########
@@ -47,6 +47,11 @@
         <output sql="SELECT account_id, cipher_password AS password, cipher_amount AS a, status AS s FROM t_account WHERE account_id = 1 AND assisted_query_password = 'assisted_query_aaa' AND cipher_amount = 'encrypt_1000' AND status = 'OK'" />
     </rewrite-assertion>
 
+    <rewrite-assertion id="select_for_concat_literals" db-types="MySQL">
+        <input sql="SELECT account_id, concat(account_id, password, amount) as ap, amount AS a, status AS s FROM t_account WHERE account_id = 1 AND password = 'aaa' AND amount = 1000 AND status = 'OK'" />

Review comment:
       It's better to use uppercase `AS`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org