[GitHub] [iceberg] aokolnychyi commented on a diff in pull request #6828: Spark 3.3: Change default distribution modes

["aokolnychyi (via GitHub)" <gi...@apache.org>]

aokolnychyi commented on code in PR #6828:
URL: https://github.com/apache/iceberg/pull/6828#discussion_r1105028083


##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/SparkWriteConf.java:
##########
@@ -228,6 +228,16 @@ private DistributionMode adjustWriteDistributionMode(DistributionMode mode) {
     }
   }
 
+  private DistributionMode defaultDistributionMode() {
+    if (table.sortOrder().isSorted()) {
+      return RANGE;
+    } else if (table.spec().isPartitioned()) {
+      return HASH;
+    } else {
+      return NONE;

Review Comment:
   We have to request a valid `Distribution` in order for AQE to do its job. If the table is unpartitioned, I don't think we have what to cluster by.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org