You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apex.apache.org by chandnisingh <gi...@git.apache.org> on 2015/11/12 02:35:26 UTC

[GitHub] incubator-apex-site pull request: Changed contributor guidelines

GitHub user chandnisingh opened a pull request:

    https://github.com/apache/incubator-apex-site/pull/4

    Changed contributor guidelines

    @vrozov please review

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/chandnisingh/incubator-apex-site master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-apex-site/pull/4.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4
    
----
commit 04e5aa084df5771211e1631e53cb0c3e7853b18e
Author: Chandni Singh <cs...@apache.org>
Date:   2015-11-12T01:19:03Z

    Changed contributor guidelines

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-apex-site pull request: Changed contributor guidelines

Posted by vrozov <gi...@git.apache.org>.
Github user vrozov commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-site/pull/4#discussion_r44614089
  
    --- Diff: src/md/contributing.md ---
    @@ -9,15 +9,48 @@ The apex core and apex malhar repositories both have mirror repositories on gith
     This project welcomes new contributors. If you would like to help by adding new features, enhancements or fixing bugs, here is how to do it.
     
     1. Create a [JIRA](https://malhar.atlassian.net/) for the work you plan to do (or assign yourself to an existing JIRA ticket)
    -1. Fork the ASF github mirror (one time step):
    -   https://github.com/apache/incubator-apex-core/
    -1. Create a new branch from the [devel-3](https://github.com/apache/incubator-apex-core/tree/devel-3) branch. **Name your branch with the JIRA number in it, e.g. `APEX-123.my-feature`.**
    -1. When adding new files, please include the Apache v2.0 license header.
    +2. Fork the ASF github mirror (one time step):
    --- End diff --
    
    Please keep existing numbers. It allows to insert new items into the list without renumbering.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-apex-site pull request: Changed contributor guidelines

Posted by chandnisingh <gi...@git.apache.org>.
Github user chandnisingh closed the pull request at:

    https://github.com/apache/incubator-apex-site/pull/4


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-apex-site pull request: Changed contributor guidelines

Posted by chandnisingh <gi...@git.apache.org>.
Github user chandnisingh commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-site/pull/4#discussion_r44614366
  
    --- Diff: src/md/contributing.md ---
    @@ -9,15 +9,48 @@ The apex core and apex malhar repositories both have mirror repositories on gith
     This project welcomes new contributors. If you would like to help by adding new features, enhancements or fixing bugs, here is how to do it.
     
     1. Create a [JIRA](https://malhar.atlassian.net/) for the work you plan to do (or assign yourself to an existing JIRA ticket)
    -1. Fork the ASF github mirror (one time step):
    -   https://github.com/apache/incubator-apex-core/
    -1. Create a new branch from the [devel-3](https://github.com/apache/incubator-apex-core/tree/devel-3) branch. **Name your branch with the JIRA number in it, e.g. `APEX-123.my-feature`.**
    -1. When adding new files, please include the Apache v2.0 license header.
    +2. Fork the ASF github mirror (one time step):
    --- End diff --
    
    If we are viewing this in simple text editor, then it is confusing. Not everyone uses a markdown editor.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-apex-site pull request: Changed contributor guidelines

Posted by tweise <gi...@git.apache.org>.
Github user tweise commented on the pull request:

    https://github.com/apache/incubator-apex-site/pull/4#issuecomment-155970702
  
    Yes, it's master


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-apex-site pull request: Changed contributor guidelines

Posted by chandnisingh <gi...@git.apache.org>.
Github user chandnisingh commented on the pull request:

    https://github.com/apache/incubator-apex-site/pull/4#issuecomment-155969441
  
    @andyperlitch Is the master branch the active branch in this repo?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---